User Details
- User Since
- Jul 25 2015, 10:06 AM (460 w, 16 h)
Wed, May 15
Tue, May 14
Sun, May 12
Address the last big comment from @fernape .
Fix issues outlined in the reviews (links are ok now, lists are rendered correctly, ...) and some minor change in phrasing.
Thu, May 9
Wed, May 8
This doesn't apply to -current anymore, mainly in vm_page.h (all used upto 0x8000). I tried a naive / mechanical implementation without researching/understanding this part, by using 0x10000 for VM_ALLOC_NOFREE, and with VM_ALLOC_COUNT_MASK set to 0x1ffff, and VM_ALLOC_COUNT_SHIFT set to 17, but this panics.
Thu, May 2
Apr 18 2024
Apr 15 2024
Apr 11 2024
Apr 9 2024
Apr 8 2024
The summary tells the value ranges from 0 to 1. The reality is that it ranges from INT_MIN to 1000.
@alc you asked about a way to measure the fragmentation, is https://reviews.freebsd.org/D40575 maybe something which helps for this?
Mar 29 2024
Mar 28 2024
Mar 21 2024
Mar 11 2024
Mar 7 2024
Mar 4 2024
Mar 3 2024
Feb 28 2024
Feb 23 2024
Feb 22 2024
Feb 18 2024
Should we move this to a mailinglist? This review is closed and any new changes will be a new review. So a discussion in this review looks off-topic to me.
Build failures:
lang/rust doesn't build. The same version builds just fine before the libsys+rtld changes.
cargo-c doesn't build. Same symptom than rust. Both fails in "libc" as shown above in the comment.
I don't have enough knowledge about rust to provide more info.
Can the issues this patch is supposed to fix lead to compile issues? I see failing rust and cargo-c builds in the "libc" part. And I see issues with nslookup to a bind 9.18 which serves an internal domain.
Feb 14 2024
I updated the src but build only ld-elf.so.1. What is committed works. I will do a full buildworld now. Consider it OK unless I come back to you. ;-)
nm /libexec/ld-elf.so.1 | grep 0x00004da
Mittwoch, 14. Februar 2024, 10:47:15
{0} <FreeBSD 15.0-CURRENT> [imap:/]
(210) root@ttypts/2 # ll /var/run/dovecot/*.core
zsh: no matches found: /var/run/dovecot/*.core
nm /libexec/ld-elf.so.1 | grep symlook_obj_load_filtees
000000000000cfe0 t symlook_obj_load_filtees
For the benefit of subscribers: the biiiiiig backtrace has been provided out-of-band.
Feb 13 2024
Dovecot crashes with this patch. With first patch via email it works for me.
Feb 9 2024
This is the "install" part only. Is this review also supposed to get the dependency part for this to work (e.g. a port depending on only a subpackage and the recursive dependency tracking and install needs to set TARGET_SUBPACKAGE), or is the dependency part supposed to come / available in another review?
Feb 7 2024
Feb 6 2024
Feb 1 2024
Jan 31 2024
The comments for rc.subr also apply to the new files.
What about a man page update how to turn on the debug feature? To my current understanding DEBUG_SH can be set interactively in the loader, and administratively in loader.conf... maybe also in rc.conf? So more than one man page to touch at least with a cross-ref.
Jan 24 2024
I have reworded the rc-scripting part. Does this make it more easy / clear?
Jan 22 2024
Jan 21 2024
Jan 20 2024
Jan 17 2024
Address comments in the review.
Jan 11 2024
- make some scripts compatible with svcj (convert parts of the precmd into another way of settings variables), precmd is not run inside the same shell/jail = make it work with svcj
- add some support for nfs in svcj, not yet finished (precmd is not comaptible)
- exclude some scripts from svcj due to an incompatible precmd (not run in same shell/jail)
Make jls quiet.
Jan 8 2024
Jan 4 2024
Address issues from comments.
Jan 1 2024
Dec 26 2023
Dec 23 2023
Dec 18 2023
Dec 14 2023
Dec 11 2023
Dec 9 2023
Dec 7 2023
Nov 30 2023
Nov 29 2023
Nov 28 2023
Nov 27 2023
Nov 24 2023
Only rc.d/opensm is missing.
Nov 16 2023
Add support for nfs. Sort the options.
Add config for some more services.