Page MenuHomeFreeBSD

kp (Kristof Provost)
Troubleshooter

Projects (6)

User Details

User Since
Sep 28 2014, 7:22 PM (573 w, 4 d)

Recent Activity

Today

kp committed rGb84666f798e8: pf: export expiration time as time_t (authored by kp).
pf: export expiration time as time_t
Thu, Sep 25, 12:42 PM
kp committed rG08fbad1b135b: pfctl: refactor 'rule_numbers' variable (authored by kp).
pfctl: refactor 'rule_numbers' variable
Thu, Sep 25, 12:42 PM
kp committed rGc913959e9e03: pf tests: basic 'once' test (authored by kp).
pf tests: basic 'once' test
Thu, Sep 25, 12:42 PM
kp committed rG2c53e251601c: pf tests: test once rule inside an anchor (authored by kp).
pf tests: test once rule inside an anchor
Thu, Sep 25, 12:42 PM
kp committed rG64bfb82f1741: pfctl: print once shot rule expiration time (authored by kp).
pfctl: print once shot rule expiration time
Thu, Sep 25, 12:42 PM
kp committed rGceff35a3aeef: pfctl: fix anchor handling for nat/rdr/binat anchors (authored by kp).
pfctl: fix anchor handling for nat/rdr/binat anchors
Thu, Sep 25, 12:42 PM
kp committed rGcc97633b4b7a: pfctl.8/pf.conf.5: Improve "once" bits (authored by kp).
pfctl.8/pf.conf.5: Improve "once" bits
Thu, Sep 25, 12:42 PM
kp committed rGde8af57c6f41: pf: simplify expiration of 'once' rules. (authored by kp).
pf: simplify expiration of 'once' rules.
Thu, Sep 25, 12:42 PM
kp committed rG59f3838b0a94: pfctl: reduce duplicate code (authored by kp).
pfctl: reduce duplicate code
Thu, Sep 25, 12:42 PM
kp committed rG2be46b52f5db: pfctl: fix once rules (authored by kp).
pfctl: fix once rules
Thu, Sep 25, 12:42 PM
kp committed rGb9d652bb75ff: pf: print 'once' rule expire time (authored by kp).
pf: print 'once' rule expire time
Thu, Sep 25, 12:42 PM
kp committed rGd3b73a944b11: pfctl: deny "once" flags for match rules (authored by kp).
pfctl: deny "once" flags for match rules
Thu, Sep 25, 12:42 PM
kp committed rGb7ff11b380bf: pf.conf.5: Document a "once" filter option used to create one shot rules. (authored by kp).
pf.conf.5: Document a "once" filter option used to create one shot rules.
Thu, Sep 25, 12:42 PM
kp committed rG8a4386142d05: pfctl tests: basic 'once' rule test (authored by kp).
pfctl tests: basic 'once' rule test
Thu, Sep 25, 12:42 PM
kp committed rGaf922319e813: pf: support one shot rules (authored by kp).
pf: support one shot rules
Thu, Sep 25, 12:42 PM
kp committed rG882121672704: pfctl: One shot rules can be used in pf.conf by specifying a "once" filter… (authored by kp).
pfctl: One shot rules can be used in pf.conf by specifying a "once" filter…
Thu, Sep 25, 12:42 PM

Yesterday

kp committed rGe70a2bcdc4f7: pf: fix rules_counter:keepcounters test (authored by kp).
pf: fix rules_counter:keepcounters test
Wed, Sep 24, 1:41 PM
kp accepted D52448: pf: Fix interface counters for af-to rules.
Wed, Sep 24, 11:48 AM
kp committed rG7ec06143964a: pf: pass pre-NAT addresses to dummynet (authored by kp).
pf: pass pre-NAT addresses to dummynet
Wed, Sep 24, 11:45 AM
kp committed rGdc0cf0648c8d: pf: check if a group has a kif before dereferencing it (authored by kp).
pf: check if a group has a kif before dereferencing it
Wed, Sep 24, 11:45 AM
kp accepted D52447: pf: Fix rule and state counters.
Wed, Sep 24, 11:38 AM
kp accepted D52446: pf: Always skip outbound filtering for inbound af-to rules.
Wed, Sep 24, 11:31 AM

Fri, Sep 19

kp accepted D52176: pf: Add pfsync protocol for FreeBSD 15.
Fri, Sep 19, 8:21 AM

Thu, Sep 18

kp accepted D52445: pf: Fix interface binding for af-to with route-to.
Thu, Sep 18, 7:32 AM

Wed, Sep 17

kp committed rGe63534edbcd0: pf: fix rules_counter:keepcounters test (authored by kp).
pf: fix rules_counter:keepcounters test
Wed, Sep 17, 2:16 PM
kp committed rG3c3322d7ee97: pf.conf.5: rephrase macro section (authored by kp).
pf.conf.5: rephrase macro section
Wed, Sep 17, 2:16 PM
kp committed rGc016bd00294d: pfctl.8: -z honours -a (reset rule stats per anchor) (authored by kp).
pfctl.8: -z honours -a (reset rule stats per anchor)
Wed, Sep 17, 2:16 PM
kp committed rGfc63421de9f6: pf: allows TCP RST packets in the backwards window if ACK matches (authored by kp).
pf: allows TCP RST packets in the backwards window if ACK matches
Wed, Sep 17, 2:16 PM
kp committed rG7eb30b26aa12: pf tests: test set limit (authored by kp).
pf tests: test set limit
Wed, Sep 17, 2:16 PM
kp committed rG9d9bc7f462bd: pf: set limits before rules (authored by kp).
pf: set limits before rules
Wed, Sep 17, 2:16 PM
kp committed rG1066515eb521: pf: Count m_gethdr() failures in PFRES_MEMORY counter (authored by kp).
pf: Count m_gethdr() failures in PFRES_MEMORY counter
Wed, Sep 17, 2:16 PM
kp committed rG05e99f5d1751: pfctl.8: omit preceding flag from command/modifier lists to get tags (authored by kp).
pfctl.8: omit preceding flag from command/modifier lists to get tags
Wed, Sep 17, 2:16 PM
kp committed rG26c373aa367c: pf tests: declare a table inside an anchor (authored by kp).
pf tests: declare a table inside an anchor
Wed, Sep 17, 2:16 PM
kp committed rG9dfc5e03da50: pfctl: allow tables to be defined inside anchors (authored by kp).
pfctl: allow tables to be defined inside anchors
Wed, Sep 17, 2:16 PM
kp committed rG6e00a34c7613: ifconfig: also fix removing IPv6 addresses without netlink (authored by kp).
ifconfig: also fix removing IPv6 addresses without netlink
Wed, Sep 17, 8:09 AM
kp committed rG44d7a8298eae: ifconfig: also fix removing IPv6 addresses without netlink (authored by kp).
ifconfig: also fix removing IPv6 addresses without netlink
Wed, Sep 17, 8:09 AM

Mon, Sep 15

kp added inline comments to D52447: pf: Fix rule and state counters.
Mon, Sep 15, 1:03 PM
kp committed rGd0ea3de0fe71: pf tests: verify rule numbers in pflog output (authored by kp).
pf tests: verify rule numbers in pflog output
Mon, Sep 15, 11:55 AM
kp committed rG8e84e9443bb6: pfctl: remove prototypes with no matching function (authored by kp).
pfctl: remove prototypes with no matching function
Mon, Sep 15, 11:55 AM
kp committed rGa66df2b575c8: pf: sync_ifp doesn't exist, remove externs (authored by kp).
pf: sync_ifp doesn't exist, remove externs
Mon, Sep 15, 11:55 AM
kp committed rG2c42aecee696: pfctl: ctime(3) and ctime_r(3) can fail when timestamps are way off. (authored by kp).
pfctl: ctime(3) and ctime_r(3) can fail when timestamps are way off.
Mon, Sep 15, 11:55 AM
kp committed rG5e89648ee68e: pf tests: test fragment counters (authored by kp).
pf tests: test fragment counters
Mon, Sep 15, 11:55 AM
kp committed rGc00aca9a714e: pf: Show pf fragment reassembly counters. (authored by kp).
pf: Show pf fragment reassembly counters.
Mon, Sep 15, 11:55 AM
kp committed rG0a67f601fe4f: pf.conf.5: hint how to set tcp timeout collectively (authored by kp).
pf.conf.5: hint how to set tcp timeout collectively
Mon, Sep 15, 11:55 AM
kp committed rG79a0959affec: pfctl: add af-to and other missing action types in print_rule() (authored by kp).
pfctl: add af-to and other missing action types in print_rule()
Mon, Sep 15, 11:55 AM
kp committed rGc2d03a920ec7: pfctl: fix anchortypes bounds test (authored by kp).
pfctl: fix anchortypes bounds test
Mon, Sep 15, 11:55 AM
kp committed rG864458ce5025: pf.conf.5: document tcp.tsdiff (authored by kp).
pf.conf.5: document tcp.tsdiff
Mon, Sep 15, 11:55 AM
kp added inline comments to D52445: pf: Fix interface binding for af-to with route-to.
Mon, Sep 15, 7:11 AM
kp accepted D52543: if_ovpn.c: fix use of uninitialized variable.
Mon, Sep 15, 6:26 AM

Sat, Sep 13

kp committed rG4403631977a0: pf: fix possible pd->pcksum NULL deref (authored by kp).
pf: fix possible pd->pcksum NULL deref
Sat, Sep 13, 1:13 PM

Fri, Sep 12

kp committed rG995d95c309fc: if_ovpn tests: skip float and linklocal test on < 2.7 (authored by kp).
if_ovpn tests: skip float and linklocal test on < 2.7
Fri, Sep 12, 6:59 AM

Wed, Sep 10

kp committed rGc8fb5a4d032b: ifconfig: also fix removing IPv6 addresses without netlink (authored by kp).
ifconfig: also fix removing IPv6 addresses without netlink
Wed, Sep 10, 7:53 PM
kp committed rG53e44c59d13e: pf tests: test state killing by source and destination address (authored by kp).
pf tests: test state killing by source and destination address
Wed, Sep 10, 7:53 PM
kp committed rG4889545b8795: pfctl: fix killing state by source and destination address (authored by kp).
pfctl: fix killing state by source and destination address
Wed, Sep 10, 7:53 PM
kp committed rGd3020caed603: pf tests: recusrive table printing test (authored by kp).
pf tests: recusrive table printing test
Wed, Sep 10, 7:52 PM
kp committed rG7aac81a639b4: pfctl: support recusive printing of tables (authored by kp).
pfctl: support recusive printing of tables
Wed, Sep 10, 7:52 PM
kp committed rG66694675be29: pfctl: Use pfctl_fopen (authored by kp).
pfctl: Use pfctl_fopen
Wed, Sep 10, 7:52 PM
kp committed rG94804658ab04: pf: Remove dead code in pf_pull_hdr(). (authored by kp).
pf: Remove dead code in pf_pull_hdr().
Wed, Sep 10, 7:52 PM

Sun, Sep 7

kp added a comment to D52415: Summary: Remove support for FreeBSD end-of-life 14.2 (2025-09-30).

libifconfig and libpfctl look fine to me.

Sun, Sep 7, 9:04 PM

Sat, Sep 6

kp committed R11:5e99d7ca8ae0: net/libpfctl: add 15.0 tarball (authored by kp).
net/libpfctl: add 15.0 tarball
Sat, Sep 6, 6:53 PM

Fri, Sep 5

kp committed rG9e792f7ef729: sys/netinet6: Fix SLAAC for interfaces with no /64 LL address (authored by linnemannr_gmail.com).
sys/netinet6: Fix SLAAC for interfaces with no /64 LL address
Fri, Sep 5, 9:54 PM
kp closed D51778: sys/netinet6: Fix SLAAC for interfaces with no /64 LL address.
Fri, Sep 5, 9:53 PM
kp committed rGc23eda976a8a: pf: fix possible pd->pcksum NULL deref (authored by kp).
pf: fix possible pd->pcksum NULL deref
Fri, Sep 5, 7:55 PM

Thu, Sep 4

kp accepted D52379: tests: disable transmit checksum offloading for epair interfaces.
Thu, Sep 4, 11:40 AM

Wed, Sep 3

kp committed rGf4f42421f38e: pf tests: sctp:pfsync robustness improvement (authored by kp).
pf tests: sctp:pfsync robustness improvement
Wed, Sep 3, 5:02 PM
kp added inline comments to D52176: pf: Add pfsync protocol for FreeBSD 15.
Wed, Sep 3, 2:37 PM
kp committed rG512d3c3a2c63: if_ovpn tests: skip float and linklocal test on < 2.7 (authored by kp).
if_ovpn tests: skip float and linklocal test on < 2.7
Wed, Sep 3, 10:11 AM
kp closed D52234: if_ovpn tests: skip float and linklocal test on < 2.7.
Wed, Sep 3, 10:11 AM

Tue, Sep 2

kp committed rG275ff85b254c: pf: fix struct pf_krule_global leak (authored by kp).
pf: fix struct pf_krule_global leak
Tue, Sep 2, 9:13 PM
kp committed rG44cc3b273191: pf: free struct pf_krule_global with pf_rule_tree_free() (authored by kp).
pf: free struct pf_krule_global with pf_rule_tree_free()
Tue, Sep 2, 9:13 PM
kp committed rGea15fe2e8cbc: pf: fix memory leak in legacy getstate calls (authored by kp).
pf: fix memory leak in legacy getstate calls
Tue, Sep 2, 9:13 PM
kp committed rGaa790af10a9a: pf(4) when doing af-to translation for ICMP protocol sends packets (authored by kp).
pf(4) when doing af-to translation for ICMP protocol sends packets
Tue, Sep 2, 9:12 PM
kp committed rG5af7499b6d81: pf: remove unused variables (authored by kp).
pf: remove unused variables
Tue, Sep 2, 9:12 PM
kp committed rGddd39152743a: pf: Introduce M_PF type for pf(4) related memory allocations. (authored by kp).
pf: Introduce M_PF type for pf(4) related memory allocations.
Tue, Sep 2, 9:12 PM
kp committed rGd64ba46792e7: pfctl: Rewrite some ugly for loops (authored by kp).
pfctl: Rewrite some ugly for loops
Tue, Sep 2, 9:12 PM
kp committed rG67082c75f740: pf: should be enforcing TTL=1 to packets sent to 224.0.0.1 only. (authored by kp).
pf: should be enforcing TTL=1 to packets sent to 224.0.0.1 only.
Tue, Sep 2, 9:11 PM
kp committed rG932ec59d9996: pf: fix ICMP type/code representation (authored by kp).
pf: fix ICMP type/code representation
Tue, Sep 2, 9:11 PM

Fri, Aug 29

kp added a comment to D52234: if_ovpn tests: skip float and linklocal test on < 2.7.

Instead of skipping these and keeping around lots of code to check the ovpn version, why not just temporarily xfail them like I've done in the attached patch of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289150? That way, once Ports contains ovpn>=2.7, these tests will automatically start failing again with the message "failed: expected failure, but none found". We can remove the xfails promptly afterwards.

Fri, Aug 29, 1:16 PM
kp requested review of D52234: if_ovpn tests: skip float and linklocal test on < 2.7.
Fri, Aug 29, 9:43 AM

Thu, Aug 28

kp accepted D52128: libifconfig: Add netlink based helper to bring the interface up/down.
Thu, Aug 28, 8:24 AM

Wed, Aug 27

kp added inline comments to D52176: pf: Add pfsync protocol for FreeBSD 15.
Wed, Aug 27, 9:35 AM

Aug 26 2025

kp accepted D52171: udp: slightly refactor udp_append().
Aug 26 2025, 6:11 PM
kp accepted D52170: udp: don't leak mbuf if tunnel didn't consume and inpcb is gone.
Aug 26 2025, 6:11 PM

Aug 25 2025

kp accepted D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
Aug 25 2025, 8:59 AM
kp added a comment to D52128: libifconfig: Add netlink based helper to bring the interface up/down.

Also not something that must be done in this commit, but we should modify sbin/ifconfig to the new functions. That'll remove a little more code from ifconfig and it'll mean we test this code (as part of any test that runs ifconfig foo up).

Aug 25 2025, 8:57 AM

Aug 22 2025

kp added a comment to D52056: netlink: Bypass refcounting when setting promiscuity.

The commit message needs to answer the "Why?".
Why are we bypassing the reference counting?

Aug 22 2025, 3:11 PM
kp accepted D50781: pf: Add prefer-ipv6-nexthop option for route-to pools.
Aug 22 2025, 12:11 PM

Aug 20 2025

kp committed rG063dc452cc96: pfctl.8: small cleanups (authored by kp).
pfctl.8: small cleanups
Aug 20 2025, 8:12 AM
kp committed rG95fda90b84d7: pf: rewrite the pf_state_peer_ntoh and pf_state_peer_hton macros as functions. (authored by kp).
pf: rewrite the pf_state_peer_ntoh and pf_state_peer_hton macros as functions.
Aug 20 2025, 8:12 AM
kp committed rG005e24b7a546: pf: remove duplicate struct definition (authored by kp).
pf: remove duplicate struct definition
Aug 20 2025, 8:12 AM

Aug 18 2025

kp committed rG47785e6a39cd: syslogd: EAGAIN and ECONNREFUSED are not permanently fatal (authored by kp).
syslogd: EAGAIN and ECONNREFUSED are not permanently fatal
Aug 18 2025, 3:11 PM
kp closed D51995: syslogd: EAGAIN and ECONNREFUSED are not permanently fatal.
Aug 18 2025, 3:11 PM
kp committed rGda64f6e047b5: pfctl: zero the number of added/deleted addresses (authored by kp).
pfctl: zero the number of added/deleted addresses
Aug 18 2025, 10:08 AM
kp committed rG094a60281b9e: pf: fix potential infinite loop adding/deleting addresses in tables (authored by kp).
pf: fix potential infinite loop adding/deleting addresses in tables
Aug 18 2025, 10:08 AM
kp requested review of D51995: syslogd: EAGAIN and ECONNREFUSED are not permanently fatal.
Aug 18 2025, 10:02 AM
kp added a comment to D51985: vtnet.4: improve existing descriptions and add missing ones.

Looks good, other than these minor remarks.

Aug 18 2025, 7:36 AM

Aug 14 2025

kp accepted D50781: pf: Add prefer-ipv6-nexthop option for route-to pools.

A quick pfctl test case for the parser changes (i.e. just a simple prefer-ipv6-nexthop route-to line) would be nice to have too.

Aug 14 2025, 8:42 AM

Aug 13 2025

kp committed rGd60022f3c24e: if_ovpn: support IPv6 link-local addresses (authored by kp).
if_ovpn: support IPv6 link-local addresses
Aug 13 2025, 1:38 PM
kp committed rGa0e5fe32d969: if_ovpn tests: basic float test case (authored by kp).
if_ovpn tests: basic float test case
Aug 13 2025, 1:38 PM
kp committed rGfc387ed68f3c: if_ovpn: support floating clients (authored by kp).
if_ovpn: support floating clients
Aug 13 2025, 1:38 PM