Fixed if (token)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 7 2024
Mar 7 2024
cristian.marussi_arm.com updated the diff for D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.
cristian.marussi_arm.com updated the diff for D43046: scmi: Introduce a new SCMI API and port CLK SCMI driver to it.
Reworked to rebase cleanly on other series changes
cristian.marussi_arm.com updated the diff for D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.
Moved sc->trs allocation earlier
cristian.marussi_arm.com updated the diff for D43044: scmi: Add new SCMI interfaces for init and message processing.
Made scmi_detach static
cristian.marussi_arm.com updated the diff for D43039: scmi: Split out the SCMI mailbox to a new file.
Removed the extres header references
cristian.marussi_arm.com added inline comments to D43039: scmi: Split out the SCMI mailbox to a new file.
cristian.marussi_arm.com added inline comments to D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.
cristian.marussi_arm.com added inline comments to D43044: scmi: Add new SCMI interfaces for init and message processing.
Mar 1 2024
Mar 1 2024
Using mallocarray and dropping empty interface method
Removed needless checks on malloc, using mallocarray
cristian.marussi_arm.com updated the diff for D43046: scmi: Introduce a new SCMI API and port CLK SCMI driver to it.
Removed needless malloc checks
cristian.marussi_arm.com updated the diff for D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.
Removed check on malloc return value
cristian.marussi_arm.com updated the diff for D43044: scmi: Add new SCMI interfaces for init and message processing.
Removed needless empty interface methods
Removed __FBSDID
cristian.marussi_arm.com updated the diff for D43039: scmi: Split out the SCMI mailbox to a new file.
Removed the __FBSDID
Feb 8 2024
Feb 8 2024
Thanks for the review @bryanv.
Regarding:
Jan 18 2024
Jan 18 2024
cristian.marussi_arm.com added a comment to D43045: scmi: Add SCMI message tracking and centralize tx/rx logic.
In D43045#989478, @andrew wrote:Could you use unr(9), the kernel unit number allocator, to allocate the tokens?
cristian.marussi_arm.com added a comment to D43044: scmi: Add new SCMI interfaces for init and message processing.
In D43044#989468, @andrew wrote:The attach and detach functions that just call smci_attach and smci_detach could be removed. If a driver doesn't implement a method, but the parent does then the parent implementation will be used.
Dec 13 2023
Dec 13 2023
cristian.marussi_arm.com added a comment to D43038: scmi: Implement scmi_clknode_recalc_freq method.
SCMI: Add support for multiple transports and add VirtIO/SMC transports
cristian.marussi_arm.com requested review of D43039: scmi: Split out the SCMI mailbox to a new file.