I accepted the review, I said that I do not have rational arguments against it.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Today
I think that this is technically correct but unfair. Intent was that failed unlocked buffer lookup should not change the behavior, in particular, allowing the normal lookup quirks to proceed.
Yesterday
What if you revert the order of allocation, first finding some domain which provides enough physical pages to back the stack, and then try to allocate KVA from corresponding arena?
Sat, May 18
Fri, May 17
Use NPTEPG
+1 for maxcnt
remove cnt == 0 check
Thu, May 16
Move SHMSEG symbols.
Wed, May 15
These two seems to be the only uses of if_getbpf() in the tree, unless I mis-grepped. Is this the cause for the change?
Correct cnt, one more time.
I think it would be useful to have an option to disable SU, so that you still can format a volume with single command invocation regardless of SU enablement.
Tue, May 14
Fix cnt calculation for 4k step in invlrng.
Flip default for invlpgb_works to 1.
Mon, May 13
Fix typo
Not tested at all, machine is not yet available. I want to discuss this before debugging.
Thank you
In D45175#1030481, @rbranco_suse.com wrote:The native FreeBSD ipcs command also uses these sysctl's.
Sun, May 12
Do check for vp->v_object == NULL in writecount_recalc().
tmpfs_destroy_vobject(): clear v_object under the object lock
In D45119#1030166, @markj wrote:Right. And finally, suppose that old > new and new != 0. Then we should not re-set OBJ_TMPFS_VREF in the else-case of the hunk you posted below.
Sat, May 11
In D45161#1030118, @aokblast wrote:For preloaded relocatable kernel module, I think the modification of loader is necessary as I discover SHT_NOTE section was not loaded by boot1 originally when the kernel module is preloaded.
This is most likely can/should be fixed by linker script.
Thinking about it more, why does the loader change needed at all? Kernel parses/should parse the elf.
It probably makes sense to split the change into two: one for loader, one for kernel.
Fri, May 10
Latest driver IPSEC support code.
In D45119#1029846, @markj wrote:In D45119#1029542, @kib wrote:In D45119#1029511, @markj wrote:I do not see how this solves the problem that @pho found. There, vm_map_process_deferred() was releasing writecounts, and in one case the backing vnode was doomed, so OBJ_TMPFS_VREF was clear.
Do you mean https://people.freebsd.org/~pho/stress/log/log0518.txt? I agree that this is different. But for me, log0518 states that clearing of OBJ_TMPFS_VREF and clearing of node->tn_vnode are not atomic (and really cannot be). So the assert "object with writable mappings does not have a reference" should be removed, because indeed vp might be in process of reclaim or the pointer to vp might be already invalid.
Yes, but that isn't sufficient. Consider that tmpfs_pager_writecount_recalc() will vrele() the vnode if the writecount drops to 0, which is incorrect if the TMPFS_VREF flag is already clear.
Thu, May 9
Latest version after the rounds of bugfixes
In D45119#1029511, @markj wrote:I do not see how this solves the problem that @pho found. There, vm_map_process_deferred() was releasing writecounts, and in one case the backing vnode was doomed, so OBJ_TMPFS_VREF was clear.
Wed, May 8
Reduce scope for object1 and color variables.
Assign OBJT_DEAD type to object before deallocating it on the path after failing ctr, since we do not want to have the device dtr called.
Use vm_object_deallocate() instead of _terminate() on cleanup path.
Defer OBJ_COLORED setting after ctr provides the color.
In D45058#1029152, @tijl wrote:I spent yesterday and today on this but it's taking too much time to familiarise myself with the code so I won't be able to fix this in a timely manner. It's also too risky to make changes to drm-*-kmod this close to 14.1. So I've created D45125 which should be safe to MFC.
Are the following statements correct:
- Physical RAM may be divided in segments with address ranges that are separated from each other.
Right
Remove refcount.h
Remove invalid assert about zero writemappings of the object for the new vnode (since node might be old).
Add asserts that we do not underflow writemapping counters for swap pagers.
In D44306#1028427, @ashafer_badland.io wrote: