Move lock of uart frontend to uart backend in bhyve
ClosedPublic
Actions

Authored by aokblast on Thu, Apr 25, 4:05 PM.

Details

Reviewers

markj
lwhsu
corvink
jhb

Group Reviewers

bhyve

Commits

rGe10b9d6602df: bhyve: Move lock of uart frontend to uart backend

Summary

Currently, lock of uart in bhyve is placed in frontend. There are some problems about it:

If every frontend should has a lock, why not move it inside backend as they all have same uart_softc.
If backend needs to modify the information of uart after initialize, it will be impossible as backend cannot use lock. For example, if we want implement a telnet support for uart in backend, It should wait for connection when initialize. After some remote process connect it, it needs to modify rfd and wfd in backend.

So I decide to move it to backend.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aokblast created this revision.Thu, Apr 25, 4:05 PM

Herald added a reviewer: bhyve. · View Herald TranscriptThu, Apr 25, 4:05 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

aokblast requested review of this revision.Thu, Apr 25, 4:05 PM

Harbormaster completed remote builds in B57357: Diff 137664.Thu, Apr 25, 4:05 PM

aokblast retitled this revision from Move lock of uart frontend to uartbackend to Move lock of uart frontend to uart backend in bhyve.Thu, Apr 25, 4:12 PM

aokblast edited the summary of this revision. (Show Details)

aokblast added reviewers: markj, lwhsu.

aokblast added subscribers: lwhsu, markj.

aokblast removed subscribers: markj, lwhsu.

corvink added a subscriber: corvink.Fri, Apr 26, 6:59 AM

corvink added inline comments.