Differential D44732

pciconf(8): dump AMD IOMMU Base Capability
ClosedPublic
Actions

Authored by kib on Apr 9 2024, 11:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 5, 6:47 AM

	Unknown Object (File)
	Sat, Apr 27, 9:39 PM

	Unknown Object (File)
	Fri, Apr 26, 5:00 AM

	Unknown Object (File)
	Fri, Apr 12, 8:15 PM

	Unknown Object (File)
	Apr 10 2024, 5:29 AM

Subscribers

Details

Reviewers

emaste
markj

Commits

rG1e6db7be6921: pciconf(8): dump AMD IOMMU Base Capability
rG33adb388c78e: pcireg.h: Add AMD IOMMU Base Cap definitions
rG1cd9868f04c3: pcireg.h: add include guard

Summary

Also,
pcireg.h: Add AMD IOMMU Base Cap definitions
pcireg.h: add include guard

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Apr 9 2024, 11:15 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 9 2024, 11:15 PM

kib requested review of this revision.Apr 9 2024, 11:15 PM

emaste accepted this revision.Apr 10 2024, 12:14 AM

emaste added inline comments.

sys/dev/pci/pcireg.h
1128	What do you think about including a reference to the source document for these additions (and in general) - URL and/or title? https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/specifications/48882_IOMMU.pdf

This revision is now accepted and ready to land.Apr 10 2024, 12:14 AM

kib marked an inline comment as done.Apr 10 2024, 12:26 AM

kib added inline comments.

sys/dev/pci/pcireg.h
1128	URLs rot too fast.

Reference the IOMMU spec for pcireg.h

This revision now requires review to proceed.Apr 10 2024, 12:27 AM

emaste accepted this revision.Apr 10 2024, 12:28 AM

This revision is now accepted and ready to land.Apr 10 2024, 12:28 AM

Closed by commit rG1cd9868f04c3: pcireg.h: add include guard (authored by kib). · Explain WhyApr 10 2024, 5:29 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG1cd9868f04c3: pcireg.h: add include guard.

kib added a commit: rG33adb388c78e: pcireg.h: Add AMD IOMMU Base Cap definitions.

kib added a commit: rG1e6db7be6921: pciconf(8): dump AMD IOMMU Base Capability.

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

5 lines

Diff 136834

sys/dev/pci/pcireg.h

Loading...