Framework: Introduce bsd.sponsor.mk
Needs ReviewPublic
Actions

Authored by arrowd on Mar 23 2024, 7:41 PM.

Details

Reviewers

mat

Group Reviewers

portmgr

Summary

These changes add two framework-level make targets:

make sponsor pops out a dialog window listing available sponsorship options. Choosing one calls xdg-open or echo with corresponding URL
make sponsor-describe outputs sponsorship information in machine-readable format

Sponsorship info can be specified on the per-port basis, or in a common DB
file bsd.sponsor.db.mk

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 57156
Build 54044: arc lint + arc unit

Event Timeline

arrowd requested review of this revision.Mar 23 2024, 7:41 PM

arrowd created this revision.

Harbormaster completed remote builds in B56758: Diff 136137.Mar 23 2024, 7:41 PM

mat added a subscriber: mat.Mar 23 2024, 8:12 PM

mat added inline comments.

Mk/bsd.sponsor.mk
39–40	This should probably be GH_PROJECT or something.

An interactive thing is nice and all, but we want users to stop using ports and use packages, so the sponsorship information should end up in the package's metadata, you should talk with @bapt to see how this could be done best.

This revision now requires changes to proceed.Mar 24 2024, 7:54 AM

we want users to stop using ports and use packages

Who "we"? I don't want that and will keep working in the direction I deem useful.

the sponsorship information should end up in the package's metadata

I agree, but for now it can be queried from the port with make sponsor-describe. AFAIK, freshports.org queries ports for data, not packages.

Use GH_ACCOUNT

Harbormaster completed remote builds in B56764: Diff 136148.Mar 24 2024, 8:52 AM

In D44487#1014655, @arrowd wrote:

we want users to stop using ports and use packages

Who "we"? I don't want that and will keep working in the direction I deem useful.

We is portmgr as a whole.
I don't mind you making things work for ports when it is broken, but we want to move forward, not backwards.
So, features need to be available in packages before they are of any use in ports.

Put sponsorship information into the resulting package via PKG_NOTES

Harbormaster completed remote builds in B56932: Diff 136611.Apr 6 2024, 6:37 PM

mat added inline comments.Apr 7 2024, 7:08 PM

Mk/bsd.sponsor.db.mk
9–10	I hope that there will be more than just you before this gets committed. Otherwise, it feels like you are adding a feature just to ask for money.