Page MenuHomeFreeBSD
Differential D43229

tegra210: use UTF-8, not ISO-8859
ClosedPublic
Actions

Authored by emaste on Dec 29 2023, 3:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 6, 2:18 PM
Unknown Object (File)
Wed, May 1, 2:00 AM
Unknown Object (File)
Fri, Apr 26, 5:29 AM
Unknown Object (File)
Thu, Apr 25, 2:13 AM
Unknown Object (File)
Thu, Apr 25, 2:13 AM
Unknown Object (File)
Mon, Apr 22, 3:16 AM
Unknown Object (File)
Fri, Apr 19, 5:49 AM
Unknown Object (File)
Fri, Apr 19, 2:18 AM
View All 18 Files
Subscribers
imp

Details

Reviewers
mmel
manu
andrew
Commits
rG7f156d86dfa9: tegra210: change to UTF-8 (from ISO-8859)
rG56c202de785a: tegra210: change to UTF-8 (from ISO-8859)
Summary

Prompted by "This is a binary file." in D43192 I had a look at sys/arm64/nvidia/tegra210/tegra210_xusbpadctl.c, which had an ISO-8859 μ. Convert to Unicode/UTF-8.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Dec 29 2023, 3:56 AM
Herald added a reviewer: andrew. · View Herald TranscriptDec 29 2023, 3:56 AM
Herald added a reviewer: andrew. · View Herald Transcript
emaste requested review of this revision.Dec 29 2023, 3:56 AM

(Click on View Options and change to UTF-8)

image.png (213×580 px, 14 KB)

manu added a comment.Dec 29 2023, 6:54 AM

Thanks, but I think that this is not supposed to be a Chinese char but just "20 sec Lock time", @mmel ?

mmel accepted this revision.Dec 29 2023, 7:11 AM
This revision is now accepted and ready to land.Dec 29 2023, 7:11 AM
mmel added a comment.Dec 29 2023, 7:20 AM

Maximum PLL lock time is 20 microsecond. Alternatively, we may use the 'us' to avoid UTF-8 in source files.

emaste added a comment.Dec 29 2023, 2:46 PM

Phabricator gets confused when the encoding is different between the before & after versions so you have to pick UTF-8 manually. Once done the right side looks like:

image.png (57×323 px, 5 KB)

We have some UTF-8 files in the tree already and I think μ is fine.

Closed by commit rG56c202de785a: tegra210: change to UTF-8 (from ISO-8859) (authored by emaste). · Explain WhyDec 29 2023, 2:51 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG56c202de785a: tegra210: change to UTF-8 (from ISO-8859).
Herald added a subscriber: imp. · View Herald TranscriptDec 29 2023, 2:51 PM
emaste added a commit: rG7f156d86dfa9: tegra210: change to UTF-8 (from ISO-8859).Tue, Apr 16, 1:58 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
nvidia/
tegra210/
4 lines

Diff 131974

View Options

sys/arm64/nvidia/tegra210/tegra210_xusbpadctl.c

Loading...