Page MenuHomeFreeBSD

man(1) does not support spaces in filenames
ClosedPublic

Authored by wosch on Dec 28 2023, 3:07 PM.
Tags
None
Referenced Files
F85160756: D43222.diff
Sun, Jun 2, 9:34 AM
Unknown Object (File)
Sun, May 26, 10:09 PM
Unknown Object (File)
Sun, May 26, 10:09 PM
Unknown Object (File)
Sun, May 26, 3:01 AM
Unknown Object (File)
Fri, May 10, 12:29 PM
Unknown Object (File)
Apr 27 2024, 4:30 AM
Unknown Object (File)
Feb 22 2024, 5:06 AM
Unknown Object (File)
Feb 14 2024, 3:13 AM
Subscribers

Details

Summary

There is another problem with white spaces. The globbing function in exists() cannot handle white spaces. This is not trivial to fix, we have to rewrite the function.

mkdir -p man/man1
cp /usr/share/man/man1/cat.1.gz "man/man1/ZZZ cat.1.gz"
/usr/bin/man -M man "ZZZ cat"
No manual entry for ZZZ
No manual entry for cat

see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275978

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wosch requested review of this revision.Dec 28 2023, 3:07 PM
This revision is now accepted and ready to land.Jan 4 2024, 4:23 AM
emaste added inline comments.
usr.bin/man/man.sh
194–196

should this comment be "at least one real file"?

206–213

style in the rest of the file seems to want
for file in ...; do
but but fine either way

This revision was automatically updated to reflect the committed changes.