TI has a new idea to collect some clocks within a ti,clksel. checkout clock@664 and clock@52c in sys/contrib/device-tree/src/arm/am33xx-clocks.dtsi
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I'm not sure what this driver actually does, so I'm probably not the one to approve it. Just a few cosmetic issues.
| sys/arm/ti/clk/ti_clksel.c | ||
|---|---|---|
| 107 | Looks like a debugging printf? | |
| 108 | It seems like this test in the #if 0 is necessary. Why is it #if 0? | |
| 120 | This seems like debugging too. | |
| 122 | What is this block? If it is not needed, maybe shouldn't be here? | |
Comment Actions
Looks mostly ok, I guess TI loves to reimplement simple-bus like things ...
Same comments as Mike though.
| sys/arm/ti/clk/ti_clksel.c | ||
|---|---|---|
| 108 | the whole point in this driver is to give the reg field...It should be no #if0 around this section | |
Comment Actions
Background why this driver is added:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/arch/arm/boot/dts/am33xx-clocks.dtsi?h=v6.1.64&id=c2f2646057bcf3f86a75f6a8aa9fbd159a1d4784
Fix Mikes comments.