bhyve: initial Active Firmware Info for NVMe controller
ClosedPublic
Actions

Authored by wanpengqian_gmail.com on Oct 26 2021, 7:13 AM.

Details

Reviewers

chuck
jhb
markj
imp

Group Reviewers

bhyve

Commits

rG839b6e33089b: bhyve nvme: Fix Active Firmware Info
rG3cae10048d27: bhyve nvme: Fix Active Firmware Info

Summary

Currently Active Firmware Info is not initialized.
this patch will initial Active Firmware Info to slot 1.

Test Plan

Within FreeBSD/Linux guests, show the Firmware Logpage to confirm.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wanpengqian_gmail.com created this revision.Oct 26 2021, 7:13 AM

Herald added a reviewer: bhyve. · View Herald TranscriptOct 26 2021, 7:13 AM

Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript

wanpengqian_gmail.com requested review of this revision.Oct 26 2021, 7:13 AM

Harbormaster completed remote builds in B42364: Diff 97454.Oct 26 2021, 7:13 AM

wanpengqian_gmail.com added a reviewer: markj.Nov 29 2021, 10:14 PM

wanpengqian_gmail.com edited reviewers, added: imp; removed: grehan.Jan 12 2022, 6:20 AM

Any comments on this?
Obviously guest OS will work properly without this patch, but we can make the simulation more real.

chuck accepted this revision as: chuck.Mar 27 2022, 1:58 PM

This revision is now accepted and ready to land.Mar 27 2022, 1:58 PM

Closed by commit rG3cae10048d27: bhyve nvme: Fix Active Firmware Info (authored by wanpengqian_gmail.com, committed by chuck). · Explain WhyAug 14 2022, 6:19 PM

This revision was automatically updated to reflect the committed changes.

chuck added a commit: rG3cae10048d27: bhyve nvme: Fix Active Firmware Info.

corvink added a commit: rG839b6e33089b: bhyve nvme: Fix Active Firmware Info.Nov 14 2022, 8:26 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_nvme.c

5 lines

Diff 109340

View Options

bhyve: initial Active Firmware Info for NVMe controllerClosedPublicActions