Page MenuHomeFreeBSD
Differential D22808

Expand handling of the PCI Vendor ecap
ClosedPublic
Actions

Authored by scottl on Dec 13 2019, 10:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 11, 5:50 AM
Unknown Object (File)
Mon, Nov 10, 1:01 AM
Unknown Object (File)
Sat, Nov 8, 10:16 AM
Unknown Object (File)
Fri, Nov 7, 11:36 AM
Unknown Object (File)
Wed, Nov 5, 12:36 AM
Unknown Object (File)
Tue, Oct 28, 12:05 AM
Unknown Object (File)
Mon, Oct 27, 7:25 PM
Unknown Object (File)
Mon, Oct 27, 6:17 PM
View All 79 Files
Subscribers
None

Details

Reviewers
jhb
imp
Group Reviewers
manpages
Commits
rS355741: Add accessors for the Vendor Specific Extended Capability (VSEC)
Summary

Add accessors for the Vendor Specific Extended Capability (VSEC)
Parse out the VSEC. If the user invokes a second -c command line option,
do a hex dump of the vendor data.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

scottl created this revision.Dec 13 2019, 10:59 PM
Herald added a reviewer: manpages. · View Herald TranscriptDec 13 2019, 10:59 PM
Harbormaster completed remote builds in B28143: Diff 65635.Dec 13 2019, 10:59 PM
imp added inline comments.Dec 13 2019, 11:39 PM
usr.sbin/pciconf/cap.c
908 ↗(On Diff #65635)

don't you need a printf("\n"); at the end?

scottl added inline comments.Dec 13 2019, 11:41 PM
usr.sbin/pciconf/cap.c
908 ↗(On Diff #65635)

The ((i + 4) >= len) clause handles that.

imp accepted this revision.Dec 13 2019, 11:42 PM

I knew I was missing something :).
This looks OK to my eye now

This revision is now accepted and ready to land.Dec 13 2019, 11:42 PM
Closed by commit rS355741: Add accessors for the Vendor Specific Extended Capability (VSEC) (authored by scottl). · Explain WhyDec 13 2019, 11:47 PM
This revision was automatically updated to reflect the committed changes.
scottl added a commit: rS355741: Add accessors for the Vendor Specific Extended Capability (VSEC).

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
pci/
7 lines
usr.sbin/
pciconf/
36 lines
2 lines
3 lines
4 lines

Diff 65638

View Options

head/sys/dev/pci/pcireg.h

Loading...
View Options

head/usr.sbin/pciconf/cap.c

Loading...
View Options

head/usr.sbin/pciconf/pciconf.h

Loading...
View Options

head/usr.sbin/pciconf/pciconf.8

Loading...
View Options

head/usr.sbin/pciconf/pciconf.c

Loading...