Page MenuHomeFreeBSD
Differential D19200

bhyve(8) block_if.c remove multiple freeing of nopt added in r340042
ClosedPublic
Actions

Authored by rgrimes on Feb 14 2019, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 12:40 AM
Unknown Object (File)
Mon, May 13, 9:45 PM
Unknown Object (File)
Fri, May 10, 6:15 PM
Unknown Object (File)
May 2 2024, 8:43 AM
Unknown Object (File)
May 1 2024, 9:21 PM
Unknown Object (File)
Apr 26 2024, 2:41 PM
Unknown Object (File)
Apr 25 2024, 7:12 PM
Unknown Object (File)
Apr 18 2024, 6:53 PM
View All 34 Files
Subscribers
imp

Details

Reviewers
jhb
pmooney_pfmooney.com
Group Reviewers
bhyve
Commits
rS344159: In r340042 an attempt to quiet coverity warning cid 1305412 was overdone.
Summary

In r340042 an attempt to quiet coverity warning cid 1305412 was overdone.
nopt is the only allocated space, xopt and cp are aliases into that allocated space.

Remove the 2 unneeded free's

Brought to my attention by Patrick Mooney of Joyent/illumos

Test Plan

Visual code inspection.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rgrimes created this revision.Feb 14 2019, 7:28 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 14 2019, 7:28 PM
pmooney_pfmooney.com accepted this revision.Feb 14 2019, 7:32 PM

This is the fix we're applying to SmartOS bhyve, after syncing from upstream.

jhb accepted this revision.Feb 14 2019, 7:37 PM
This revision is now accepted and ready to land.Feb 14 2019, 7:37 PM
Closed by commit rS344159: In r340042 an attempt to quiet coverity warning cid 1305412 was overdone. (authored by rgrimes). · Explain WhyFeb 15 2019, 4:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bhyve/
2 lines

Diff 53969

View Options

head/usr.sbin/bhyve/block_if.c

Loading...