Change Details

The r316585 did break the sparc build, as the current code does not implement method to detect the disk size; this work is step to try to fix the issue. The OFW actually does define method to get the methods block-size - to get the media sector size #blocks (and/or #blocks64) to get the disk size. However, even as I wrote the wrappers for the methods, I am not sure if this is the way to access them, probably need to use call-method instead. The secondary issue is that while opening the partition, the disk size by itself will not do us any good - we would need partition size instead. But as alternate take, if we provide "bogus" size, the read of the 2 last labels will fail, but we should get the slightly better solution than before, as we can at least read the 2 first labels. In any case, this work needs testing and feedback from people who can actually test the code.

The r316585 did break the sparc build, as the current code does not implement method to detect the disk size, The userboot does query for disk size, but we need to update ioctl method and provide callback for vdev_probe(). The OFW actually does define methods: block-size - to get the media sector size #blocks (and/or #blocks64) to get the disk size. However, even as I wrote the wrappers for the methods, I have no way to test the implementations, also the disk size itself does not help us as the ofw code does not really use common/disk.c API and therefore the those functions are likely useful in future work, but not right now. The solution to provide partition size for vdev_probe() is about making partition size info available, For now, I am providing the partition size via global variable, as we call zfs_dev_probe() for each (recognized) partition. For userboot, the fix is quite straight forward, as userboot is already using common/disk.c API.

The r316585 did break the sparc build, as the current code does not not implement method to detect the disk size;, this work is stepThe userboot does query for disk size, but we need to try to fix the issueupdate ioctl method and provide callback for vdev_probe(). The OFW actually does define method to get the methodss: block-size - to get the media sector size #blocks (and/or #blocks64) to get the disk size. However, even as I wrote the wrappers for the methods, I am not sure if this is the way to access themhave no way to test the implementations, also the disk size itself does not help us as the ofw code does not really use common/disk.c API and therefore the those functions are likely useful in future work, probably need to use call-method insteadbut not right now. The secondary issueolution to provide partition size for vdev_probe() is that while opening the partitionabout making partition size info available, For now, the disk size by itself will not do us any good -I am providing the partition size via global variable, as we would need partition size insteadcall zfs_dev_probe() for each (recognized) partition. But as alternate take, if we provide "bogus" size, the read of the 2 last labels will failFor userboot, but we should get the slightly better solution than before, as we can at least read the 2 first labels. In any casefix is quite straight forward, this work needs testing and feedback from people who can actually test the codeas userboot is already using common/disk.c API.