Change Details

The bug without this fix: # doas ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_prefix 2a01:e140::/64 Segmentation fault (core dumped) # ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_if vmx0 Segmentation fault (core dumped) # ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_if vmx0 prefixlen 64 Segmentation fault (core dumped) Here is how I tested the new code: # ipfw nptv6 test create int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: prefixlen 64 # ipfw nptv6 test show nptv6 test int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: prefixlen 64 # ipfw nptv6 test create int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140::/64 prefixlen 64 ipfw: Bad IPv6 network address: 2a01:e140::/64 Use prefixlen option instead # ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_prefix 2a01:e140:: prefixlen 64 ipfw: Bad IPv6 network address: 2a01:e140:cafe::/64 Use prefixlen option instead # ipfw nptv6 test create int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: ipfw: prefixlen required # ipfw nptv6 test create prefixlen 64 int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: # ipfw nptv6 test show nptv6 test int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: prefixlen 64

The bug without this fix: ``` # doas ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_prefix 2a01:e140::/64 Segmentation fault (core dumped) # ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_if vmx0 Segmentation fault (core dumped) # ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_if vmx0 prefixlen 64 Segmentation fault (core dumped) ``` Here is how I tested the new code: ``` # ipfw nptv6 test create int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: prefixlen 64 # ipfw nptv6 test show nptv6 test int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: prefixlen 64 # ipfw nptv6 test create int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140::/64 prefixlen 64 ipfw: Bad IPv6 network address: 2a01:e140::/64 Use prefixlen option instead # ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_prefix 2a01:e140:: prefixlen 64 ipfw: Bad IPv6 network address: 2a01:e140:cafe::/64 Use prefixlen option instead # ipfw nptv6 test create int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: ipfw: prefixlen required # ipfw nptv6 test create prefixlen 64 int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: # ipfw nptv6 test show nptv6 test int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: prefixlen 64 ```

The bug without this fix: ``` # doas ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_prefix 2a01:e140::/64 Segmentation fault (core dumped) # ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_if vmx0 Segmentation fault (core dumped) # ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_if vmx0 prefixlen 64 Segmentation fault (core dumped) ``` Here is how I tested the new code: ``` # ipfw nptv6 test create int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: prefixlen 64 # ipfw nptv6 test show nptv6 test int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: prefixlen 64 # ipfw nptv6 test create int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140::/64 prefixlen 64 ipfw: Bad IPv6 network address: 2a01:e140::/64 Use prefixlen option instead # ipfw nptv6 test create int_prefix 2a01:e140:cafe::/64 ext_prefix 2a01:e140:: prefixlen 64 ipfw: Bad IPv6 network address: 2a01:e140:cafe::/64 Use prefixlen option instead # ipfw nptv6 test create int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: ipfw: prefixlen required # ipfw nptv6 test create prefixlen 64 int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: # ipfw nptv6 test show nptv6 test int_prefix 2a01:e140:cafe:: ext_prefix 2a01:e140:: prefixlen 64 ```