Change Details

Currently, a u_spcl symbol is exported in every compilation unit that includes dumprestore.h, which blows up with -fno-common. I suspect the intention was for this singleton instance of u_spcl to be local to the CU that included the file, rather than shared amongst multiple CUs, so make it static.

When dumprestore.h is used in an application, it is intended that all compilation units share the single u_spcl instance declared. Mark it extern and define it in the two applications in base that use it.

Currently, a u_spcl symbol is exported in every compilation unit that includes dumprestore.h, which blows up with -fno-common. I suspect the intention was for this singleton instance of u_spcl to be local to the CU that included the fileWhen dumprestore.h is used in an application, rather thanit is intended that all compilation units shared amongst multiple CUs, the single u_spcl instance declared. so make it staticMark it extern and define it in the two applications in base that use it.