Change Details

This comment was about copying some 'struct ucred' without bumping its reference counter, which has not been the case since commit "fork: assign refed credentials earlier" (SVN revision 280330, git ID 12cec311e607).

This comment was introduced in commit "Add racct. (...)" (SVN revision 220137, git ID 097055e26d9459c7). It refers to missing bumping resource counters at fork, but this is not necessary (and would actually be harmful). Process' credentials' resources are tracked via the 'struct ucred' pointed to by 'p_ucred' in its 'cr_uidinfo' and 'cr_ruidinfo' fields (of type 'struct uidinfo') and, on RACCT, through various 'struct racct' or 'struct prison_racct' structures pointed to by 'ui_racct' (for user-scope limits), 'pr_prison_racct' (for jail-scope limits) and 'lc_racct' (for login-class-scope limits). The fields of 'struct uidinfo' only concern resources that are either shared or unshared at fork, but never copied, so there is no need to update them. Additionally, the RACCT-related parts are already dealt with by racct_proc_fork(). Fixes: 097055e26d94 Add racct. (...) MFC after: 1 week Sponsored by: The FreeBSD Foundation

This comment was about copying some 'struct ucred' without bumping itsintroduced in commit "Add racct. (...)" (SVN revision reference counter220137, which has not been the case since commit "fork:git ID 097055e26d9459c7). It refers to missing bumping resource assign refed credentials earlier" (SVN revision 280330counters at fork, git IDbut this is not necessary (and would actually be 12cec311e607).harmful). Process' credentials' resources are tracked via the 'struct ucred' pointed to by 'p_ucred' in its 'cr_uidinfo' and 'cr_ruidinfo' fields (of type 'struct uidinfo') and, on RACCT, through various 'struct racct' or 'struct prison_racct' structures pointed to by 'ui_racct' (for user-scope limits), 'pr_prison_racct' (for jail-scope limits) and 'lc_racct' (for login-class-scope limits). The fields of 'struct uidinfo' only concern resources that are either shared or unshared at fork, but never copied, so there is no need to update them. Additionally, the RACCT-related parts are already dealt with by racct_proc_fork(). Fixes: 097055e26d94 Add racct. (...) MFC after: 1 week Sponsored by: The FreeBSD Foundation