Change Details

hwpmc has been utterly broken for userspace binaries, and has been labeling all samples from userspace binaries as dubious frames. The issues are that: - the check for ph.p_offset & (-ph.p_align) == 0 seemed entirely bogus, and was preventing any binary's exec. section from being considred. Replace this with a check for the current vaddr == 0 (meaning we're only taking the 1st exec. section in a binary) - due to how map-ins are recorded, we were double-counting the offsets for shared libraries. Jessica came up with a brilliant workaround, which is to simply not set the vaddr for relocatable objects. Thanks so much to Jessica for all the help in making hwpmc work correctly. This is mostly her work.

hwpmc has been utterly broken for userspace binaries, and has been labeling all samples from userspace binaries as dubious frames. The issues are that: - the check for ph.p_offset & (-ph.p_align) == 0 seemed entirely bogus, and was preventing any binary's exec. section from being considered. Replace this with a state boolean that ensures we only take the first executable section - due to how map-ins are recorded, we were double-counting the offsets for shared libraries. Jessica came up with a brilliant workaround, which is to simply not set the vaddr for relocatable objects. - set image->pi_entry = eh.e_entry as suggested by brett_gutste.in Thanks so much to Jessica for all the help in making hwpmc work correctly. This is mostly her work.

hwpmc has been utterly broken for userspace binaries, and has been labeling all samples from userspace binaries as dubious frames. The issues are that: - the check for ph.p_offset & (-ph.p_align) == 0 seemed entirely bogus, and was preventing any binary's exec. section from being considered. Replace this with a check for the current vaddr == 0 (meaning we'rstate boolean that ensures we only takinge the 1first exec.utable section in a binary)n - due to how map-ins are recorded, we were double-counting the offsets for shared libraries. Jessica came up with a brilliant workaround, which is to simply not set the vaddr for relocatable objects. - set image->pi_entry = eh.e_entry as suggested by brett_gutste.in Thanks so much to Jessica for all the help in making hwpmc work correctly. This is mostly her work.