Change Details

The modified mtod() is shown in sys/mbuf.h. To see how it looks to C99 and C11 versions of GCC and Clang, here is a link to the godbolt tool: https://godbolt.org/z/Kjn2nZ Obviously, this requires changing a lot of C files. To do so safely and mechnically, a semantic patch using coccinelle is provided in "convert_mtod.cocci." The real patch would mechanically convert all files that reference the macro, but that does not seem especially useful to post on Phabricator. So instead I have converted a single file for example: netinet/ip_options.c. No hand-editing was performed. ========================== A real version of this would also: * Bump __FreeBSD_version * Update the manual page mtod is in

The real patch will mechanically convert all files that reference the macro, but that does not seem especially useful to post on Phabricator. So instead I have converted a single file for example: netinet/ip_options.c. No hand-editing was performed. ========================== TODO: * Bump __FreeBSD_version * Update the manual page mtod is in * Fix minor unused variable in cocci script

The modified mtod() is shown in sys/mbuf.h. To see how it looks to C99 and C11 versions of GCC and Clang, here is a link to the godbolt tool: https://godbolt.org/z/Kjn2nZ Obviously, this requires changing a lot of C files. To do so safely andreal patch will mechanically convert all files that reference the mechnically, a semantic patch using coccinelle is provided in "convert_mtod.cocci." The real patch would mechanically convert all files that reference the macro, but that does not seem especially useful to post on Phabricator. So instead I have converted a single file for example: netinet/ip_options.c. No hand-editing was performed. ========================== A real version of this would also:TODO: * Bump __FreeBSD_version * Update the manual page mtod is in * Fix minor unused variable in cocci script