Change Details

Calling memcpy() inside handle_signal() breaks TSan since the memcpy() call is intercepted by TSan and if this happens while another interceptor is being handled, the TSan runtime crashes. Avoid this by using a local memcpy() implementation that cannot be intercepted. Note: for Clang 11+ we could also use __builtin_memcpy_inline, but due to the large size of the ucontext_t structure this generates quite a lot of code for non-x86 (x86 uses a single single `rep;movsb (%rsi), %es:(%rdi)`).

Calling memcpy() inside handle_signal() breaks TSan since the memcpy() call is intercepted by TSan. If this happens while another interceptor is being handled, the TSan runtime crashes. Avoid this by using a local memcpy() implementation that cannot be intercepted. This also adds a local memset() implementation since otherwise TSan reports lots of false-positive races when multiple threads use thr_calloc (due to memset accessing the same data without a lock visible to TSan). Supersedes https://reviews.freebsd.org/D28531 Depends on D29536 (-Werror fixes) Depends on D29535 (-WWerror fixes)

Calling memcpy() inside handle_signal() breaks TSan since the memcpy() call is intercepted by TSan and if. If this happens while another interceptor is being handled, the TSan runtime crashes. Avoid this by using a local memcpy() implementation that cannot be intercepted. Note: for Clang 11+ we could also use __builtin_memcpy_inline, but due toThis also adds a local memset() implementation since otherwise TSan the large sizereports lots of the ucontext_t structure this generates quite a lot offalse-positive races when multiple threads use thr_calloc code for non-x86 (x86 uses a single single `rep;movsb (%rsi), %es:(%rdi)`).(due to memset accessing the same data without a lock visible to TSan). Supersedes https://reviews.freebsd.org/D28531 Depends on D29536 (-Werror fixes) Depends on D29535 (-WWerror fixes)