Change Details

amdgpu and iwlwifi already have >32 character firmware names. This is most easily noticeable in kldxref with 'Bad address' errors: ``` kldxref: error while reading /boot/kernel/amdgpu_green_sardine_dmcub_bin.ko: Bad address kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_dmcub_bin.ko: Bad address kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_mec2_bin.ko: Bad address kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_sdma_bin.ko: Bad address kldxref: error while reading /boot/kernel/iwlwifi-9000-pu-b0-jf-b0-46.ucode.ko: Bad address kldxref: error while reading /boot/kernel/iwlwifi-9260-th-b0-jf-b0-46.ucode.ko: Bad address ``` It's a bit weird to see "Bad address" but [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/usr.sbin/kldxref/ef_obj.c#L320-L321 | this overflow check ]] returns `EFAULT`; what's being overflown is [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/usr.sbin/kldxref/kldxref.c#L560 | an array of size MAXMODNAME + 1 ]]. In the kernel, it seems that the names just get [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/sys/kern/kern_module.c#L401-L402 | trimmed ]]. While the trimming is fine for now, in the future there might be an `amdgpu_supercalifragilistic_bigchungus` and all the firmwares with that prefix would collide. It's reasonable to *also* add the trimming behavior to kldxref and a warning print to the kernel (and to kldxref too?) but the size increase is really necessary.

With various firmware files used by graphics and wireless drivers we are exceeding the current 32 character module name (file path in kldxref) length. In order to overcome this issue bump it to the maximum path length for the next version. To be able to MFC provide backward compat support for another version of the struct as the offsets for the second half change due to the array size increase. MAXMODNAME being defined to MAXPATHLEN needs param.h to be included first. With only 7 modules (or LinuxKPI module.h) not doing that adjust them rather than including param.h in module.h [1]. Reported by: Greg V (greg unrelenting.technology) Sponsored by: The FreeBSD Foundation Suggested by: imp [1] MFC after: 10 days Differential Revision: https://reviews.freebsd.org/D32383

amdgpu and iwlwifi already have >32 character firmware names.With various firmware files used by graphics and wireless drivers This is most easily noticeable in kldxref with 'Bad address' errors: ```we are exceeding the current 32 character module name (file path in kldxref: error while reading /boot/kernel/amdgpu_green_sardine_dmcub_bin.ko: Bad address) length. kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_dmcub_bin.ko: Bad addressIn order to overcome this issue bump it to the maximum path length kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_mec2_bin.ko: Bad addressfor the next version. kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_sdma_bin.ko: Bad addressTo be able to MFC provide backward compat support for another version kldxref: error while reading /boot/kernel/iwlwifi-9000-pu-b0-jf-b0-46.ucode.ko: Bad addressof the struct as the offsets for the second half change due to the kldxref: error while reading /boot/kernel/iwlwifi-9260-th-b0-jf-b0-46.ucode.ko: Bad address ```array size increase. It's a bit weird to see "Bad address" but [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/usr.sbin/kldxref/ef_obj.c#L320-L321 | this overflow check ]] returns `EFAULT`; what's being overflown is [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/usr.sbin/kldxref/kldxref.c#L560 | an array of size MAXMODNAME + 1 ]]. In the kernel, it seems that the names just get [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/sys/kern/kern_module.c#L401-L402 | trimmed ]].MAXMODNAME being defined to MAXPATHLEN needs param.h to be While the trimming is fine for now, in the future there might be an `amdgpu_supercalifragilistic_bigchungus` and all the firmwares with that prefix would collideincluded first. With only 7 modules (or LinuxKPI module.h) not doing that adjust them rather than including param.h in module.h [1]. It's reasonable to *also* add the trimming behavior to kldxref and a warning print to the kernel (and to kldxref too?) but the size increase is really necessary. Reported by: Greg V (greg unrelenting.technology) Sponsored by: The FreeBSD Foundation Suggested by: imp [1] MFC after: 10 days Differential Revision: https://reviews.freebsd.org/D32383