Change Details

libgeom maintains a quasi-private mapping of /dev/devstat, which might grow over time if new devices appear. When the mapping needs to be expanded, it maps over the old region with MAP_FIXED, but there is no readily apparent reason for doing it this way. Moreover, it seems incorrect as it could trample over an existing mapping. Thus: - stop using MAP_FIXED, - don't creat a mapping in geom_stats_open(), as geom_stats_resync() will create it for us, - check for errors from munmap().

libgeom maintains a quasi-private mapping of /dev/devstat, which might grow over time if new devices appear. When the mapping needs to be expanded, the old mapping is passed as a hint, but this appears to be unnecessary. Thus: - stop passing a hint when remapping - don't create a mapping in geom_stats_open(), as geom_stats_resync() will create it for us, - check for errors from munmap().

libgeom maintains a quasi-private mapping of /dev/devstat, which might grow over time if new devices appear. When the mapping needs to be expanded, itthe maps over the old region with MAP_FIXED, but theremapping is no readily apparent reason for doing it this way. Moreoverpassed as a hint, it seems incorrect as it could trample over an existing mappingbut this appears to be unnecessary. Thus: - stop upassing MAP_FIXED,a hint when remapping - don't create a mapping in geom_stats_open(), as geom_stats_resync() will create it for us, - check for errors from munmap().