Change Details

When we terminate a vnet (i.e. jail) we move interfaces back to their home vnet. This may interfere with epair destruction because we do not protect V_ifnet at all. We could enter NET_EPOCH, but if_detach_internal() (called from if_vmove()) waits for net epoch callback completion. That's not possible from NET_EPOCH. Instead, we take the IFNET_WLOCK. That lock is taken again in if_vmove(), but as it's a recursive lock this is safe. This not only protects access to the V_ifnet list, but also ensures we don't end up trying to move epairs that are being destroyed. PR: 244703, 238870 MFC after: 2 weeks Sponsored by: Modirum MDPay

When we terminate a vnet (i.e. jail) we move interfaces back to their home vnet. We need to protect our access to the V_ifnet CK_LIST. We could enter NET_EPOCH, but if_detach_internal() (called from if_vmove()) waits for net epoch callback completion. That's not possible from NET_EPOCH. Instead, we take the IFNET_WLOCK, build a list of the interfaces that need to move and, once we've released the lock, move them back to their home vnet. We cannot hold the IFNET_WLOCK() during if_vmove(), because that results in a LOR between ifnet_sx, in_multi_sx and iflib ctx lock. Separate out moving the ifp into or out of V_ifnet, so we can hold the lock as we do the list manipulation, but do not hold it as we if_vmove(). MFC after: 2 weeks Sponsored by: Modirum MDPay

When we terminate a vnet (i.e. jail) we move interfaces back to their home vnet. This may interfere with epair destruction because we do not protectWe need to protect our access to the V_ifnet at allCK_LIST. We could enter NET_EPOCH, but if_detach_internal() (called from if_vmove()) waits for net epoch callback completion. That's not possible from NET_EPOCH. Instead, we take the IFNET_WLOCK., That lock is takenbuild a list of the again in if_vinterfaces that need to move() and, but as it's a recursive lock this is safe.once we've released the lock, This notmove only protects access tothem back to their home vnet. We cannot hold the V_ifnet listIFNET_WLOCK() during if_vmove(), but also ensures we don't endbecause that results up trying to move epairs that are being destroyedin a LOR between ifnet_sx, in_multi_sx and iflib ctx lock. PR: 244703Separate out moving the ifp into or out of V_ifnet, 238870so we can hold the MFC after: 2 weekslock as we do the list manipulation, but do not hold it as we if_vmove(). MFC after: 2 weeks Sponsored by: Modirum MDPay