Change Details

Move state->kif logic to pf_create_state, ensure that r->rpool->cur is not accessed directly.

The redirection pool stored in `r->rpool.cur` is used for loadbalancing and `cur` can change whenever loadbalancing happens, which is for every new connection. Therefore it can't be trusted outside of `pf_map_addr()` and the `r->rpool->mtx` mutex. After evaluating the ruleset, loadbalancing decission is made in `pf_map_addr()` called from within `pf_create_state()` and stored in the state itself. This patch modifies `BOUND_IFACE()` so that it only uses the information already stored in the state which has been obtained by respecting the `r->rpool->mtx` mutex.

Move state->kif logic to pf_create_stateThe redirection pool stored in `r->rpool.cur` is used for loadbalancing and `cur` can change whenever loadbalancing happens, which is for every new connection. Therefore it can't be trusted outside of `pf_map_addr()` and the `r->rpool->mtx` mutex. After evaluating the ruleset, ensure that r->rpool->cur is not accessed directlyloadbalancing decission is made in `pf_map_addr()` called from within `pf_create_state()` and stored in the state itself. This patch modifies `BOUND_IFACE()` so that it only uses the information already stored in the state which has been obtained by respecting the `r->rpool->mtx` mutex.