Change Details

This change reduces the size of iommu_gas.o by 48 bytes. On a test code ({F47254409}) compiled with -O2 -DPLAIN that repeatedly inserts and removes nodes from a tree keeping it as close as possible to 32k in size, this change improves performance on 4 of 5 machines tested: ``` x plain.lip1.res + plain.lip1.new.res +-------------------------------------------------------------------------------------+ | + xx | | ++ xx | | + ++ xxxxx | |++ +++ + + xxxxx | |+++++++ + + + + xxxxxx x| | |___MA___| |_A_| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 69.748549 70.051546 69.824668 69.836802 0.07465928 + 24 66.338499 67.213256 66.570199 66.58625 0.19325032 Difference at 95.0% confidence -3.25055 +/- 0.0851268 -4.6545% +/- 0.121894% (Student's t, pooled s = 0.146492) x plain.lip2.res + plain.lip2.new.res +-------------------------------------------------------------------------------------+ | + x | | ++ x | | ++ x | | ++ xx | | +++ xxx | | +++ xxx | | +++ xxx | | +++ xxxx | |+++++ xxxxxx| | |A| |A| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 76.020217 76.486612 76.174439 76.194297 0.12094221 + 24 68.195964 68.63567 68.418908 68.413376 0.10211452 Difference at 95.0% confidence -7.78092 +/- 0.0650399 -10.2119% +/- 0.0853606% (Student's t, pooled s = 0.111925) x plain.lip3.res + plain.lip3.new.res +-------------------------------------------------------------------------------------+ | + x | | +++ x x x x | |+ +++ + + xx x x x x | |+ ++++ ++ + +++ +++ xxxxxx xx x x xx| | |____M___A________| |____M__A_______| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 41.298008 42.148018 41.486214 41.591602 0.28646009 + 24 39.026303 40.218466 39.51874 39.64809 0.33600281 Difference at 95.0% confidence -1.94351 +/- 0.181429 -4.67285% +/- 0.436217% (Student's t, pooled s = 0.312216) x plain.lip4.res + plain.lip4.new.res +-------------------------------------------------------------------------------------+ |++ x | |++ x | |++ xx | |++ xx | |++ xx | |++ xx | |++ xx | |++ xx | |++ xx | |++ xx | |++ xxx| |++ xxx| ||A |A | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 63.073985 63.237333 63.127556 63.134412 0.041624923 + 24 56.700027 56.81675 56.740303 56.742484 0.030355262 Difference at 95.0% confidence -6.39193 +/- 0.0211687 -10.1243% +/- 0.0335296% (Student's t, pooled s = 0.0364285) x plain.lip5.res + plain.lip5.new.res +-------------------------------------------------------------------------------------+ | x + | | x + | | x + | | xx ++| | xx ++| | xx ++| | xx ++| | xx ++| | xx ++| | xx ++| | xx ++| | xx ++| |xxx +++| | A| A|| +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 84.044938 84.156457 84.119338 84.117232 0.026102463 + 24 88.557503 88.647588 88.616434 88.611203 0.02483168 Difference at 95.0% confidence 4.49397 +/- 0.0148036 5.34251% +/- 0.0175988% (Student's t, pooled s = 0.025475) ```

This change reduces the size of iommu_gas.o by 48 bytes. On a test code ({F47254409}) compiled with -O2 -DPLAIN that repeatedly inserts and removes nodes from a tree keeping it as close as possible to 32k in size, this change improves performance on 4 of 5 machines tested: ``` x plain.lip1.res + plain.lip1.new.res +-------------------------------------------------------------------------------------+ | + | | + | | ++ xxx | | ++ + xxxx | |+++++ + xxxxxx | |+++++++++++ xxxxxxxxx x x| | |__A__| |__MA__| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 69.555135 70.258062 69.75464 69.777408 0.1579122 + 24 66.286562 66.743278 66.457209 66.488963 0.13198151 Difference at 95.0% confidence -3.28844 +/- 0.0845654 -4.71276% +/- 0.121193% (Student's t, pooled s = 0.145526) x plain.lip2.res + plain.lip2.new.res +-------------------------------------------------------------------------------------+ | ++ | | ++ | | ++ x | | ++ xxx | | ++ xxx | | ++ xxxx | | ++ xxxx | | ++++ xxxx | |++++++ xxxx x| | |A| |A| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 73.971392 74.419757 74.126437 74.123822 0.11015063 + 24 66.351963 66.79616 66.526073 66.527292 0.1106494 Difference at 95.0% confidence -7.59653 +/- 0.0641539 -10.2484% +/- 0.0865497% (Student's t, pooled s = 0.1104) x plain.lip3.res + plain.lip3.new.res +-------------------------------------------------------------------------------------+ | + | | ++ | | ++ + x | | + +++ + x x x xx | |+ + +++++++ ++ + + x x x x xxxxxxxx x x xx x x| | |___M_A_____| |_______MA________| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 40.559234 42.046492 41.295055 41.33403 0.43762768 + 24 38.005898 39.138651 38.471001 38.569402 0.28571529 Difference at 95.0% confidence -2.76463 +/- 0.214753 -6.6885% +/- 0.519556% (Student's t, pooled s = 0.369561) x plain.lip4.res + plain.lip4.new.res +-------------------------------------------------------------------------------------+ | + x | | + x | | + x | | + x | | + x | |++ x | |++ x | |++ xx | |+++ xx | |+++ xxx | |+++ xxx | |++++ xxxx| ||A| A| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 61.300374 61.50657 61.3641 61.373103 0.052427644 + 24 55.100894 55.316134 55.161839 55.174412 0.056165408 Difference at 95.0% confidence -6.19869 +/- 0.0315706 -10.1% +/- 0.0514404% (Student's t, pooled s = 0.0543287) x plain.lip5.res + plain.lip5.new.res +-------------------------------------------------------------------------------------+ | x + | | x + | | x + | | x + | | x + | | x + | | x + | | x + | | x + | | x ++| |xx ++| |xx +++| |xxx +++| |xxx +++| ||A |A|| +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 22 83.027081 83.128148 83.082776 83.079594 0.024554289 + 22 87.782023 87.901107 87.834571 87.841198 0.033430836 Difference at 95.0% confidence 4.7616 +/- 0.017846 5.73138% +/- 0.0214806% (Student's t, pooled s = 0.0293303) ```

This change reduces the size of iommu_gas.o by 48 bytes. On a test code ({F47254409}) compiled with -O2 -DPLAIN that repeatedly inserts and removes nodes from a tree keeping it as close as possible to 32k in size, this change improves performance on 4 of 5 machines tested: ``` x plain.lip1.res + plain.lip1.new.res +-------------------------------------------------------------------------------------+ | ++ xx | | +++ xx | | +| ++ xxxxxxxx | |++ +++ +| ++ + xxxxxxxxx | |+++++++ + + + + xxxxxxx x| | | |___MA___||+++++++++++ |_A_| |xxxxxxxxx x x| | |__A__| |__MA__| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 69.748549555135 70.051546258062 69.82466875464 69.836802777408 0.074659281579122 + 24 66.338499286562 67.2132566.743278 66.570199 457209 66.58625488963 0.193250323198151 Difference at 95.0% confidence -3.2505528844 +/- 0.085126845654 -4.654571276% +/- 0.121894%193% (Student's t, pooled s = 0.146492145526) x plain.lip2.res + plain.lip2.new.res +-------------------------------------------------------------------------------------+ | | ++ x | | ++| ++ x | | | ++ x | x | | ++| ++ xx |x | | +++ xxx | | +++ xxxx | | +++ xxxx | | +++ + xxxx | |+++++ + xxxxxx| x| | |A| |A| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 76.0202173.971392 76.4866124.419757 76.1744394.126437 76.1942974.123822 0.120942211015063 + 24 68.1959646.351963 68.635676.79616 68.4189086.526073 68.4133766.527292 0.10211452106494 Difference at 95.0% confidence -7.7809259653 +/- 0.065039941539 -10.21192484% +/- 0.0853606%65497% (Student's t, pooled s = 0.1119251104) x plain.lip3.res + plain.lip3.new.res +-------------------------------------------------------------------------------------+ | ++ x | | +++++ x x x x | |+ | +++ +++ + + xx x x x xx | |+ | ++ +++ ++ + +++ +++ + x xxxxxx xx x x x xx| | | |+ |____M___A________|+ +++++++ ++ + + |____M__A_______| |x x x x xxxxxxxx x x xx x x| | |___M_A_____| |_______MA________| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 41.2980080.559234 42.148018046492 41.486214295055 41.59160233403 0.2864600943762768 + 24 39.0263038.005898 40.218466 39.138651 39.51874 8.471001 39.648098.569402 0.3360028128571529 Difference at 95.0% confidence -1.94351-2.76463 +/- 0.181429214753 -4.672-6.6885% +/- 0.436217%519556% (Student's t, pooled s = 0.312216369561) x plain.lip4.res + plain.lip4.new.res +-------------------------------------------------------------------------------------+ |+| + x |x | |+| + x |x | |+| + xx | | |+| + xx | | |+| + xx | | |++ xx | | |++ xx | | |++ xx | |++ |+++ xx | |++ |+++ xxx | |++ |+++ xxx|xxx | |++ |++++ xxxx| ||A ||A| |A |A| | +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 24 63.0739851.300374 63.2373331.50657 63.127556 61.3641 63.1344121.373103 0.04162492352427644 + 24 56.700027 5.100894 56.816755.316134 56.7403035.161839 56.7424845.174412 0.03035526256165408 Difference at 95.0% confidence -6.3919319869 +/- 0.0211687315706 -10.12431% +/- 0.0335296%514404% (Student's t, pooled s = 0.03642850543287) x plain.lip5.res + plain.lip5.new.res +-------------------------------------------------------------------------------------+ | x + | | x + | | x + | | xx| x ++| | | xx| x ++| | | xx| x ++| | | xx| x ++| | | xx| x ++| | | xx| x ++| | | xx| x ++| | xx|xx ++| | |xx ++|+++| |xxx +++| | A||xxx A||+++| ||A |A|| +-------------------------------------------------------------------------------------+ N Min Max Median Avg Stddev x 242 84.0449383.027081 84.1564573.128148 84.1193383.082776 84.1172323.079594 0.0261024634554289 + 242 88.557507.782023 88.6475887.901107 88.6164347.834571 88.611203 7.841198 0.0248316833430836 Difference at 95.0% confidence 4.493977616 +/- 0.01480367846 5.3425173138% +/- 0.0175988%214806% (Student's t, pooled s = 0.0254750293303) ```