Change Details

amdgpu and iwlwifi already have >32 character firmwares. This is most easily noticeable in kldxref with 'Bad address' errors, in kernel the names would just get trimmed. While the trimming is fine for now, it's possible that in the future we might even see firmwares with 32-character common prefixes.

amdgpu and iwlwifi already have >32 character firmware names. This is most easily noticeable in kldxref with 'Bad address' errors: ``` kldxref: error while reading /boot/kernel/amdgpu_green_sardine_dmcub_bin.ko: Bad address kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_dmcub_bin.ko: Bad address kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_mec2_bin.ko: Bad address kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_sdma_bin.ko: Bad address kldxref: error while reading /boot/kernel/iwlwifi-9000-pu-b0-jf-b0-46.ucode.ko: Bad address kldxref: error while reading /boot/kernel/iwlwifi-9260-th-b0-jf-b0-46.ucode.ko: Bad address ``` It's a bit weird to see "Bad address" but [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/usr.sbin/kldxref/ef_obj.c#L320-L321 | this overflow check ]] returns `EFAULT`; what's being overflown is [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/usr.sbin/kldxref/kldxref.c#L560 | an array of size MAXMODNAME + 1 ]]. In the kernel, it seems that the names just get [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/sys/kern/kern_module.c#L401-L402 | trimmed ]]. While the trimming is fine for now, in the future there might be an `amdgpu_supercalifragilistic_bigchungus` and all the firmwares with that prefix would collide. It's reasonable to *also* add the trimming behavior to kldxref and a warning print to the kernel (and to kldxref too?) but the size increase is really necessary.

amdgpu and iwlwifi already have >32 character firmware names. This is most easily noticeable in kldxref with 'Bad address' errors,: ``` in kernel the names would just get trimmed.kldxref: error while reading /boot/kernel/amdgpu_green_sardine_dmcub_bin.ko: Bad address While the trimmkldxref: error while reading is fine for now, it's possible that in the future/boot/kernel/amdgpu_sienna_cichlid_dmcub_bin.ko: Bad address we might even see firmwares with 32-character common prefixeskldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_mec2_bin.ko: Bad address kldxref: error while reading /boot/kernel/amdgpu_sienna_cichlid_sdma_bin.ko: Bad address kldxref: error while reading /boot/kernel/iwlwifi-9000-pu-b0-jf-b0-46.ucode.ko: Bad address kldxref: error while reading /boot/kernel/iwlwifi-9260-th-b0-jf-b0-46.ucode.ko: Bad address ``` It's a bit weird to see "Bad address" but [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/usr.sbin/kldxref/ef_obj.c#L320-L321 | this overflow check ]] returns `EFAULT`; what's being overflown is [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/usr.sbin/kldxref/kldxref.c#L560 | an array of size MAXMODNAME + 1 ]]. In the kernel, it seems that the names just get [[ https://github.com/freebsd/freebsd-src/blob/1c64959bff1772da4c9cc7d86c56f3729189b88e/sys/kern/kern_module.c#L401-L402 | trimmed ]]. While the trimming is fine for now, in the future there might be an `amdgpu_supercalifragilistic_bigchungus` and all the firmwares with that prefix would collide. It's reasonable to *also* add the trimming behavior to kldxref and a warning print to the kernel (and to kldxref too?) but the size increase is really necessary.