Change Details

This commit contains the following changes: * moves the "finalconfig" step into a dedicated script * adds a "Finish" button to replace the first choice (exit and apply) * uses a loop instead of recursing into itself Sponsored by: The FreeBSD Foundation I would also like to mention that if this step is not skipped (e.g., with $BSDINSTALL_SKIP_FINALCONFIG), some other steps can be skipped by default (like "adduser", "hardening", "services", and perhaps "time") since this menu gives a chance to perform them. This is also relevant to D40142. I also wish the manual configuration step could be merged into this (i.e., chrooting a shell into the newly installed system), but this conflicts with the current design of bsdinstall, which relies on a set of temporary configuration files before creating the final ones.

This commit contains the following changes: * moves the "finalconfig" step into a dedicated script * adds a "Finish" button to replace the first choice (exit and apply) * uses a loop instead of recursing into itself Sponsored by: The FreeBSD Foundation I would also like to mention that if this step is not skipped (e.g., with $BSDINSTALL_SKIP_FINALCONFIG), some other steps can be skipped by default (like "adduser", "hardening", "services", and perhaps "time") since this menu gives a chance to perform them. This is also relevant to D40142. I also wish the manual configuration step could be merged into this (i.e., chrooting a shell into the newly installed system), but this conflicts with the current design of bsdinstall, which relies on a set of temporary configuration files before creating the final ones.

This commit contains the following changes: * moves the "finalconfig" step into a dedicated script * adds a "Finish" button to replace the first choice (exit and apply) * uses a loop instead of recursing into itself Sponsored by: The FreeBSD Foundation I would also like to mention that if this step is not skipped (e.g., with $BSDINSTALL_SKIP_FINALCONFIG), some other steps can be skipped by by default (like "adduser", "hardening", "services", and perhaps "time") since this menu gives a chance to perform them. This is also relevant to D40142. I also wish the manual configuration step could be merged into this (i (i.e., chrooting a shell into the newly installed system), but this conflicts with the current design of bsdinstall, which relies on a set set of temporary configuration files before creating the final ones.