Change Details

Fix vfs_emptydir(). It would consider directories containing directories with name of the form 'X.' (X being any authorized byte) as empty. Also, it would cause VOP_READDIR() to return an error on directories containing enough whiteouts. While here, use a more decently sized buffer as done elsewhere. Remove ad-hoc iteration on the directory's content and instead use the newly exported vfs_next_dirent() function (this is what fixes the second problem mentioned above).

Simplify the old interface (one less argument, simpler termination test) and add documentation about it. Add more sanity checks (mostly under INVARIANTS, but also in the general case to prevent infinite loops). Drop the explicit test on minimum directory entry size (without INVARIANTS). Deal with the impacts in callers (dirent_exists() and vop_stdvptocnp()). dirent_exists() has been simplified a bit but preserves the exact same semantics, even if the return code has been reversed (0 now means the entry exists, ENOENT that it doesn't and other values are genuine errors). Export new _GENERIC_MINDIRSIZ and _GENERIC_MAXDIRSIZ on __BSD_VISIBLE, and GENERIC_MINDIRSIZ and GENERIC_MAXDIRSIZ on _KERNEL.

Fix vfs_emptydir().Simplify the old interface (one less argument, It would consider directories containing directories withsimpler termination test) and name of the form 'X.' (X being any authorized byte) as empty. Also,add documentation about it. it wouldAdd more sanity checks (mostly under INVARIANTS, cause VOP_READDIR()but also in the general case to return an error on directories containing enoughprevent infinite loops). Drop the explicit test whiteouts. While here, use a more decentlon minimum directory entry sized buffer as done elsewhere (without INVARIANTS). Remove ad-hoc iteration on the Deal with the impacts in callers (directory's contentnt_exists() and instead use the newlyvop_stdvptocnp()). exported vfs_next_dirent() function (this is what fixdirent_exists() has been simplified a bit but preserves the second problemexact same mentioned above)semantics, even if the return code has been reversed (0 now means the entry exists, ENOENT that it doesn't and other values are genuine errors). Export new _GENERIC_MINDIRSIZ and _GENERIC_MAXDIRSIZ on __BSD_VISIBLE, and GENERIC_MINDIRSIZ and GENERIC_MAXDIRSIZ on _KERNEL.