Change Details

The calls to disable_intr() / enable_intr() in spkr.c were leftover from previous refactorings and unnecessary for correctness, so this PR removes them. My detailed analysis of why this change is correct can be found here: {F139323851} The main related commit referenced in the analysis is this 2008 change by phk: e465985 - where a mutex was added to clock.c and the disable_intr/enable_intr pair could have been removed, but wasn't. Motivation: I am a fervent spkr(4) user and would like it to persist beyond FreeBSD 16, so we needed to do something about its use of the GIANT mutex.

NB: I also uploaded this change to github https://github.com/freebsd/freebsd-src/pull/1922 because I wasn't sure which one is being used more these days. The calls to disable_intr() / enable_intr() in spkr.c were leftover from previous refactorings and unnecessary for correctness, so this PR removes them. My detailed analysis of why this change is correct can be found here: {F139323851} The main related commit referenced in the analysis is this 2008 change by phk: e465985 - where a mutex was added to clock.c and the disable_intr/enable_intr pair could have been removed, but wasn't. Motivation: I am a fervent spkr(4) user and would like it to persist beyond FreeBSD 16, so we needed to do something about its use of the GIANT mutex.

NB: I also uploaded this change to github https://github.com/freebsd/freebsd-src/pull/1922 because I wasn't sure which one is being used more these days. The calls to disable_intr() / enable_intr() in spkr.c were leftover from previous refactorings and unnecessary for correctness, so this PR removes them. My detailed analysis of why this change is correct can be found here: {F139323851} The main related commit referenced in the analysis is this 2008 change by phk: e465985 - where a mutex was added to clock.c and the disable_intr/enable_intr pair could have been removed, but wasn't. Motivation: I am a fervent spkr(4) user and would like it to persist beyond FreeBSD 16, so we needed to do something about its use of the GIANT mutex.