Change Details

Rather than naming the syscall implementation sys_sys_exit and declaring it to return void (it doesn't return), name it sys_exit() and declare it to return int. Because exit1() is marked __dead2, clang and gcc are both fine with this change. This syscall should be _exit(), but that would cause the SYS_exit definition to be lost and it is widely used in the base system.

Rather than naming the syscall implementation sys_sys_exit and declaring it to return void (it doesn't return), name it sys_exit() and declare it to return int. Because exit1() is marked __dead2, clang and gcc are both fine with this change. This syscall should be _exit(), but that would cause the SYS_exit definition to be lost and it is widely used in the base system. This effectively reverts r63986 and r64001 which were obsoleted by r225617.

Rather than naming the syscall implementation sys_sys_exit and declaring it to return void (it doesn't return), name it sys_exit() and declare it to return int. Because exit1() is marked __dead2, clang and gcc are both fine with this change. This syscall should be _exit(), but that would cause the SYS_exit definition to be lost and it is widely used in the base system. This effectively reverts r63986 and r64001 which were obsoleted by r225617.