NOTE: This is a bugfix to correct broken behaviour, not a new idea or feature.
In r522484[0] a new warning has been introduced to check if
REINPLACE_CMD had any effect. This is accomplished by
calling a script called sed_checked.sh and is only done
in DEVELOPER mode and only if REINPLACE_CMD hasn't been
defined.
Unfortunately, sed_checked.sh assumes that REINPLACE_ARGS
is `-i.bak`. If it isn't (e.g., `-i ""`), the working
directory will contain *.bak files while in DEVELOPER mode,
while containing whatever was defined in REINPLACE_ARGS
(no backup files in case of `-i ""`) when not being in
DEVELOPER mode.
This impacts commands like `make makeplist` and isn't
detected while running in DEVELOPER mode (which includes
running `poudriere testport`), but will fail outside of
it, e.g., when running `poudriere bulk`.
This patch fixes this by simply not calling sed_checked.sh
in case REINPLACE_ARGS isn't set to the default "-i.bak".
This seemed to be the most straightforward way to correct this,
I also had other ideas like altering sed_checked.sh to
always use a custom extension like .sedchecked and clean
up after itself).
See also:
https://lists.freebsd.org/pipermail/freebsd-ports/2021-January/119978.html
[0] https://reviews.freebsd.org/D22174