Change Details

We already checked in `create`, let's do this in `rename` as well. I suspect spaces aren't the only problematic character, but for now let's aim to just make them consistent. While we're here: `rename` always succeeds, even when it doesn't. Start returning the error. Reported By: Christian McDonald <cmcdonald netgate com>

bectl: push space-in-name check down into libbe This check was previously in `create` only, not applying to renames. It should really be applied at the libbe level, so that we can avoid writing about this restriction over and over again. While we're here: `bectl rename` always succeeds, even when it doesn't. Start returning the error. Reported By: Christian McDonald <cmcdonald netgate com> Differential Revision: https://reviews.freebsd.org/D34605

We already checked in `create`, let's do this in `rename` as well. I bectl: push space-in-name check down into libbe suspect spaces aren't the only problematic character This check was previously in `create` only, but for now let'snot applying to renames. It aim to just make them consistent. While we're here: `rename` always succeeds should really be applied at the libbe level, even when it doesn't. Startso that we can avoid returning the error. Reported By: writing about this restriction over and over again. While we're here: `bectl rename` always succeeds, even when it doesn't. Start returning the error. Reported By: Christian McDonald <cmcdonald netgate com> Differential Revision: https://reviews.freebsd.org/D34605