Change Details

This function is to be called only when initializing a new process. Check that 'p_ucred' is indeed NULL before crushing it.

This function is to be called only when initializing a new process (so, 'proc0' and at fork), and not in any other circumstances. Setting the process' 'p_ucred' field to the result of crcowget() on the original credentials is the only thing it does, hiding the fact that the process' 'p_ucred' field is crushed by the call. Moreover, most of the code it executes is already encapsulated in crcowget(). To prevent misuse and improve code readability, just remove this function and replace it with a direct assignment to 'p_ucred'. MFC after: 1 week Sponsored by: The FreeBSD Foundation

This function is to be called only when initializing a new process. (so, Check that 'p_ucred' is indeed NULL before crushing it.'proc0' and at fork), and not in any other circumstances. Setting the process' 'p_ucred' field to the result of crcowget() on the original credentials is the only thing it does, hiding the fact that the process' 'p_ucred' field is crushed by the call. Moreover, most of the code it executes is already encapsulated in crcowget(). To prevent misuse and improve code readability, just remove this function and replace it with a direct assignment to 'p_ucred'. MFC after: 1 week Sponsored by: The FreeBSD Foundation