Change Details

GCC 12 noticed that the calls to free() were using an offset and emitted a warning. The compiler wasn't able to factor in the earlier -- adjustment (which is UB, but fine in practice). To be less confusing to compilers (and possibly humans) store the pointers returned from calloc() in local variables and pass those to free() on an error.

XHCI port and slot numbers are 1-based rather than 0-based. To handle this, bhyve was subtracting one item from the pointers saved in the softc so that index 1 accessed index 0 of the allocated array. However, this is UB and confused GCC 12. The compiler noticed that the calls to free() were using an offset and emitted a warning. Rather than storing UB pointers in the softc, push the decrement operation into the existing macros that wrap accesses to the relevant arrays.

GCC 12 noticed that the calls to free() were using an offset andXHCI port and slot numbers are 1-based rather than 0-based. To handle emitted a warning. The compiler wasn't able to factorthis, bhyve was subtracting one item from the pointers saved in the earliere -- adjustment (which is UBsoftc so that index 1 accessed index 0 of the allocated array. However, but fine in practice)this is UB and confused GCC 12. To be lessThe compiler noticed that confusingthe calls to compilers (and possibly humans) store the pointersfree() were using an offset and emitted a warning. returned from calloc() in local variables and pass those to free() onRather than storing UB pointers in the softc, push the decrement an erroroperation into the existing macros that wrap accesses to the relevant arrays.