Change Details

For head/, this will remain internally default-on to maintain the status quo. For stable/ branches, it should be flipped to default-off to maintain the status quo. There's value in being able to flip it one way or the other easily on head or stable branches, whether you want to gain some performance back on head/ (for machines there's little chance you'll actually hit an assertion) or potentially diagnose a problem with the version of llvm on an older branch. This would push re@'s post-branch commit from removing the comment marker in lib/clang/llvm.build.mk to flipping the option to __DEFAULT_NO_OPTIONS -- it's unclear if this is acceptable.

For head/, this will remain eternally default-on to maintain the status quo. For stable/ branches, it should be flipped to default-off to maintain the status quo. There's value in being able to flip it one way or the other easily on head or stable branches, whether you want to gain some performance back on head/ (for machines there's little chance you'll actually hit an assertion) or potentially diagnose a problem with the version of llvm on an older branch. This would push re@'s post-branch commit from removing the comment marker in lib/clang/llvm.build.mk to flipping the option to __DEFAULT_NO_OPTIONS -- it's unclear if this is acceptable.

For head/, this will remain ineternally default-on to maintain the status quo. For stable/ branches, it should be flipped to default-off to maintain the status quo. There's value in being able to flip it one way or the other easily on head or stable branches, whether you want to gain some performance back on head/ (for machines there's little chance you'll actually hit an assertion) or potentially diagnose a problem with the version of llvm on an older branch. This would push re@'s post-branch commit from removing the comment marker in lib/clang/llvm.build.mk to flipping the option to __DEFAULT_NO_OPTIONS -- it's unclear if this is acceptable.