Change Details

While building ports in a poudriere jail defining WITH_DEBUG I had the need to disable debug for specific ports failing to build due to requiring too much RAM for debugging build (llvm, for example). I discovered that most ports who check for WITH_DEBUG are ignoring WITHOUT_DEBUG. in bsd.port.mk the line: .if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) clearly shows that WITHOUT_DEBUG should override WITH_DEBUG if both are defined, so ports should abide by this. I tried to catch all instances and created a diff fixing this. I'd like to commit it soonish, before it gets rotten.

While building ports in a poudriere jail defining WITH_DEBUG I had the need to disable debug for specific ports failing to build due to requiring too much RAM for debugging build (llvm, for example). I discovered that most ports who check for WITH_DEBUG are ignoring WITHOUT_DEBUG. Also, the same intended effect of the WITHOUT_DEBUG flag can be obtained by using ".undef WITH_DEBUG" without requiring port Makefiles to have any special support. I'm updating the patch in this review with one to completely remove WITHOUT_DEBUG from the ports tree. I'm also adding an UPDATING note to let users have at least some notice.

While building ports in a poudriere jail defining WITH_DEBUG I had the need to disable debug for specific ports failing to build due to requiring too much RAM for debugging build (llvm, for example). I discovered that most ports who check for WITH_DEBUG are ignoring WITHOUT_DEBUG. in bsd.port.mk the line:Also, the same intended effect of the WITHOUT_DEBUG flag can be obtained by using ".undef WITH_DEBUG" without requiring port Makefiles to have any special support. .if defined(WITH_DEBUG) && !defined(I'm updating the patch in this review with one to completely remove WITHOUT_DEBUG) from the ports tree. clearly shows that WITHOUT_DEBUG should override WITH_DEBUG if both are defined, so ports should abide by this. I tried to catch all instances and created a diff fixing this. I'd like to commit it soonish, before it gets rotten. I'm also adding an UPDATING note to let users have at least some notice.