Change Details

XXX: This is almost certainly wrong. It seems that the value of new_status should be reported somewhere (e.g. as the value returned to whoever requested this operation) and that the code is incomplete.

The result of the request computed in new_status was never returned to the caller leaving new_status as a set-but-unused variable. Removing new_status leaves sc->previous_status as a write-only variable. Removing sc->previous_status leaves current_status as a write-only variable, so it collapses down to removing the entire USB_ST_TRANSFERRED case. Arguably, all of the support for UHID_SNES_STATUS_DT_RD should be removed as it doesn't return anything to the caller. If the request should be fixed instead then this commit should be reverted and new_status should be returned to whoever submitted the request.

XXX: This is almost certainly wrong. It seems that the value ofThe result of the request computed in new_status was never returned to new_status should be reported somewhere (e.g. as the value returned tothe caller leaving new_status as a set-but-unused variable. Removing whoever requested this operation) and that the code is incompletenew_status leaves sc->previous_status as a write-only variable. Removing sc->previous_status leaves current_status as a write-only variable, so it collapses down to removing the entire USB_ST_TRANSFERRED case. Arguably, all of the support for UHID_SNES_STATUS_DT_RD should be removed as it doesn't return anything to the caller. If the request should be fixed instead then this commit should be reverted and new_status should be returned to whoever submitted the request.