Change Details

In DTrace, we require that we never reenter dtrace_probe() due to ordering constraints and avoiding recursion. On DTrace aarch64, namely when stack() was called, dtrace_getpcstack() would get called, which calls unwind_frame() from sys/amd64/amd64/unwind.c. It is because this function is quite short that it was inlined and therefore never instrumented by fbt, however, in the future a patch that enabled instrumentation of inlined functions could accidentally break DTrace on aarch64. This patch addresses the issue by manually inlining the unwind_frame() function in dtrace_getpcstack().

In DTrace, we require that we never reenter dtrace_probe() due to ordering constraints and avoiding recursion. On DTrace aarch64, namely when stack() was called, dtrace_getpcstack() would get called, which calls unwind_frame() from sys/arm64/arm64/unwind.c. It is because this function is quite short that it was inlined and therefore never instrumented by fbt, however, in the future a patch that enabled instrumentation of inlined functions could accidentally break DTrace on aarch64. This patch addresses the issue by manually inlining the unwind_frame() function in dtrace_getpcstack().

In DTrace, we require that we never reenter dtrace_probe() due to ordering constraints and avoiding recursion. On DTrace aarch64, namely when stack() was called, dtrace_getpcstack() would get called, which calls unwind_frame() from sys/amdrm64/amdrm64/unwind.c. It is because this function is quite short that it was inlined and therefore never instrumented by fbt, however, in the future a patch that enabled instrumentation of inlined functions could accidentally break DTrace on aarch64. This patch addresses the issue by manually inlining the unwind_frame() function in dtrace_getpcstack().