Index: projects/zfsd/head/tests/sys/cddl/zfs/tests/hotspare/hotspare_add_003_neg.ksh =================================================================== --- projects/zfsd/head/tests/sys/cddl/zfs/tests/hotspare/hotspare_add_003_neg.ksh (revision 329040) +++ projects/zfsd/head/tests/sys/cddl/zfs/tests/hotspare/hotspare_add_003_neg.ksh (revision 329041) @@ -1,146 +1,142 @@ #!/usr/local/bin/ksh93 -p # # CDDL HEADER START # # The contents of this file are subject to the terms of the # Common Development and Distribution License (the "License"). # You may not use this file except in compliance with the License. # # You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE # or http://www.opensolaris.org/os/licensing. # See the License for the specific language governing permissions # and limitations under the License. # # When distributing Covered Code, include this CDDL HEADER in each # file and include the License file at usr/src/OPENSOLARIS.LICENSE. # If applicable, add the following below this CDDL HEADER, with the # fields enclosed by brackets "[]" replaced with your own identifying # information: Portions Copyright [yyyy] [name of copyright owner] # # CDDL HEADER END # # # Copyright 2009 Sun Microsystems, Inc. All rights reserved. # Use is subject to license terms. # # ident "@(#)hotspare_add_003_neg.ksh 1.7 09/06/22 SMI" # . $STF_SUITE/tests/hotspare/hotspare.kshlib ################################################################################ # # __stc_assertion_start # # ID: hotspare_add_003_neg # # DESCRIPTION: # 'zpool add' with hot spares will fail # while the hot spares belong to the following cases: # - nonexist device, # - part of an active pool, # - currently mounted, # - devices in /etc/vfstab, # - specified as the dedicated dump device, # - identical with the basic or spares vdev within the pool, # - belong to a exported or potentially active ZFS pool, # - a volume device that belong to the given pool, # # STRATEGY: # 1. Create case scenarios # 2. For each scenario, try to add [-f] the device to the pool # 3. Verify the add operation failes as expected. # # TESTABILITY: explicit # # TEST_AUTOMATION_LEVEL: automated # # CODING_STATUS: COMPLETED (2006-06-07) # # __stc_assertion_end # ############################################################################### verify_runnable "global" function cleanup { poolexists "$TESTPOOL" && \ destroy_pool "$TESTPOOL" poolexists "$TESTPOOL1" && \ destroy_pool "$TESTPOOL1" if [[ -n $saved_dump_dev ]]; then if [[ -n $DUMPADM ]]; then log_must $DUMPADM -u -d $saved_dump_dev fi fi if [[ -n $DUMPADM ]]; then cleanup_devices $dump_dev fi partition_cleanup } -if ! $(is_physical_device $DISKS) ; then - log_unsupported "This directory cannot be run on raw files." -fi - log_assert "'zpool add [-f]' with hot spares should fail with inapplicable scenarios." log_onexit cleanup set_devs mnttab_dev=$(find_mnttab_dev) vfstab_dev=$(find_vfstab_dev) saved_dump_dev=$(save_dump_dev) dump_dev=${disk}s0 nonexist_dev=${disk}sbad_slice_num create_pool "$TESTPOOL" "${pooldevs[0]}" log_must poolexists "$TESTPOOL" create_pool "$TESTPOOL1" "${pooldevs[1]}" log_must poolexists "$TESTPOOL1" [[ -n $mnttab_dev ]] || log_note "No mnttab devices found" [[ -n $vfstab_dev ]] || log_note "No vfstab devices found" # - nonexist device, # - part of an active pool, # - currently mounted, # - devices in /etc/vfstab, # - identical with the basic or spares vdev within the pool, set -A arg "$nonexist_dev" \ "${pooldevs[0]}" \ "${pooldevs[1]}" \ "$mnttab_dev" \ "$vfstab_dev" typeset -i i=0 while (( i < ${#arg[*]} )); do if [[ -n "${arg[i]}" ]]; then log_mustnot $ZPOOL add $TESTPOOL spare ${arg[i]} log_mustnot $ZPOOL add -f $TESTPOOL spare ${arg[i]} fi (( i = i + 1 )) done # - specified as the dedicated dump device, # This part of the test can only be run on platforms for which DUMPADM is # defined; ie Solaris if [[ -n $DUMPADM ]]; then log_must $DUMPADM -u -d /dev/dsk/$dump_dev log_mustnot $ZPOOL add "$TESTPOOL" spare $dump_dev log_mustnot $ZPOOL add -f "$TESTPOOL" spare $dump_dev fi # - belong to a exported or potentially active ZFS pool, log_must $ZPOOL export $TESTPOOL1 log_mustnot $ZPOOL add "$TESTPOOL" spare ${pooldevs[1]} log_must $ZPOOL import -d $HOTSPARE_TMPDIR $TESTPOOL1 log_pass "'zpool add [-f]' with hot spares should fail with inapplicable scenarios."