diff --git a/lib/libc/gen/sysconf.c b/lib/libc/gen/sysconf.c index 66562d0e29f0..b5b732eed05d 100644 --- a/lib/libc/gen/sysconf.c +++ b/lib/libc/gen/sysconf.c @@ -1,619 +1,619 @@ /*- * SPDX-License-Identifier: BSD-3-Clause * * Copyright (c) 1993 * The Regents of the University of California. All rights reserved. * * This code is derived from software contributed to Berkeley by * Sean Eric Fagan of Cygnus Support. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: * 1. Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * 2. Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. * 3. Neither the name of the University nor the names of its contributors * may be used to endorse or promote products derived from this software * without specific prior written permission. * * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. */ #include "namespace.h" #include #include #include #include #include #include #include #include #include #include #include /* we just need the limits */ #include #include #include #include "un-namespace.h" #include "../stdlib/atexit.h" -#include "tzdir.h" /* from ../../../contrib/tzcode/stdtime */ +#include "tzdir.h" /* from ../../../contrib/tzcode */ #include "libc_private.h" #define _PATH_ZONEINFO TZDIR /* from tzfile.h */ /* * sysconf -- * get configurable system variables. * * XXX * POSIX 1003.1 (ISO/IEC 9945-1, 4.8.1.3) states that the variable values * not change during the lifetime of the calling process. This would seem * to require that any change to system limits kill all running processes. * A workaround might be to cache the values when they are first retrieved * and then simply return the cached value on subsequent calls. This is * less useful than returning up-to-date values, however. */ long sysconf(int name) { struct rlimit rl; size_t len; int mib[2], sverrno, value; long lvalue, defaultresult; const char *path; defaultresult = -1; switch (name) { case _SC_ARG_MAX: mib[0] = CTL_KERN; mib[1] = KERN_ARGMAX; break; case _SC_CHILD_MAX: if (getrlimit(RLIMIT_NPROC, &rl) != 0) return (-1); if (rl.rlim_cur == RLIM_INFINITY) return (-1); if (rl.rlim_cur > LONG_MAX) { errno = EOVERFLOW; return (-1); } return ((long)rl.rlim_cur); case _SC_CLK_TCK: return (CLK_TCK); case _SC_NGROUPS_MAX: mib[0] = CTL_KERN; mib[1] = KERN_NGROUPS; break; case _SC_OPEN_MAX: if (getrlimit(RLIMIT_NOFILE, &rl) != 0) return (-1); if (rl.rlim_cur == RLIM_INFINITY) return (-1); if (rl.rlim_cur > LONG_MAX) { errno = EOVERFLOW; return (-1); } return ((long)rl.rlim_cur); case _SC_STREAM_MAX: if (getrlimit(RLIMIT_NOFILE, &rl) != 0) return (-1); if (rl.rlim_cur == RLIM_INFINITY) return (-1); if (rl.rlim_cur > LONG_MAX) { errno = EOVERFLOW; return (-1); } /* * struct __sFILE currently has a limitation that * file descriptors must fit in a signed short. * This doesn't precisely capture the letter of POSIX * but approximates the spirit. */ if (rl.rlim_cur > SHRT_MAX) return (SHRT_MAX); return ((long)rl.rlim_cur); case _SC_JOB_CONTROL: return (_POSIX_JOB_CONTROL); case _SC_SAVED_IDS: /* XXX - must be 1 */ mib[0] = CTL_KERN; mib[1] = KERN_SAVED_IDS; goto yesno; case _SC_VERSION: mib[0] = CTL_KERN; mib[1] = KERN_POSIX1; break; case _SC_BC_BASE_MAX: return (BC_BASE_MAX); case _SC_BC_DIM_MAX: return (BC_DIM_MAX); case _SC_BC_SCALE_MAX: return (BC_SCALE_MAX); case _SC_BC_STRING_MAX: return (BC_STRING_MAX); case _SC_COLL_WEIGHTS_MAX: return (COLL_WEIGHTS_MAX); case _SC_EXPR_NEST_MAX: return (EXPR_NEST_MAX); case _SC_LINE_MAX: return (LINE_MAX); case _SC_RE_DUP_MAX: return (RE_DUP_MAX); case _SC_2_VERSION: /* * This is something of a lie, but it would be silly at * this point to try to deduce this from the contents * of the filesystem. */ return (_POSIX2_VERSION); case _SC_2_C_BIND: return (_POSIX2_C_BIND); case _SC_2_C_DEV: return (_POSIX2_C_DEV); case _SC_2_CHAR_TERM: return (_POSIX2_CHAR_TERM); case _SC_2_FORT_DEV: return (_POSIX2_FORT_DEV); case _SC_2_FORT_RUN: return (_POSIX2_FORT_RUN); case _SC_2_LOCALEDEF: return (_POSIX2_LOCALEDEF); case _SC_2_SW_DEV: return (_POSIX2_SW_DEV); case _SC_2_UPE: return (_POSIX2_UPE); case _SC_TZNAME_MAX: path = _PATH_ZONEINFO; do_NAME_MAX: sverrno = errno; errno = 0; lvalue = pathconf(path, _PC_NAME_MAX); if (lvalue == -1 && errno != 0) return (-1); errno = sverrno; return (lvalue); case _SC_ASYNCHRONOUS_IO: #if _POSIX_ASYNCHRONOUS_IO == 0 mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_ASYNCHRONOUS_IO; break; #else return (_POSIX_ASYNCHRONOUS_IO); #endif case _SC_MAPPED_FILES: return (_POSIX_MAPPED_FILES); case _SC_MEMLOCK: return (_POSIX_MEMLOCK); case _SC_MEMLOCK_RANGE: return (_POSIX_MEMLOCK_RANGE); case _SC_MEMORY_PROTECTION: return (_POSIX_MEMORY_PROTECTION); case _SC_MESSAGE_PASSING: #if _POSIX_MESSAGE_PASSING == 0 mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_MESSAGE_PASSING; goto yesno; #else return (_POSIX_MESSAGE_PASSING); #endif case _SC_PRIORITIZED_IO: #if _POSIX_PRIORITIZED_IO == 0 mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_PRIORITIZED_IO; goto yesno; #else return (_POSIX_PRIORITIZED_IO); #endif case _SC_PRIORITY_SCHEDULING: #if _POSIX_PRIORITY_SCHEDULING == 0 mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_PRIORITY_SCHEDULING; goto yesno; #else return (_POSIX_PRIORITY_SCHEDULING); #endif case _SC_REALTIME_SIGNALS: #if _POSIX_REALTIME_SIGNALS == 0 mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_REALTIME_SIGNALS; goto yesno; #else return (_POSIX_REALTIME_SIGNALS); #endif case _SC_SEMAPHORES: #if _POSIX_SEMAPHORES == 0 mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_SEMAPHORES; goto yesno; #else return (_POSIX_SEMAPHORES); #endif case _SC_FSYNC: return (_POSIX_FSYNC); case _SC_SHARED_MEMORY_OBJECTS: return (_POSIX_SHARED_MEMORY_OBJECTS); case _SC_SYNCHRONIZED_IO: #if _POSIX_SYNCHRONIZED_IO == 0 mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_SYNCHRONIZED_IO; goto yesno; #else return (_POSIX_SYNCHRONIZED_IO); #endif case _SC_TIMERS: #if _POSIX_TIMERS == 0 mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_TIMERS; goto yesno; #else return (_POSIX_TIMERS); #endif case _SC_AIO_LISTIO_MAX: mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_AIO_LISTIO_MAX; break; case _SC_AIO_MAX: mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_AIO_MAX; break; case _SC_AIO_PRIO_DELTA_MAX: mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_AIO_PRIO_DELTA_MAX; break; case _SC_DELAYTIMER_MAX: mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_DELAYTIMER_MAX; goto yesno; case _SC_MQ_OPEN_MAX: mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_MQ_OPEN_MAX; goto yesno; case _SC_NSIG: return (_SIG_MAXSIG); case _SC_PAGESIZE: return (getpagesize()); case _SC_RTSIG_MAX: mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_RTSIG_MAX; goto yesno; case _SC_SEM_NSEMS_MAX: return (-1); case _SC_SEM_VALUE_MAX: return (SEM_VALUE_MAX); case _SC_SIGQUEUE_MAX: mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_SIGQUEUE_MAX; goto yesno; case _SC_TIMER_MAX: mib[0] = CTL_P1003_1B; mib[1] = CTL_P1003_1B_TIMER_MAX; yesno: len = sizeof(value); if (sysctl(mib, 2, &value, &len, NULL, 0) == -1) return (-1); if (value == 0) return (defaultresult); return ((long)value); case _SC_2_PBS: case _SC_2_PBS_ACCOUNTING: case _SC_2_PBS_CHECKPOINT: case _SC_2_PBS_LOCATE: case _SC_2_PBS_MESSAGE: case _SC_2_PBS_TRACK: #if _POSIX2_PBS == 0 #error "don't know how to determine _SC_2_PBS" /* * This probably requires digging through the filesystem * to see if the appropriate package has been installed. * Since we don't currently support this option at all, * it's not worth the effort to write the code now. * Figuring out which of the sub-options are supported * would be even more difficult, so it's probably easier * to always say ``no''. */ #else return (_POSIX2_PBS); #endif case _SC_ADVISORY_INFO: #if _POSIX_ADVISORY_INFO == 0 #error "_POSIX_ADVISORY_INFO" #else return (_POSIX_ADVISORY_INFO); #endif case _SC_BARRIERS: #if _POSIX_BARRIERS == 0 #error "_POSIX_BARRIERS" #else return (_POSIX_BARRIERS); #endif case _SC_CLOCK_SELECTION: #if _POSIX_CLOCK_SELECTION == 0 #error "_POSIX_CLOCK_SELECTION" #else return (_POSIX_CLOCK_SELECTION); #endif case _SC_CPUTIME: return (_POSIX_CPUTIME); #ifdef notdef case _SC_FILE_LOCKING: /* * XXX - The standard doesn't tell us how to define * _POSIX_FILE_LOCKING, so we can't answer this one. */ #endif /* * SUSv4tc1 says the following about _SC_GETGR_R_SIZE_MAX and * _SC_GETPW_R_SIZE_MAX: * Note that sysconf(_SC_GETGR_R_SIZE_MAX) may return -1 if * there is no hard limit on the size of the buffer needed to * store all the groups returned. */ case _SC_GETGR_R_SIZE_MAX: case _SC_GETPW_R_SIZE_MAX: return (-1); case _SC_HOST_NAME_MAX: return (MAXHOSTNAMELEN - 1); /* does not include \0 */ case _SC_LOGIN_NAME_MAX: return (MAXLOGNAME); case _SC_MONOTONIC_CLOCK: #if _POSIX_MONOTONIC_CLOCK == 0 #error "_POSIX_MONOTONIC_CLOCK" #else return (_POSIX_MONOTONIC_CLOCK); #endif #if _POSIX_MESSAGE_PASSING > -1 case _SC_MQ_PRIO_MAX: return (MQ_PRIO_MAX); #endif case _SC_READER_WRITER_LOCKS: return (_POSIX_READER_WRITER_LOCKS); case _SC_REGEXP: return (_POSIX_REGEXP); case _SC_SHELL: return (_POSIX_SHELL); case _SC_SPAWN: return (_POSIX_SPAWN); case _SC_SPIN_LOCKS: return (_POSIX_SPIN_LOCKS); case _SC_SPORADIC_SERVER: #if _POSIX_SPORADIC_SERVER == 0 #error "_POSIX_SPORADIC_SERVER" #else return (_POSIX_SPORADIC_SERVER); #endif case _SC_THREAD_ATTR_STACKADDR: return (_POSIX_THREAD_ATTR_STACKADDR); case _SC_THREAD_ATTR_STACKSIZE: return (_POSIX_THREAD_ATTR_STACKSIZE); case _SC_THREAD_CPUTIME: return (_POSIX_THREAD_CPUTIME); case _SC_THREAD_DESTRUCTOR_ITERATIONS: return (PTHREAD_DESTRUCTOR_ITERATIONS); case _SC_THREAD_KEYS_MAX: return (PTHREAD_KEYS_MAX); case _SC_THREAD_PRIO_INHERIT: return (_POSIX_THREAD_PRIO_INHERIT); case _SC_THREAD_PRIO_PROTECT: return (_POSIX_THREAD_PRIO_PROTECT); case _SC_THREAD_PRIORITY_SCHEDULING: return (_POSIX_THREAD_PRIORITY_SCHEDULING); case _SC_THREAD_PROCESS_SHARED: return (_POSIX_THREAD_PROCESS_SHARED); case _SC_THREAD_SAFE_FUNCTIONS: return (_POSIX_THREAD_SAFE_FUNCTIONS); case _SC_THREAD_STACK_MIN: return (PTHREAD_STACK_MIN); case _SC_THREAD_THREADS_MAX: return (PTHREAD_THREADS_MAX); /* XXX wrong type! */ case _SC_TIMEOUTS: return (_POSIX_TIMEOUTS); case _SC_THREADS: return (_POSIX_THREADS); case _SC_TRACE: #if _POSIX_TRACE == 0 #error "_POSIX_TRACE" /* While you're implementing this, also do the ones below. */ #else return (_POSIX_TRACE); #endif #if _POSIX_TRACE > -1 case _SC_TRACE_EVENT_FILTER: return (_POSIX_TRACE_EVENT_FILTER); case _SC_TRACE_INHERIT: return (_POSIX_TRACE_INHERIT); case _SC_TRACE_LOG: return (_POSIX_TRACE_LOG); #endif case _SC_TTY_NAME_MAX: path = _PATH_DEV; goto do_NAME_MAX; case _SC_TYPED_MEMORY_OBJECTS: #if _POSIX_TYPED_MEMORY_OBJECTS == 0 #error "_POSIX_TYPED_MEMORY_OBJECTS" #else return (_POSIX_TYPED_MEMORY_OBJECTS); #endif case _SC_V6_ILP32_OFF32: #if _V6_ILP32_OFF32 == 0 if (sizeof(int) * CHAR_BIT == 32 && sizeof(int) == sizeof(long) && sizeof(long) == sizeof(void *) && sizeof(void *) == sizeof(off_t)) return 1; else return -1; #else return (_V6_ILP32_OFF32); #endif case _SC_V6_ILP32_OFFBIG: #if _V6_ILP32_OFFBIG == 0 if (sizeof(int) * CHAR_BIT == 32 && sizeof(int) == sizeof(long) && sizeof(long) == sizeof(void *) && sizeof(off_t) * CHAR_BIT >= 64) return 1; else return -1; #else return (_V6_ILP32_OFFBIG); #endif case _SC_V6_LP64_OFF64: #if _V6_LP64_OFF64 == 0 if (sizeof(int) * CHAR_BIT == 32 && sizeof(long) * CHAR_BIT == 64 && sizeof(long) == sizeof(void *) && sizeof(void *) == sizeof(off_t)) return 1; else return -1; #else return (_V6_LP64_OFF64); #endif case _SC_V6_LPBIG_OFFBIG: #if _V6_LPBIG_OFFBIG == 0 if (sizeof(int) * CHAR_BIT >= 32 && sizeof(long) * CHAR_BIT >= 64 && sizeof(void *) * CHAR_BIT >= 64 && sizeof(off_t) * CHAR_BIT >= 64) return 1; else return -1; #else return (_V6_LPBIG_OFFBIG); #endif case _SC_ATEXIT_MAX: return (ATEXIT_SIZE); case _SC_IOV_MAX: mib[0] = CTL_KERN; mib[1] = KERN_IOV_MAX; break; case _SC_XOPEN_CRYPT: return (_XOPEN_CRYPT); case _SC_XOPEN_ENH_I18N: return (_XOPEN_ENH_I18N); case _SC_XOPEN_LEGACY: return (_XOPEN_LEGACY); case _SC_XOPEN_REALTIME: #if _XOPEN_REALTIME == 0 sverrno = errno; value = sysconf(_SC_ASYNCHRONOUS_IO) > 0 && sysconf(_SC_MEMLOCK) > 0 && sysconf(_SC_MEMLOCK_RANGE) > 0 && sysconf(_SC_MESSAGE_PASSING) > 0 && sysconf(_SC_PRIORITY_SCHEDULING) > 0 && sysconf(_SC_REALTIME_SIGNALS) > 0 && sysconf(_SC_SEMAPHORES) > 0 && sysconf(_SC_SHARED_MEMORY_OBJECTS) > 0 && sysconf(_SC_SYNCHRONIZED_IO) > 0 && sysconf(_SC_TIMERS) > 0; errno = sverrno; if (value) return (200112L); else return (-1); #else return (_XOPEN_REALTIME); #endif case _SC_XOPEN_REALTIME_THREADS: #if _XOPEN_REALTIME_THREADS == 0 #error "_XOPEN_REALTIME_THREADS" #else return (_XOPEN_REALTIME_THREADS); #endif case _SC_XOPEN_SHM: len = sizeof(lvalue); sverrno = errno; if (sysctlbyname("kern.ipc.shmmin", &lvalue, &len, NULL, 0) == -1) { errno = sverrno; return (-1); } errno = sverrno; return (1); case _SC_XOPEN_STREAMS: return (_XOPEN_STREAMS); case _SC_XOPEN_UNIX: return (_XOPEN_UNIX); #ifdef _XOPEN_VERSION case _SC_XOPEN_VERSION: return (_XOPEN_VERSION); #endif #ifdef _XOPEN_XCU_VERSION case _SC_XOPEN_XCU_VERSION: return (_XOPEN_XCU_VERSION); #endif case _SC_SYMLOOP_MAX: return (MAXSYMLINKS); case _SC_RAW_SOCKETS: return (_POSIX_RAW_SOCKETS); case _SC_IPV6: #if _POSIX_IPV6 == 0 sverrno = errno; value = _socket(PF_INET6, SOCK_CLOEXEC | SOCK_DGRAM, 0); errno = sverrno; if (value >= 0) { _close(value); return (200112L); } else return (0); #else return (_POSIX_IPV6); #endif case _SC_NPROCESSORS_CONF: case _SC_NPROCESSORS_ONLN: if (_elf_aux_info(AT_NCPUS, &value, sizeof(value)) == 0) return ((long)value); mib[0] = CTL_HW; mib[1] = HW_NCPU; break; #ifdef _SC_PHYS_PAGES case _SC_PHYS_PAGES: len = sizeof(lvalue); if (sysctlbyname("hw.availpages", &lvalue, &len, NULL, 0) == -1) return (-1); return (lvalue); #endif #ifdef _SC_CPUSET_SIZE case _SC_CPUSET_SIZE: len = sizeof(value); if (sysctlbyname("kern.sched.cpusetsize", &value, &len, NULL, 0) == -1) return (-1); return ((long)value); #endif case _SC_UEXTERR_MAXLEN: return (UEXTERROR_MAXLEN); default: errno = EINVAL; return (-1); } len = sizeof(value); if (sysctl(mib, 2, &value, &len, NULL, 0) == -1) value = -1; return ((long)value); } diff --git a/lib/libc/tests/stdtime/Makefile b/lib/libc/tests/stdtime/Makefile index 6b9068e1641b..590dea22da31 100644 --- a/lib/libc/tests/stdtime/Makefile +++ b/lib/libc/tests/stdtime/Makefile @@ -1,12 +1,13 @@ .include ATF_TESTS_C+= strptime_test ATF_TESTS_C+= detect_tz_changes_test +CFLAGS.detect_tz_changes_test+= -I${SRCTOP}/contrib/tzcode .if ${MK_DETECT_TZ_CHANGES} != "no" CFLAGS.detect_tz_changes_test+= -DDETECT_TZ_CHANGES .endif TESTSDIR:= ${TESTSBASE}/${RELDIR:C/libc\/tests/libc/} .include diff --git a/lib/libc/tests/stdtime/detect_tz_changes_test.c b/lib/libc/tests/stdtime/detect_tz_changes_test.c index 6648d8498cc5..fe6b04357331 100644 --- a/lib/libc/tests/stdtime/detect_tz_changes_test.c +++ b/lib/libc/tests/stdtime/detect_tz_changes_test.c @@ -1,390 +1,464 @@ /*- * Copyright (c) 2025 Klara, Inc. * * SPDX-License-Identifier: BSD-2-Clause */ #include #include #include #include #include #include #include #include #include #include #include #include #include #include +#include "tzdir.h" + #include static const struct tzcase { const char *tzfn; const char *expect; } tzcases[] = { /* * A handful of time zones and the expected result of * strftime("%z (%Z)", tm) when that time zone is active * and tm represents a date in the summer of 2025. */ { "America/Vancouver", "-0700 (PDT)" }, { "America/New_York", "-0400 (EDT)" }, { "Europe/London", "+0100 (BST)" }, { "Europe/Paris", "+0200 (CEST)" }, { "Asia/Kolkata", "+0530 (IST)" }, { "Asia/Tokyo", "+0900 (JST)" }, { "Australia/Canberra", "+1000 (AEST)" }, { "UTC", "+0000 (UTC)" }, { 0 }, }; static const time_t then = 1751328000; /* 2025-07-01 00:00:00 UTC */ static bool debugging; static void debug(const char *fmt, ...) { va_list ap; if (debugging) { va_start(ap, fmt); vfprintf(stderr, fmt, ap); va_end(ap); fputc('\n', stderr); } } static void change_tz(const char *tzn) { - static const char *zfn = "/usr/share/zoneinfo"; - static const char *tfn = "root/etc/.localtime"; - static const char *dfn = "root/etc/localtime"; + static const char *zfn = TZDIR; + static const char *tfn = "root" TZDEFAULT ".tmp"; + static const char *dfn = "root" TZDEFAULT; ssize_t clen; int zfd, sfd, dfd; ATF_REQUIRE((zfd = open(zfn, O_DIRECTORY | O_SEARCH)) >= 0); ATF_REQUIRE((sfd = openat(zfd, tzn, O_RDONLY)) >= 0); ATF_REQUIRE((dfd = open(tfn, O_CREAT | O_TRUNC | O_WRONLY, 0644)) >= 0); do { clen = copy_file_range(sfd, NULL, dfd, NULL, SSIZE_MAX, 0); ATF_REQUIRE_MSG(clen != -1, "failed to copy %s/%s: %m", zfn, tzn); } while (clen > 0); ATF_CHECK_EQ(0, close(dfd)); ATF_CHECK_EQ(0, close(sfd)); ATF_CHECK_EQ(0, close(zfd)); ATF_REQUIRE_EQ(0, rename(tfn, dfn)); debug("time zone %s installed", tzn); } static void test_tz(const char *expect) { char buf[128]; struct tm *tm; size_t len; ATF_REQUIRE((tm = localtime(&then)) != NULL); len = strftime(buf, sizeof(buf), "%z (%Z)", tm); ATF_REQUIRE(len > 0); ATF_CHECK_STREQ(expect, buf); } +ATF_TC(tz_default); +ATF_TC_HEAD(tz_default, tc) +{ + atf_tc_set_md_var(tc, "descr", "Test default zone"); + atf_tc_set_md_var(tc, "require.user", "root"); +} +ATF_TC_BODY(tz_default, tc) +{ + /* prepare chroot with no /etc/localtime */ + ATF_REQUIRE_EQ(0, mkdir("root", 0755)); + ATF_REQUIRE_EQ(0, mkdir("root/etc", 0755)); + /* enter chroot */ + ATF_REQUIRE_EQ(0, chroot("root")); + ATF_REQUIRE_EQ(0, chdir("/")); + /* check timezone */ + unsetenv("TZ"); + test_tz("+0000 (UTC)"); +} + +ATF_TC(tz_invalid_file); +ATF_TC_HEAD(tz_invalid_file, tc) +{ + atf_tc_set_md_var(tc, "descr", "Test invalid zone file"); + atf_tc_set_md_var(tc, "require.user", "root"); +} +ATF_TC_BODY(tz_invalid_file, tc) +{ + static const char *dfn = "root/etc/localtime"; + int fd; + + /* prepare chroot with bogus /etc/localtime */ + ATF_REQUIRE_EQ(0, mkdir("root", 0755)); + ATF_REQUIRE_EQ(0, mkdir("root/etc", 0755)); + ATF_REQUIRE((fd = open(dfn, O_RDWR | O_CREAT, 0644)) >= 0); + ATF_REQUIRE_EQ(8, write(fd, "invalid\n", 8)); + ATF_REQUIRE_EQ(0, close(fd)); + /* enter chroot */ + ATF_REQUIRE_EQ(0, chroot("root")); + ATF_REQUIRE_EQ(0, chdir("/")); + /* check timezone */ + unsetenv("TZ"); + test_tz("+0000 (-00)"); +} + ATF_TC(thin_jail); ATF_TC_HEAD(thin_jail, tc) { atf_tc_set_md_var(tc, "descr", "Test typical thin jail scenario"); atf_tc_set_md_var(tc, "require.user", "root"); } ATF_TC_BODY(thin_jail, tc) { const struct tzcase *tzcase = tzcases; /* prepare chroot */ ATF_REQUIRE_EQ(0, mkdir("root", 0755)); ATF_REQUIRE_EQ(0, mkdir("root/etc", 0755)); change_tz(tzcase->tzfn); /* enter chroot */ ATF_REQUIRE_EQ(0, chroot("root")); ATF_REQUIRE_EQ(0, chdir("/")); /* check timezone */ unsetenv("TZ"); test_tz(tzcase->expect); } #ifdef DETECT_TZ_CHANGES /* * Test time zone change detection. * * The parent creates a chroot containing only /etc/localtime, initially * set to UTC. It then forks a child which enters the chroot, repeatedly * checks the current time zone, and prints it to stdout if it changes * (including once on startup). Meanwhile, the parent waits for output * from the child. Every time it receives a line of text from the child, * it checks that it is as expected, then changes /etc/localtime within * the chroot to the next case in the list. Once it reaches the end of * the list, it closes a pipe to notify the child, which terminates. * * Note that ATF and / or Kyua may have set the timezone before the test * case starts (even unintentionally). Therefore, we start the test only * after we've received and discarded the first report from the child, * which should come almost immediately on startup. */ static const char *tz_change_interval_sym = "__tz_change_interval"; static int *tz_change_interval_p; static const int tz_change_interval = 3; static int tz_change_timeout = 90; ATF_TC(detect_tz_changes); ATF_TC_HEAD(detect_tz_changes, tc) { atf_tc_set_md_var(tc, "descr", "Test timezone change detection"); atf_tc_set_md_var(tc, "require.user", "root"); atf_tc_set_md_var(tc, "timeout", "600"); } ATF_TC_BODY(detect_tz_changes, tc) { char obuf[1024] = ""; char ebuf[1024] = ""; struct pollfd fds[3]; int opd[2], epd[2], spd[2]; time_t changed, now; const struct tzcase *tzcase = NULL; struct tm *tm; size_t olen = 0, elen = 0; ssize_t rlen; long curoff = LONG_MIN; pid_t pid; int nfds, status; /* speed up the test if possible */ tz_change_interval_p = dlsym(RTLD_SELF, tz_change_interval_sym); if (tz_change_interval_p != NULL && *tz_change_interval_p > tz_change_interval) { debug("reducing detection interval from %d to %d", *tz_change_interval_p, tz_change_interval); *tz_change_interval_p = tz_change_interval; tz_change_timeout = tz_change_interval * 3; } /* prepare chroot */ ATF_REQUIRE_EQ(0, mkdir("root", 0755)); ATF_REQUIRE_EQ(0, mkdir("root/etc", 0755)); change_tz("UTC"); time(&changed); /* output, error, sync pipes */ if (pipe(opd) != 0 || pipe(epd) != 0 || pipe(spd) != 0) atf_tc_fail("failed to pipe"); /* fork child */ if ((pid = fork()) < 0) atf_tc_fail("failed to fork"); if (pid == 0) { /* child */ dup2(opd[1], STDOUT_FILENO); close(opd[0]); close(opd[1]); dup2(epd[1], STDERR_FILENO); close(epd[0]); close(epd[1]); close(spd[0]); unsetenv("TZ"); ATF_REQUIRE_EQ(0, chroot("root")); ATF_REQUIRE_EQ(0, chdir("/")); fds[0].fd = spd[1]; fds[0].events = POLLIN; for (;;) { ATF_REQUIRE(poll(fds, 1, 100) >= 0); if (fds[0].revents & POLLHUP) { /* parent closed sync pipe */ _exit(0); } ATF_REQUIRE((tm = localtime(&then)) != NULL); if (tm->tm_gmtoff == curoff) continue; olen = strftime(obuf, sizeof(obuf), "%z (%Z)", tm); ATF_REQUIRE(olen > 0); fprintf(stdout, "%s\n", obuf); fflush(stdout); curoff = tm->tm_gmtoff; } _exit(2); } /* parent */ close(opd[1]); close(epd[1]); close(spd[1]); /* receive output until child terminates */ fds[0].fd = opd[0]; fds[0].events = POLLIN; fds[1].fd = epd[0]; fds[1].events = POLLIN; fds[2].fd = spd[0]; fds[2].events = POLLIN; nfds = 3; for (;;) { ATF_REQUIRE(poll(fds, 3, 1000) >= 0); time(&now); if (fds[0].revents & POLLIN && olen < sizeof(obuf)) { rlen = read(opd[0], obuf + olen, sizeof(obuf) - olen); ATF_REQUIRE(rlen >= 0); olen += rlen; } if (olen > 0) { ATF_REQUIRE_EQ('\n', obuf[olen - 1]); obuf[--olen] = '\0'; /* tzcase will be NULL at first */ if (tzcase != NULL) { debug("%s", obuf); ATF_REQUIRE_STREQ(tzcase->expect, obuf); debug("change to %s detected after %d s", tzcase->tzfn, (int)(now - changed)); if (tz_change_interval_p != NULL) { ATF_CHECK((int)(now - changed) >= *tz_change_interval_p - 1); ATF_CHECK((int)(now - changed) <= *tz_change_interval_p + 1); } } olen = 0; /* first / next test case */ if (tzcase == NULL) tzcase = tzcases; else tzcase++; if (tzcase->tzfn == NULL) { /* test is over */ break; } change_tz(tzcase->tzfn); changed = now; } if (fds[1].revents & POLLIN && elen < sizeof(ebuf)) { rlen = read(epd[0], ebuf + elen, sizeof(ebuf) - elen); ATF_REQUIRE(rlen >= 0); elen += rlen; } if (elen > 0) { ATF_REQUIRE_EQ(elen, fwrite(ebuf, 1, elen, stderr)); elen = 0; } if (nfds > 2 && fds[2].revents & POLLHUP) { /* child closed sync pipe */ break; } /* * The timeout for this test case is set to 10 minutes, * because it can take that long to run with the default * 61-second interval. However, each individual tzcase * entry should not take much longer than the detection * interval to test, so we can detect a problem long * before Kyua terminates us. */ if ((now - changed) > tz_change_timeout) { close(spd[0]); if (tz_change_interval_p == NULL && tzcase == tzcases) { /* * The most likely explanation in this * case is that libc was built without * time zone change detection. */ atf_tc_skip("time zone change detection " "does not appear to be enabled"); } atf_tc_fail("timed out waiting for change to %s " "to be detected", tzcase->tzfn); } } close(opd[0]); close(epd[0]); close(spd[0]); /* this will wake up and terminate the child */ if (olen > 0) ATF_REQUIRE_EQ(olen, fwrite(obuf, 1, olen, stdout)); if (elen > 0) ATF_REQUIRE_EQ(elen, fwrite(ebuf, 1, elen, stderr)); ATF_REQUIRE_EQ(pid, waitpid(pid, &status, 0)); ATF_REQUIRE(WIFEXITED(status)); ATF_REQUIRE_EQ(0, WEXITSTATUS(status)); } #endif /* DETECT_TZ_CHANGES */ static void test_tz_env(const char *tzval, const char *expect) { setenv("TZ", tzval, 1); test_tz(expect); } ATF_TC(tz_env); ATF_TC_HEAD(tz_env, tc) { atf_tc_set_md_var(tc, "descr", "Test TZ environment variable"); } ATF_TC_BODY(tz_env, tc) { - const struct tzcase *tzcase; + char path[MAXPATHLEN]; + const struct tzcase *tzcase = tzcases; + int len; + /* relative path */ for (tzcase = tzcases; tzcase->tzfn != NULL; tzcase++) test_tz_env(tzcase->tzfn, tzcase->expect); + /* absolute path */ + for (tzcase = tzcases; tzcase->tzfn != NULL; tzcase++) { + len = snprintf(path, sizeof(path), "%s/%s", TZDIR, tzcase->tzfn); + ATF_REQUIRE(len > 0 && (size_t)len < sizeof(path)); + test_tz_env(path, tzcase->expect); + } + /* absolute path with additional slashes */ + for (tzcase = tzcases; tzcase->tzfn != NULL; tzcase++) { + len = snprintf(path, sizeof(path), "%s/////%s", TZDIR, tzcase->tzfn); + ATF_REQUIRE(len > 0 && (size_t)len < sizeof(path)); + test_tz_env(path, tzcase->expect); + } +} + + +ATF_TC(tz_invalid_env); +ATF_TC_HEAD(tz_invalid_env, tc) +{ + atf_tc_set_md_var(tc, "descr", "Test invalid TZ value"); + atf_tc_set_md_var(tc, "require.user", "root"); +} +ATF_TC_BODY(tz_invalid_env, tc) +{ + test_tz_env("invalid", "+0000 (-00)"); + test_tz_env(":invalid", "+0000 (-00)"); } ATF_TC(setugid); ATF_TC_HEAD(setugid, tc) { atf_tc_set_md_var(tc, "descr", "Test setugid process"); atf_tc_set_md_var(tc, "require.user", "root"); } ATF_TC_BODY(setugid, tc) { const struct tzcase *tzcase = tzcases; /* prepare chroot */ ATF_REQUIRE_EQ(0, mkdir("root", 0755)); ATF_REQUIRE_EQ(0, mkdir("root/etc", 0755)); change_tz(tzcase->tzfn); /* enter chroot */ ATF_REQUIRE_EQ(0, chroot("root")); ATF_REQUIRE_EQ(0, chdir("/")); /* become setugid */ ATF_REQUIRE_EQ(0, seteuid(UID_NOBODY)); ATF_REQUIRE(issetugid()); /* check timezone */ unsetenv("TZ"); test_tz(tzcases->expect); } ATF_TC(tz_env_setugid); ATF_TC_HEAD(tz_env_setugid, tc) { atf_tc_set_md_var(tc, "descr", "Test TZ environment variable " "in setugid process"); atf_tc_set_md_var(tc, "require.user", "root"); } ATF_TC_BODY(tz_env_setugid, tc) { - const struct tzcase *tzcase = tzcases; - ATF_REQUIRE_EQ(0, seteuid(UID_NOBODY)); ATF_REQUIRE(issetugid()); - for (tzcase = tzcases; tzcase->tzfn != NULL; tzcase++) - test_tz_env(tzcase->tzfn, tzcase->expect); + ATF_TC_BODY_NAME(tz_env)(tc); } ATF_TP_ADD_TCS(tp) { debugging = !getenv("__RUNNING_INSIDE_ATF_RUN") && isatty(STDERR_FILENO); + ATF_TP_ADD_TC(tp, tz_default); + ATF_TP_ADD_TC(tp, tz_invalid_file); ATF_TP_ADD_TC(tp, thin_jail); #ifdef DETECT_TZ_CHANGES ATF_TP_ADD_TC(tp, detect_tz_changes); #endif /* DETECT_TZ_CHANGES */ ATF_TP_ADD_TC(tp, tz_env); + ATF_TP_ADD_TC(tp, tz_invalid_env); ATF_TP_ADD_TC(tp, setugid); ATF_TP_ADD_TC(tp, tz_env_setugid); return (atf_no_error()); }