Diffusion FreeBSD src repository 8bda488114f3

ping: Don't mix stdio and direct writes
8bda488114f3
Actions

Description

ping: Don't mix stdio and direct writes

POSIX does not allow mixing direct writes to STDOUT_FILENO with stdio
operations on stdout like we do here. More importantly, it causes
tests to fail randomly (or not-so-randomly after I added an fflush in
a previous commit).

MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D57884

Details

Provenance

des	Authored on Jun 26 2026, 2:46 PM

Reviewer

markj

Differential Revision

D57884: ping: Don't mix stdio and direct writes

Parents

rGf0a861efbafe: local-unbound-setup: Support IPv6-only systems

Branches

Unknown

Tags

Unknown

Event Timeline

des committed rG8bda488114f3: ping: Don't mix stdio and direct writes (authored by des).Jun 26 2026, 2:46 PM

des added an edge: D57884: ping: Don't mix stdio and direct writes.

siva mentioned this in rG5b8c28adb829: ping/tests: expect bell chars from stderr after initial status.Jun 26 2026, 11:03 PM

siva mentioned this in rGf7f916d755fe: ping: Fix bell char ordering in -A test cases.Jun 30 2026, 1:11 PM

des mentioned this in rGb38b0be29bfd: ping: Flush stdout after printing initial status.Jul 7 2026, 8:58 PM

des mentioned this in rGf9f7b3aefab2: ping: Fix bell char ordering in -A test cases.

des mentioned this in rGdcb2c375221a: ping: Flush stdout after printing initial status.

des mentioned this in rGc6ed84f27bec: ping: Fix bell char ordering in -A test cases.

Changes (2)

Path

Size

sbin/

ping/

ping.c

ping6.c

rG8bda488114f3

View Options

sbin/ping/ping.c