HomeFreeBSD

Avoid posting duplicate zpool events

Description

Avoid posting duplicate zpool events

Duplicate io and checksum ereport events can misrepresent that
things are worse than they seem. Ideally the zpool events and the
corresponding vdev stat error counts in a zpool status should be
for unique errors -- not the same error being counted over and over.
This can be demonstrated in a simple example. With a single bad
block in a datafile and just 5 reads of the file we end up with a
degraded vdev, even though there is only one unique error in the pool.

The proposed solution to the above issue, is to eliminate duplicates
when posting events and when updating vdev error stats. We now save
recent error events of interest when posting events so that we can
easily check for duplicates when posting an error.

Reviewed by: Brad Lewis <brad.lewis@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Don Brady <don.brady@delphix.com>
Closes #10861

Details

Provenance
Don Brady <don.brady@delphix.com>Authored on Sep 4 2020, 5:34 PM
GitHub <noreply@github.com>Committed on Sep 4 2020, 5:34 PM
Parents
rG3808032489f2: nowait synctask must succeed
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rG4f0728278615: Avoid posting duplicate zpool events (authored by Don Brady <don.brady@delphix.com>).Sep 4 2020, 5:34 PM