HomeFreeBSD

inet_net_test: Use int to hold expected return values from inet_net_pton

Description

inet_net_test: Use int to hold expected return values from inet_net_pton

GCC warns about the sign mismatch in comparisons:

lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet4::body() const':
lib/libc/tests/net/inet_net_test.cc:86:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare]

86 |                 ATF_REQUIRE_EQ(bits, addr.bits);
   |                 ^~~~~~~~~~~~~~

lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void {anonymous}::atfu_tc_inet_net_inet6::body() const':
lib/libc/tests/net/inet_net_test.cc:205:17: error: comparison of integer expressions of different signedness: 'int' and 'const unsigned int' [-Werror=sign-compare]

205 |                 ATF_REQUIRE_EQ(bits, addr.bits);
    |                 ^~~~~~~~~~~~~~

Approved by: re (cperciva)
Fixes: 8f4a0d2f7b96 ("libc: Import OpenBSD's inet_net_{ntop,pton}")
(cherry picked from commit e1aeb58cbbc3839db93ec38ce491b7b9383d5649)
(cherry picked from commit 7ffd190ae9c82e4359d8a6f6ae2d1b82e8eb6453)

Details

Provenance
jhbAuthored on Oct 20 2025, 6:31 PM
cpercivaCommitted on Oct 26 2025, 4:13 AM
Parents
rG595ddf009a03: inet_net_test: Compare pointers against nullptr
Branches
Unknown
Tags
Unknown