Page MenuHomeFreeBSD

zlei.huang_gmail.com (Zhenlei Huang)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 1 2021, 3:21 AM (64 w, 3 d)

Recent Activity

Fri, Jun 17

zlei.huang_gmail.com added a comment to D35384: ifconfig.8: Prefer consistent terminologies.

Hi @0mp , do you have any objections ?

Fri, Jun 17, 6:39 AM

Thu, Jun 16

zlei.huang_gmail.com added a comment to D35409: ifconfig.8: Update to reflect the removal of FDDI and Token Ring media support.

@brooks Thanks !

Thu, Jun 16, 2:35 AM
zlei.huang_gmail.com added a comment to D35384: ifconfig.8: Prefer consistent terminologies.

Ping @pauamma_gundo.com since the parent D35409 has been merged.

Thu, Jun 16, 2:23 AM
zlei.huang_gmail.com updated the diff for D35384: ifconfig.8: Prefer consistent terminologies.
Thu, Jun 16, 2:21 AM

Wed, Jun 15

zlei.huang_gmail.com added a comment to D35409: ifconfig.8: Update to reflect the removal of FDDI and Token Ring media support.

Hi @brooks , I do not have direct access to src repository, may you please commit this?

Wed, Jun 15, 7:51 AM

Fri, Jun 10

zlei.huang_gmail.com added inline comments to D35409: ifconfig.8: Update to reflect the removal of FDDI and Token Ring media support.
Fri, Jun 10, 4:47 AM
zlei.huang_gmail.com added a comment to D35384: ifconfig.8: Prefer consistent terminologies.

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

Or are you planning to do that in D35409 instead?

Fri, Jun 10, 1:52 AM

Mon, Jun 6

zlei.huang_gmail.com retitled D35384: ifconfig.8: Prefer consistent terminologies from ifconfig.8: Prefer consistent terminology to ifconfig.8: Prefer consistent terminologies.
Mon, Jun 6, 8:14 AM
zlei.huang_gmail.com requested review of D35409: ifconfig.8: Update to reflect the removal of FDDI and Token Ring media support.
Mon, Jun 6, 8:12 AM
zlei.huang_gmail.com added inline comments to D35143: Bhyve virtio-net: Allow backend type to be explicitly specified..
Mon, Jun 6, 7:15 AM
zlei.huang_gmail.com added a comment to D35384: ifconfig.8: Prefer consistent terminologies.

@pauamma_gundo.com And what about the support status of FDDI ? It has been removed via D15170 .

Mon, Jun 6, 2:23 AM
zlei.huang_gmail.com updated the diff for D35384: ifconfig.8: Prefer consistent terminologies.
Mon, Jun 6, 2:19 AM

Thu, Jun 2

zlei.huang_gmail.com added a reviewer for D35384: ifconfig.8: Prefer consistent terminologies: manpages.
Thu, Jun 2, 10:42 AM
zlei.huang_gmail.com requested review of D35384: ifconfig.8: Prefer consistent terminologies.
Thu, Jun 2, 9:48 AM

May 24 2022

zlei.huang_gmail.com added a comment to D34563: devfs.rules: Do not expose "log" in the default devfs rules..

See also D35304

May 24 2022, 2:08 AM · Jails
zlei.huang_gmail.com added a comment to D34563: devfs.rules: Do not expose "log" in the default devfs rules..

Seems reasonable. I think /dev/log is legacy anyway.

does that mean i don't have to change anything about D27411 once this gets committed?

May 24 2022, 2:08 AM · Jails

May 23 2022

zlei.huang_gmail.com added a comment to D34563: devfs.rules: Do not expose "log" in the default devfs rules..

I do not have direct access to the repository, @markj may you please commit this?

May 23 2022, 6:58 AM · Jails

May 16 2022

zlei.huang_gmail.com added a comment to D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

Ping .

May 16 2022, 2:55 AM · network
zlei.huang_gmail.com added a comment to D34563: devfs.rules: Do not expose "log" in the default devfs rules..

Ping

May 16 2022, 2:54 AM · Jails

May 5 2022

zlei.huang_gmail.com added a comment to D34934: sbin/devfs: Correct usage.
In D34934#795609, @ngie wrote:

In retrospect, I should have removed/edited the metadata in the commit message. It looks nice on Phabricator, but it looks less nice in raw git/email form.

May 5 2022, 3:49 AM
zlei.huang_gmail.com retitled D35103: ipfw: Support radix tables and table lookup for MAC addresses from Support radix tables and table lookup for MAC addresses to ipfw: Support radix tables and table lookup for MAC addresses.
May 5 2022, 1:54 AM

Apr 27 2022

zlei.huang_gmail.com updated the diff for D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

Protect from concurrent ioctls, and rebase on latest main branch

Apr 27 2022, 5:02 AM · network

Apr 24 2022

zlei.huang_gmail.com added a reviewer for D34934: sbin/devfs: Correct usage: hrs.
Apr 24 2022, 1:38 AM

Apr 16 2022

zlei.huang_gmail.com updated the summary of D34934: sbin/devfs: Correct usage.
Apr 16 2022, 5:13 AM
zlei.huang_gmail.com requested review of D34934: sbin/devfs: Correct usage.
Apr 16 2022, 4:58 AM

Mar 16 2022

zlei.huang_gmail.com requested review of D34577: x86: Correctly report unexpected cache level..
Mar 16 2022, 7:56 AM

Mar 15 2022

zlei.huang_gmail.com requested review of D34563: devfs.rules: Do not expose "log" in the default devfs rules..
Mar 15 2022, 9:27 AM · Jails

Feb 25 2022

zlei.huang_gmail.com added a watcher for Jails: zlei.huang_gmail.com.
Feb 25 2022, 10:02 AM
zlei.huang_gmail.com added a watcher for rust: zlei.huang_gmail.com.
Feb 25 2022, 10:01 AM

Feb 21 2022

zlei.huang_gmail.com updated the summary of D34319: bridge: Don't share broadcast packets.
Feb 21 2022, 6:40 AM

Jan 21 2022

zlei.huang_gmail.com added a comment to D33972: Remove lo(4) comments about interface configuration order..

And for VNET(9) jail, it seems the loopback interface is always configured first.
The behavior is inconsistent with the host.

Jan 21 2022, 7:37 AM · network

Jan 18 2022

zlei.huang_gmail.com added a watcher for network: zlei.huang_gmail.com.
Jan 18 2022, 10:14 AM

Dec 14 2021

zlei.huang_gmail.com updated subscribers of D33274: IPv4: fix redirect sending conditions.
Dec 14 2021, 8:45 AM

Dec 7 2021

zlei.huang_gmail.com added inline comments to D33274: IPv4: fix redirect sending conditions.
Dec 7 2021, 4:15 AM

Dec 1 2021

zlei.huang_gmail.com added a comment to D31868: routing: fix source address selection rules for IPv4 over IPv6..

Hi,
I tested this patch with stable/13 in my home lab for about two weeks without any problems. Any progress will this be merge into stable/13 ?

Dec 1 2021, 1:58 PM
zlei.huang_gmail.com added a comment to D33210: if_epair: Also mark the flag of pair b with IFF_KNOWSEPOCH.
In D33210#750542, @kp wrote:

That was done in 3dd5760aa5f876f8a3f0735afeebdf9ee414e1f5, so I'm a little confused where this comes from.

Dec 1 2021, 1:51 PM · network
zlei.huang_gmail.com requested review of D33210: if_epair: Also mark the flag of pair b with IFF_KNOWSEPOCH.
Dec 1 2021, 12:45 PM · network

Nov 11 2021

zlei.huang_gmail.com added a comment to D32934: jail(8): cleanup jail when not persisting.

What if usr.sbin/jail process exit before a non-persistent jail exit ?

Nov 11 2021, 9:27 AM

Nov 8 2021

zlei.huang_gmail.com added a project to D32887: ifconfig.8: Add the missing option -vlanhwcsum: manpages.
Nov 8 2021, 8:45 AM · manpages
zlei.huang_gmail.com requested review of D32887: ifconfig.8: Add the missing option -vlanhwcsum.
Nov 8 2021, 8:43 AM · manpages

Nov 5 2021

zlei.huang_gmail.com updated the diff for D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

Sorry my bad, resubmit diff as last one include local WIP stashes.

Nov 5 2021, 9:44 AM · network
zlei.huang_gmail.com updated the diff for D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

@bryanv

  1. Removed redundant error initialization.
  2. Moved M_SETFIB(m, sc->vxl_fibnum) out of read lock
Nov 5 2021, 9:39 AM · network

Nov 4 2021

zlei.huang_gmail.com updated the test plan for D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.
Nov 4 2021, 10:35 AM · network
zlei.huang_gmail.com added a comment to D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.
In D32820#741027, @kp wrote:

I'm not familiar with the vxlan code but this does look sane.

Let's give Bryan a few more days, but if he's not had the time for this by let's say Monday ping me to commit this.

Also, if someone would feel called to write a regression test for vxlan in general and this new feature specifically I'd love to see it. Something like the basic test in tests/sys/net/if_vlan.sh would already be valuable. (In fact, when I wrote that test it found a panic in the if_vlan code).

I'm glad to do it, but currently if_vxlan is not VNETified and IIUC it is hard to write a regression test for vxlan right now.

Nov 4 2021, 10:25 AM · network
zlei.huang_gmail.com added a comment to D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

LGTM, ty!
Any chance you can fill in the "testing" section?

Nov 4 2021, 10:03 AM · network
zlei.huang_gmail.com updated the test plan for D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.
Nov 4 2021, 10:01 AM · network
zlei.huang_gmail.com retitled D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB from vxlan: Support socket ioctls SIOC[SG]TUNFIB to vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.
Nov 4 2021, 6:55 AM · network

Nov 3 2021

zlei.huang_gmail.com requested review of D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.
Nov 3 2021, 12:17 PM · network
zlei.huang_gmail.com requested review of D32814: devfs.rules: Correctly unhide pf in vnet jails.
Nov 3 2021, 10:03 AM

Oct 6 2021

zlei.huang_gmail.com abandoned D30811: Correct loopback route for aliases IP addresses.

Abandoned since it works as intended.

Oct 6 2021, 7:47 AM · network

Sep 8 2021

zlei.huang_gmail.com added a comment to D31868: routing: fix source address selection rules for IPv4 over IPv6..

I'm still investing on this issue. As the following case

Sep 8 2021, 6:36 AM

Aug 23 2021

zlei.huang_gmail.com abandoned D31630: Correct nh_family.

I'd rather not touch it now - there is something WIP that will change this part of the code anyway.

Aug 23 2021, 2:45 AM · network
zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

@melifaro Thanks very much!

Aug 23 2021, 2:43 AM · network

Aug 22 2021

zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

Done.

Aug 22 2021, 3:49 PM · network
zlei.huang_gmail.com updated the diff for D30398: Route IPv4 packets via IPv6 next-hops.

Rebased on latest main branch.
Moved down RO_GET_FAMILY()

Aug 22 2021, 3:47 PM · network

Aug 21 2021

zlei.huang_gmail.com requested review of D31630: Correct nh_family.
Aug 21 2021, 3:27 PM · network

Aug 20 2021

zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

Also: will you write a commit message, or do you prefer me doing it?

Aug 20 2021, 3:51 PM · network
zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

You also need to add a bit of family wrapping logic inside fill_nhop_from_info(), so we get a proper family for the nexthop.

Aug 20 2021, 3:36 PM · network
zlei.huang_gmail.com accepted D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..

LGTM

Aug 20 2021, 3:35 PM
zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

.

Aug 20 2021, 3:29 PM · network
zlei.huang_gmail.com updated the diff for D30398: Route IPv4 packets via IPv6 next-hops.

Pass correct AF to nd6_resolve()

Aug 20 2021, 3:26 PM · network
zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

@melifaro Sorry for late response ;)

I removed the LLE part, it should be easy to apply D31379 .

It should be the other way round :-) e.g. D31379 is a pre-requisite.
Could you try to apply it first, build on top and test?

Aug 20 2021, 3:24 PM · network

Aug 18 2021

zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

@melifaro Sorry for late response ;)

I removed the LLE part, it should be easy to apply D31379 .

It should be the other way round :-) e.g. D31379 is a pre-requisite.
Could you try to apply it first, build on top and test?

Aug 18 2021, 10:35 AM · network
zlei.huang_gmail.com updated the diff for D30398: Route IPv4 packets via IPv6 next-hops.

Added feature(3) knob.

Aug 18 2021, 10:33 AM · network
zlei.huang_gmail.com updated the diff for D30398: Route IPv4 packets via IPv6 next-hops.

Cleaned up some comments.

Aug 18 2021, 10:02 AM · network
zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

.

Aug 18 2021, 7:38 AM · network
zlei.huang_gmail.com added inline comments to D30398: Route IPv4 packets via IPv6 next-hops.
Aug 18 2021, 4:48 AM · network
zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

@melifaro Sorry for late response ;)

Aug 18 2021, 4:38 AM · network
zlei.huang_gmail.com updated the diff for D30398: Route IPv4 packets via IPv6 next-hops.

Rebased on latest main branch

Aug 18 2021, 4:35 AM · network

Aug 10 2021

zlei.huang_gmail.com added a comment to D31433: www/node14: Update to 14.17.5.

Update to 17.17.3 (as new www/kibana7 requires this version).

Aug 10 2021, 5:06 AM

Aug 9 2021

zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

I've updated the aforementioned D31379 to reflect the committed parts.
If you could update this review to use the new functionality (e.g. nd6_resolve() returning lle with the proper encap) , that would be awesome.

Aug 9 2021, 3:59 AM · network

Aug 6 2021

zlei.huang_gmail.com added inline comments to D31379: [lltable] Add support for "child" LLEs holding encap for IPv4oIPv6 entries..
Aug 6 2021, 4:42 AM

Jul 30 2021

zlei.huang_gmail.com requested review of D31356: Fix typo in sys/net/route.
Jul 30 2021, 5:16 AM

Jul 28 2021

zlei.huang_gmail.com added inline comments to D29592: Use interface fib instead of RT_DEFAULT_FIB in nd6_ns_output()..
Jul 28 2021, 3:55 AM

Jul 9 2021

zlei.huang_gmail.com updated the diff for D30398: Route IPv4 packets via IPv6 next-hops.

Rework sending queued LLE packets.

Jul 9 2021, 4:29 PM · network

Jun 25 2021

zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

LGTM, I guess the biggest remaining piece now is lle handling, especially sending queued LLE packets upon successful resolution.

Jun 25 2021, 10:57 AM · network
zlei.huang_gmail.com updated the diff for D30398: Route IPv4 packets via IPv6 next-hops.

LGTM, I guess the biggest remaining piece now is lle handling, especially sending queued LLE packets upon successful resolution.

Jun 25 2021, 10:49 AM · network

Jun 21 2021

zlei.huang_gmail.com added a comment to D30811: Correct loopback route for aliases IP addresses.

I think I hit the issue that the useloopback was trying to resolve.

Jun 21 2021, 9:24 AM · network

Jun 19 2021

zlei.huang_gmail.com added a comment to D30811: Correct loopback route for aliases IP addresses.

I'm surprised. There was a discussion about not redirecting /32 on interfaces to loopback. So we see the consequence.

Jun 19 2021, 12:58 PM · network

Jun 18 2021

zlei.huang_gmail.com added inline comments to D30811: Correct loopback route for aliases IP addresses.
Jun 18 2021, 8:07 AM · network
zlei.huang_gmail.com updated the summary of D30811: Correct loopback route for aliases IP addresses.
Jun 18 2021, 8:02 AM · network
zlei.huang_gmail.com updated the test plan for D30811: Correct loopback route for aliases IP addresses.
Jun 18 2021, 7:55 AM · network
zlei.huang_gmail.com added inline comments to D30811: Correct loopback route for aliases IP addresses.
Jun 18 2021, 7:54 AM · network
zlei.huang_gmail.com requested review of D30811: Correct loopback route for aliases IP addresses.
Jun 18 2021, 7:50 AM · network

Jun 15 2021

zlei.huang_gmail.com added inline comments to D30398: Route IPv4 packets via IPv6 next-hops.
Jun 15 2021, 7:38 AM · network
zlei.huang_gmail.com added inline comments to D30398: Route IPv4 packets via IPv6 next-hops.
Jun 15 2021, 7:32 AM · network
zlei.huang_gmail.com added inline comments to D30398: Route IPv4 packets via IPv6 next-hops.
Jun 15 2021, 7:19 AM · network
zlei.huang_gmail.com updated the diff for D30398: Route IPv4 packets via IPv6 next-hops.

Updated as @melifaro suggested.

Jun 15 2021, 7:00 AM · network

Jun 11 2021

zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

Reuse route.ro_dst to get the address family of outbound / forwarded packets.

Jun 11 2021, 11:35 AM · network
zlei.huang_gmail.com updated the diff for D30398: Route IPv4 packets via IPv6 next-hops.
Jun 11 2021, 11:29 AM · network

May 31 2021

zlei.huang_gmail.com added a comment to D30539: tcp, udp: Permit binding with AF_UNSPEC if the address is INADDR_ANY.

Hi Mark,

May 31 2021, 3:54 AM

May 24 2021

zlei.huang_gmail.com added a comment to D30398: Route IPv4 packets via IPv6 next-hops.

First of all, thanks for working on this! This is the important feature we need to have in base, preferably turned on by default.
I'd love to land this.

Glad to get your response !
I'm interested with scalable network, and recently exploring the CLOS network architecture described by RFC 7938. It need large number of IPs and configuration
and BGP unnumbered seems to rescue (RFC 5549).
Thanks your effort on FreeBSD's routing component, it is not too hard to implement such feature in the dataplane :)

I spent some time thinking about the potential implementation option some time ago. Let me try to summarise my thoughts below.

May 24 2021, 10:46 AM · network

May 22 2021

zlei.huang_gmail.com requested review of D30398: Route IPv4 packets via IPv6 next-hops.
May 22 2021, 9:38 AM · network

May 21 2021

zlei.huang_gmail.com added a comment to D30374: Restore RFC reference.

FreeBSD src repository favors detailed commit message. I'm not sure if it is sufficient. Suggestions are welcomed :)

May 21 2021, 8:36 AM
zlei.huang_gmail.com requested review of D30374: Restore RFC reference.
May 21 2021, 6:43 AM

May 19 2021

zlei.huang_gmail.com added a comment to D29968: Do not forward datagrams original from 169.254.0.0/16 link-local addresses.

Thanks @donner :)

May 19 2021, 6:44 AM · network

May 17 2021

zlei.huang_gmail.com added a comment to D29968: Do not forward datagrams original from 169.254.0.0/16 link-local addresses.

Hi, since I do not have access to the src repository, could someone check in the diff please ?

May 17 2021, 10:46 AM · network
zlei.huang_gmail.com added a comment to D29968: Do not forward datagrams original from 169.254.0.0/16 link-local addresses.

Friendly ping @donner , there're changes since your first acceptance, do you have any objections?

May 17 2021, 9:53 AM · network

Apr 30 2021

zlei.huang_gmail.com updated the summary of D30042: traceroute6: Properly calculate UDP checksum.
Apr 30 2021, 9:22 AM
zlei.huang_gmail.com requested review of D30042: traceroute6: Properly calculate UDP checksum.
Apr 30 2021, 9:14 AM