- User Since
- Mar 10 2018, 1:54 AM (40 w, 14 h)
Wed, Dec 12
Many thanks for the thorough review.
Does it look good enough for commit now?
Thanks a lot for the review! I should have fixed the issue you spotted.
Applied reviewer's suggestions.
Tue, Dec 11
Mon, Dec 10
Fixed some compilation warnings.
This regression test suite is also run on Linux for continuous integration (see the travis page for more details https://travis-ci.org/netmap-unipi/netmap) and manual tests.
The compatibility with Linux is the the reason why it is a plain C program, so that I don't have two maintain two versions of the same test suite.
Addressed reviewers' comments.
Sun, Dec 9
Thu, Dec 6
Changes already included in r341477
Wed, Dec 5
You're right. I realized that just now.
Import bug fix from upstream.
Sun, Dec 2
Add support for nm_config
Forgot to upload updated patch.
Sat, Dec 1
Wed, Nov 28
Tue, Nov 27
The truth is that netmap not setting the IFCAP_NETMAP flag in ifp->if_capabilities after r307394 is a mistake that we did not notice so far.
It got introduced by refactoring, 3 years ago (see https://github.com/luigirizzo/netmap/commit/5d0796f93a1107eb14422c7b8ea416f7fd750a2e).
Sorry for that, it was unintended.
I just happened to notice that and fix it.
Mon, Nov 26
Tue, Nov 20
Sat, Nov 17
Add back $FreeBSD$ strings
Fri, Nov 16
Short and sweet but I need to wait for the mentors :)
Nov 14 2018
Nov 13 2018
In any case I plan to import the current github into stable/11 soon, since the current stable/11, to stabilize it.
Nov 12 2018
I'm sorry, but as a design decision for netmap we never automatically change interface features/offloading automatically and restore them.
We require the application or the system administrator to do so explicitely.
In any case this must be discussed with the upstream project https://github.com/luigirizzo/netmap
Added assertions for sglist_append().
Nov 11 2018
Added DEV_NETMAP in if_vtnetvar.h
Provided full diff context.
I'm sorry, how can I generate full diff context with SVN? I cannot find the right command...
Nov 10 2018
Renamed "onoff" --> "state", as suggested by reviewers.
Nov 9 2018
Add missing update to if_vtnetvar.h
Remove dependency on commit r340279.
Nov 8 2018
Il giorno gio 8 nov 2018 alle ore 16:43 bwicht_verisign.com (Baptiste
Wicht) <firstname.lastname@example.org> ha scritto:
Nov 7 2018
The changes to netmap_kern.h look very good, thanks.
Nov 6 2018
Is there anything I can do to progress on this?
Oct 31 2018
- Is a good idea, thanks.
Flushing unsubmitted comments
Thanks for the suggestions.
I did not implement two of the suggested changes, see inline.
igor and mandoc -Tlint report zero errors
Thanks for the review. However, I need to commit this https://reviews.freebsd.org/D17698 first.
Thanks! I did not get you wanted the ":" bold.
Is the man page looking better now?
Oct 29 2018
Implemented the changes suggested by the reviewers.
@0mp does man page look better now?
Oct 28 2018
Minor fixes to the man pages.
This patch depends on https://reviews.freebsd.org/D17698 , because of the changes to ctrs.h.
Oct 25 2018
Addressed reviewer's comments.
pkt-gen man page and usage() cleaned up to reflect the real options.
Some old/unused/obsolete options have been removed.
You are right, I'm updating the man page. This will take a while :)
I will, thanks!
Oct 24 2018
Sure, no problems. I don't think it's a good idea to sort them alphabetically, because right now they are laid out in such a way to have semantically related operations close to each other.
For instance -d, -a and -h are detach/attach/attach-with-host, -n and -r are "create" and "remove", etc.
Oct 23 2018
Thanks for the suggestions! I'm new to the process.
Updated .Dd lines in related man pages.
Done changes requested by 0mp.
Oct 22 2018
Can we commit this? Thanks
Oct 6 2018
I sent the patch to email@example.com
Oct 4 2018
Thanks for the suggestion. I ran both igor and mandoc -Tlint and now they don't output any warning or error.
Fixed warning originated from mandoc -Tlint
Fixed the examples, as there were inconsistencies
Oct 1 2018
Integration tests and unit tests ran successfully on my test machine.