Page MenuHomeFreeBSD

v.maffione_gmail.com (Vincenzo Maffione)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2018, 1:54 AM (40 w, 14 h)

Recent Activity

Wed, Dec 12

v.maffione_gmail.com added a comment to D18490: netmap: add suite of unit tests.

Hi,

Many thanks for the thorough review.

Does it look good enough for commit now?

Wed, Dec 12, 4:20 PM
v.maffione_gmail.com added a comment to D18518: netmap: add man page for ptnet.

Thanks a lot for the review! I should have fixed the issue you spotted.

Wed, Dec 12, 4:17 PM
v.maffione_gmail.com updated the diff for D18518: netmap: add man page for ptnet.

Applied reviewer's suggestions.

Wed, Dec 12, 4:16 PM

Tue, Dec 11

v.maffione_gmail.com created D18518: netmap: add man page for ptnet.
Tue, Dec 11, 9:51 PM

Mon, Dec 10

v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

(errata)

Mon, Dec 10, 2:57 PM
v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

Fixed some compilation warnings.

Mon, Dec 10, 2:55 PM
v.maffione_gmail.com added a comment to D18490: netmap: add suite of unit tests.

This regression test suite is also run on Linux for continuous integration (see the travis page for more details https://travis-ci.org/netmap-unipi/netmap) and manual tests.
The compatibility with Linux is the the reason why it is a plain C program, so that I don't have two maintain two versions of the same test suite.

Mon, Dec 10, 10:39 AM
v.maffione_gmail.com updated the summary of D18490: netmap: add suite of unit tests.
Mon, Dec 10, 10:34 AM
v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

Addressed reviewers' comments.

Mon, Dec 10, 10:31 AM
v.maffione_gmail.com added inline comments to D18490: netmap: add suite of unit tests.
Mon, Dec 10, 10:31 AM

Sun, Dec 9

v.maffione_gmail.com added reviewers for D18490: netmap: add suite of unit tests: asomers, ngie.
Sun, Dec 9, 2:26 PM
v.maffione_gmail.com created D18490: netmap: add suite of unit tests.
Sun, Dec 9, 2:22 PM

Thu, Dec 6

v.maffione_gmail.com added a reviewer for D17896: netmap: netmap_transmit should honor bpf packet tap hook.: gnn.
Thu, Dec 6, 9:33 AM
v.maffione_gmail.com closed D17921: stable/11: backport netmap fixes from master to prevent panic.

Changes already included in r341477

Thu, Dec 6, 8:49 AM

Wed, Dec 5

v.maffione_gmail.com added a comment to D18402: netmap: ixgbe: add support for jumbo frames.

You're right. I realized that just now.

Wed, Dec 5, 4:31 PM
v.maffione_gmail.com created D18436: tools: netmap: pkt-gen: check packet length against interface MTU.
Wed, Dec 5, 3:45 PM
v.maffione_gmail.com updated the diff for D18015: netmap: align codebase to the current upstream (sha afa26bc3bc416).

Import bug fix from upstream.

Wed, Dec 5, 11:48 AM

Sun, Dec 2

v.maffione_gmail.com added reviewers for D18402: netmap: ixgbe: add support for jumbo frames: imp, sbruno, gnn, hrs.
Sun, Dec 2, 11:19 AM
v.maffione_gmail.com updated the diff for D18402: netmap: ixgbe: add support for jumbo frames.

Add support for nm_config

Sun, Dec 2, 11:15 AM
v.maffione_gmail.com updated the diff for D18402: netmap: ixgbe: add support for jumbo frames.

Minor fix.

Sun, Dec 2, 10:29 AM
v.maffione_gmail.com updated the diff for D18402: netmap: ixgbe: add support for jumbo frames.

Forgot to upload updated patch.

Sun, Dec 2, 8:42 AM

Sat, Dec 1

v.maffione_gmail.com updated the diff for D18402: netmap: ixgbe: add support for jumbo frames.

Minor fixes.

Sat, Dec 1, 6:48 PM
v.maffione_gmail.com created D18402: netmap: ixgbe: add support for jumbo frames.
Sat, Dec 1, 6:16 PM

Wed, Nov 28

v.maffione_gmail.com added a comment to D18057: netmap(4): improve man page.

@gnn @hrs any objections to this simple cleanup?

Wed, Nov 28, 3:42 PM
v.maffione_gmail.com added a comment to D17987: netmap: set IFCAP_NETMAP in if_capabilities.

Sounds good, that's a better approach. I'll do it as soon as @gnn or @hrs approve.

Wed, Nov 28, 9:15 AM

Tue, Nov 27

v.maffione_gmail.com added a comment to D17987: netmap: set IFCAP_NETMAP in if_capabilities.

The truth is that netmap not setting the IFCAP_NETMAP flag in ifp->if_capabilities after r307394 is a mistake that we did not notice so far.
It got introduced by refactoring, 3 years ago (see https://github.com/luigirizzo/netmap/commit/5d0796f93a1107eb14422c7b8ea416f7fd750a2e).
Sorry for that, it was unintended.
I just happened to notice that and fix it.

Tue, Nov 27, 11:16 AM

Mon, Nov 26

v.maffione_gmail.com added a reviewer for D17987: netmap: set IFCAP_NETMAP in if_capabilities: jhb.
Mon, Nov 26, 10:24 AM

Tue, Nov 20

v.maffione_gmail.com created D18057: netmap(4): improve man page.
Tue, Nov 20, 11:19 AM

Sat, Nov 17

v.maffione_gmail.com updated the diff for D18015: netmap: align codebase to the current upstream (sha afa26bc3bc416).

Add back $FreeBSD$ strings

Sat, Nov 17, 1:52 PM
v.maffione_gmail.com created D18015: netmap: align codebase to the current upstream (sha afa26bc3bc416).
Sat, Nov 17, 1:46 PM

Fri, Nov 16

v.maffione_gmail.com updated the summary of D17988: ifnet(9): Add description of IFCAP_NETMAP.
Fri, Nov 16, 10:01 AM
v.maffione_gmail.com added a comment to D17988: ifnet(9): Add description of IFCAP_NETMAP.

Short and sweet but I need to wait for the mentors :)

Fri, Nov 16, 10:00 AM

Nov 14 2018

v.maffione_gmail.com added reviewers for D17988: ifnet(9): Add description of IFCAP_NETMAP: gnn, hrs.
Nov 14 2018, 4:44 PM
v.maffione_gmail.com created D17988: ifnet(9): Add description of IFCAP_NETMAP.
Nov 14 2018, 4:43 PM
v.maffione_gmail.com created D17987: netmap: set IFCAP_NETMAP in if_capabilities.
Nov 14 2018, 4:09 PM

Nov 13 2018

v.maffione_gmail.com accepted D17921: stable/11: backport netmap fixes from master to prevent panic.

LGTM
In any case I plan to import the current github into stable/11 soon, since the current stable/11, to stabilize it.

Nov 13 2018, 9:20 AM
v.maffione_gmail.com accepted D17896: netmap: netmap_transmit should honor bpf packet tap hook..
Nov 13 2018, 9:13 AM
v.maffione_gmail.com added inline comments to D17916: vtnet: fix netmap support.
Nov 13 2018, 9:07 AM

Nov 12 2018

v.maffione_gmail.com added inline comments to D17916: vtnet: fix netmap support.
Nov 12 2018, 2:36 PM
v.maffione_gmail.com added inline comments to D17896: netmap: netmap_transmit should honor bpf packet tap hook..
Nov 12 2018, 9:55 AM
v.maffione_gmail.com added a comment to D17910: netmap: automatically disable some capabilities over vlan interface.

I'm sorry, but as a design decision for netmap we never automatically change interface features/offloading automatically and restore them.
We require the application or the system administrator to do so explicitely.
In any case this must be discussed with the upstream project https://github.com/luigirizzo/netmap

Nov 12 2018, 9:48 AM
v.maffione_gmail.com added inline comments to D17916: vtnet: fix netmap support.
Nov 12 2018, 9:32 AM
v.maffione_gmail.com updated the diff for D17916: vtnet: fix netmap support.

Added assertions for sglist_append().
Fixed indentation.

Nov 12 2018, 9:31 AM

Nov 11 2018

v.maffione_gmail.com updated the diff for D17916: vtnet: fix netmap support.

Added DEV_NETMAP in if_vtnetvar.h
Provided full diff context.

Nov 11 2018, 10:30 AM
v.maffione_gmail.com added a comment to D17916: vtnet: fix netmap support.

I'm sorry, how can I generate full diff context with SVN? I cannot find the right command...

Nov 11 2018, 10:27 AM

Nov 10 2018

v.maffione_gmail.com added a comment to D17916: vtnet: fix netmap support.
Nov 10 2018, 3:26 PM
v.maffione_gmail.com updated the diff for D17916: vtnet: fix netmap support.

Renamed "onoff" --> "state", as suggested by reviewers.

Nov 10 2018, 3:20 PM

Nov 9 2018

v.maffione_gmail.com updated the diff for D17916: vtnet: fix netmap support.

Add missing update to if_vtnetvar.h

Nov 9 2018, 9:32 AM
v.maffione_gmail.com created D17916: vtnet: fix netmap support.
Nov 9 2018, 9:07 AM
v.maffione_gmail.com updated the diff for D17698: netmap: pkt-gen: several updates from upstream.

Remove dependency on commit r340279.

Nov 9 2018, 8:51 AM

Nov 8 2018

v.maffione_gmail.com added a comment to D17868: cxgbe netmap: Micro optimizations of the rxsync function.

Il giorno gio 8 nov 2018 alle ore 16:43 bwicht_verisign.com (Baptiste
Wicht) <phabric-noreply@freebsd.org> ha scritto:

Nov 8 2018, 3:45 PM

Nov 7 2018

v.maffione_gmail.com accepted D17868: cxgbe netmap: Micro optimizations of the rxsync function.

The changes to netmap_kern.h look very good, thanks.

Nov 7 2018, 10:28 AM

Nov 6 2018

v.maffione_gmail.com added a comment to D17698: netmap: pkt-gen: several updates from upstream.

Is there anything I can do to progress on this?

Nov 6 2018, 10:10 AM

Oct 31 2018

v.maffione_gmail.com added a comment to D17698: netmap: pkt-gen: several updates from upstream.
  1. Is a good idea, thanks.
Oct 31 2018, 4:24 PM
v.maffione_gmail.com updated the diff for D17698: netmap: pkt-gen: several updates from upstream.
Oct 31 2018, 4:22 PM
v.maffione_gmail.com added a comment to D17698: netmap: pkt-gen: several updates from upstream.

Flushing unsubmitted comments

Oct 31 2018, 3:37 PM
v.maffione_gmail.com updated the diff for D17698: netmap: pkt-gen: several updates from upstream.

Thanks for the suggestions.
I did not implement two of the suggested changes, see inline.
igor and mandoc -Tlint report zero errors

Oct 31 2018, 3:36 PM
v.maffione_gmail.com added a comment to D17735: netmap: add load balancer program.

Thanks for the review. However, I need to commit this https://reviews.freebsd.org/D17698 first.

Oct 31 2018, 2:37 PM
v.maffione_gmail.com updated the diff for D17735: netmap: add load balancer program.

Thanks! I did not get you wanted the ":" bold.

Oct 31 2018, 2:35 PM
v.maffione_gmail.com added a comment to D17735: netmap: add load balancer program.

Is the man page looking better now?

Oct 31 2018, 2:17 PM

Oct 29 2018

v.maffione_gmail.com updated the diff for D17735: netmap: add load balancer program.

Implemented the changes suggested by the reviewers.

Oct 29 2018, 3:40 PM
v.maffione_gmail.com added a comment to D17698: netmap: pkt-gen: several updates from upstream.

@0mp does man page look better now?

Oct 29 2018, 1:24 PM

Oct 28 2018

v.maffione_gmail.com updated the diff for D17735: netmap: add load balancer program.

Minor fixes to the man pages.

Oct 28 2018, 8:52 AM
v.maffione_gmail.com added a comment to D17735: netmap: add load balancer program.

This patch depends on https://reviews.freebsd.org/D17698 , because of the changes to ctrs.h.

Oct 28 2018, 8:41 AM
v.maffione_gmail.com created D17735: netmap: add load balancer program.
Oct 28 2018, 8:40 AM

Oct 25 2018

v.maffione_gmail.com updated the diff for D17698: netmap: pkt-gen: several updates from upstream.

Addressed reviewer's comments.
pkt-gen man page and usage() cleaned up to reflect the real options.
Some old/unused/obsolete options have been removed.

Oct 25 2018, 3:54 PM
v.maffione_gmail.com added a comment to D17698: netmap: pkt-gen: several updates from upstream.

You are right, I'm updating the man page. This will take a while :)

Oct 25 2018, 2:08 PM
v.maffione_gmail.com added a comment to D17698: netmap: pkt-gen: several updates from upstream.

I will, thanks!

Oct 25 2018, 12:48 PM
v.maffione_gmail.com created D17698: netmap: pkt-gen: several updates from upstream.
Oct 25 2018, 10:31 AM

Oct 24 2018

v.maffione_gmail.com added a comment to D17683: netmap: add man page for the vale-ctl program.

Sure, no problems. I don't think it's a good idea to sort them alphabetically, because right now they are laid out in such a way to have semantically related operations close to each other.
For instance -d, -a and -h are detach/attach/attach-with-host, -n and -r are "create" and "remove", etc.

Oct 24 2018, 3:17 PM
v.maffione_gmail.com added inline comments to D17683: netmap: add man page for the vale-ctl program.
Oct 24 2018, 2:30 PM
v.maffione_gmail.com created D17683: netmap: add man page for the vale-ctl program.
Oct 24 2018, 9:49 AM

Oct 23 2018

v.maffione_gmail.com added a comment to D17664: netmap: add man page for the bridge program.

Thanks!

Oct 23 2018, 3:35 PM
v.maffione_gmail.com updated the diff for D17664: netmap: add man page for the bridge program.

Thanks for the suggestions! I'm new to the process.
Updated .Dd lines in related man pages.

Oct 23 2018, 10:28 AM
v.maffione_gmail.com updated the diff for D17664: netmap: add man page for the bridge program.

Done changes requested by 0mp.

Oct 23 2018, 10:15 AM
v.maffione_gmail.com created D17664: netmap: add man page for the bridge program.
Oct 23 2018, 9:25 AM

Oct 22 2018

v.maffione_gmail.com added a comment to D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941).

Can we commit this? Thanks

Oct 22 2018, 8:38 AM

Oct 6 2018

v.maffione_gmail.com added a comment to D17411: man: fix vale(4) port naming.

Thanks!
I sent the patch to re@freebsd.org

Oct 6 2018, 8:03 AM

Oct 4 2018

v.maffione_gmail.com added a comment to D17411: man: fix vale(4) port naming.

@bcr
Thanks for the suggestion. I ran both igor and mandoc -Tlint and now they don't output any warning or error.

Oct 4 2018, 8:23 PM
v.maffione_gmail.com updated the diff for D17411: man: fix vale(4) port naming.

Fixed warning originated from mandoc -Tlint

Oct 4 2018, 8:21 PM
v.maffione_gmail.com updated the diff for D17411: man: fix vale(4) port naming.

Fixed the examples, as there were inconsistencies

Oct 4 2018, 8:16 PM
v.maffione_gmail.com created D17411: man: fix vale(4) port naming.
Oct 4 2018, 3:55 PM

Oct 1 2018

v.maffione_gmail.com added a comment to D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941).

Integration tests and unit tests ran successfully on my test machine.

Oct 1 2018, 9:36 AM
v.maffione_gmail.com added inline comments to D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941).
Oct 1 2018, 8:22 AM
v.maffione_gmail.com updated the diff for D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941).
Oct 1 2018, 8:20 AM

Sep 30 2018

v.maffione_gmail.com created D17364: netmap: align codebase to the current upstream (commit id 8374e1a7e6941).
Sep 30 2018, 3:06 PM