Page MenuHomeFreeBSD

v.maffione_gmail.com (Vincenzo Maffione)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 10 2018, 1:54 AM (50 w, 1 h)

Recent Activity

Mon, Feb 18

v.maffione_gmail.com accepted D19104: vmxnet3: add native netmap support.
Mon, Feb 18, 4:14 PM
v.maffione_gmail.com accepted D19104: vmxnet3: add native netmap support.
Mon, Feb 18, 2:11 PM
v.maffione_gmail.com added a comment to D19177: netmap: don't schedule kqueue notify task when kqueue is not used.

No worries, and thanks for testing!

Mon, Feb 18, 1:54 PM

Thu, Feb 14

v.maffione_gmail.com added a comment to D19177: netmap: don't schedule kqueue notify task when kqueue is not used.

Thanks.
In my tests I can see that without the patch, two pkt-gen communicating over a VALE port will consume 9% CPU on kqueue processing (although kqueue is not used), on a separate CPU.
With the patch, the 9% goes away.

Thu, Feb 14, 8:22 AM

Wed, Feb 13

v.maffione_gmail.com added a comment to D19177: netmap: don't schedule kqueue notify task when kqueue is not used.

We can't. We use a taskqueue there precisely because we cannot take the si->m lock (or we get LOR).

Wed, Feb 13, 8:41 PM
v.maffione_gmail.com retitled D19177: netmap: don't schedule kqueue notify task when kqueue is not used from netmap: don't schedule kqueue notify task when kqueue is used to netmap: don't schedule kqueue notify task when kqueue is not used.
Wed, Feb 13, 9:52 AM
v.maffione_gmail.com created D19177: netmap: don't schedule kqueue notify task when kqueue is not used.
Wed, Feb 13, 9:51 AM

Thu, Feb 7

v.maffione_gmail.com added inline comments to D19104: vmxnet3: add native netmap support.
Thu, Feb 7, 2:51 PM
v.maffione_gmail.com added a comment to D19104: vmxnet3: add native netmap support.

It would probably help to have more lines of contexts for the patch.
If you used git, you should probably use something like:

`
git diff -U30 [...]
`

If you used svn

`
svn diff -x '-U30'
`
Thu, Feb 7, 2:06 PM

Wed, Jan 30

v.maffione_gmail.com added a comment to D18956: netmap: fix lock order reversal related to kqueue usage (v2).

Thanks for testing.

Wed, Jan 30, 3:32 PM
v.maffione_gmail.com updated the summary of D18956: netmap: fix lock order reversal related to kqueue usage (v2).
Wed, Jan 30, 10:24 AM

Tue, Jan 29

v.maffione_gmail.com added a comment to D18984: ixl: remove unnecessary limitations related to netmap.

Thanks!
It looks like reading the the HEAD of the first TX ring works, while the other TX rings don't...

Tue, Jan 29, 6:10 PM
v.maffione_gmail.com added a reviewer for D18956: netmap: fix lock order reversal related to kqueue usage (v2): g.lettieri_iet.unipi.it.
Tue, Jan 29, 3:21 PM
v.maffione_gmail.com updated the diff for D18956: netmap: fix lock order reversal related to kqueue usage (v2).

knote() notification work deferred to a per-selinfo taskqueue

Tue, Jan 29, 3:19 PM
v.maffione_gmail.com created D19015: vtnet: fix typo in vtnet_free_taskqueues.
Tue, Jan 29, 10:32 AM
v.maffione_gmail.com added a comment to D18956: netmap: fix lock order reversal related to kqueue usage (v2).

That's convincing, thanks. I will try to switch to a per-netmap-adapter private taskqueue, to avoid locking contention on the same taskqueue.

Tue, Jan 29, 9:02 AM

Mon, Jan 28

v.maffione_gmail.com abandoned D18952: netmap: fix lock order reversal related to kqueue usage.

Obsoleted by https://reviews.freebsd.org/D18956

Mon, Jan 28, 1:28 PM
v.maffione_gmail.com added a comment to D18956: netmap: fix lock order reversal related to kqueue usage (v2).

I went for reusing a system-wide taskqueue because the work to be done is minimal (i.e. it is not something like processing a number of descriptors in a device queue, or a list of packets, etc.).
However, if you think it's better to use a netmap-wide taskqueue for this, we can go for it.
Are you worried about something in particular, w.r.t. the current approach?

Mon, Jan 28, 1:28 PM
v.maffione_gmail.com added a comment to D18956: netmap: fix lock order reversal related to kqueue usage (v2).

Thanks for testing.
I think this is safe to commit.

Mon, Jan 28, 11:43 AM
v.maffione_gmail.com added a comment to D18984: ixl: remove unnecessary limitations related to netmap.

No problems!
Actually some people is experiencing problems when using netmap on ixl (see related PR), so I would like to understand what is going on...

Mon, Jan 28, 10:51 AM

Sat, Jan 26

v.maffione_gmail.com updated subscribers of D18984: ixl: remove unnecessary limitations related to netmap.
Sat, Jan 26, 6:33 PM
v.maffione_gmail.com updated the diff for D18984: ixl: remove unnecessary limitations related to netmap.

Sanitize the value of the hw head index read at the end of the TX ring.

Sat, Jan 26, 6:29 PM
v.maffione_gmail.com retitled D18984: ixl: remove unnecessary limitations related to netmap from ixl: clean up to ixl: remove unnecessary limitations related to netmap.
Sat, Jan 26, 6:18 PM
v.maffione_gmail.com added a reviewer for D18984: ixl: remove unnecessary limitations related to netmap: erj.
Sat, Jan 26, 6:16 PM
v.maffione_gmail.com created D18984: ixl: remove unnecessary limitations related to netmap.
Sat, Jan 26, 6:14 PM

Fri, Jan 25

v.maffione_gmail.com added a comment to D18952: netmap: fix lock order reversal related to kqueue usage.

Thanks for testing. So this seems to work.
However, introducing a global lock is not the best approach for performance reasons. I tried to came up with a different approach that also allows us to get rid of the mtx_owned() call.
See https://reviews.freebsd.org/D18956

Fri, Jan 25, 5:16 PM
v.maffione_gmail.com added a reviewer for D18956: netmap: fix lock order reversal related to kqueue usage (v2): aleksandr.fedorov_itglobal.com.
Fri, Jan 25, 5:14 PM
v.maffione_gmail.com created D18956: netmap: fix lock order reversal related to kqueue usage (v2).
Fri, Jan 25, 5:13 PM
v.maffione_gmail.com created D18952: netmap: fix lock order reversal related to kqueue usage.
Fri, Jan 25, 9:32 AM

Thu, Jan 24

v.maffione_gmail.com added a comment to D18876: netmap: fix knote() argument to match the mutex state.

I could not reproduce your issue, but this patch may be useful to match the actual locks involved against the corresponding netmap ports.

Thu, Jan 24, 5:11 PM
v.maffione_gmail.com added a comment to D18876: netmap: fix knote() argument to match the mutex state.

Thanks for reporting. Also the code sample can be useful to add some unit tests for kqueue.

Thu, Jan 24, 2:32 PM

Jan 23 2019

v.maffione_gmail.com updated the diff for D18876: netmap: fix knote() argument to match the mutex state.

Uploading diff with some context (-U 100).

Jan 23 2019, 11:40 AM
v.maffione_gmail.com updated the diff for D18876: netmap: fix knote() argument to match the mutex state.

Fixed indentation as suggested.

Jan 23 2019, 11:38 AM

Jan 21 2019

v.maffione_gmail.com added a comment to D18876: netmap: fix knote() argument to match the mutex state.

That's another interesting question.
It looks like it was added to support the case where multiple threads poll() on the same netmap port. In that case, one of the thread performs the actual TXSYNC or RXSYNC, and if some work was actually performed (e.g. ring indices were advanced) the thread will call nm_notify() to wake up all the other threads.

Jan 21 2019, 5:24 PM
v.maffione_gmail.com added a comment to D18876: netmap: fix knote() argument to match the mutex state.

Thanks for the explanation. Yes, I understand that this use of f_event is unusual, and I see your point.

Jan 21 2019, 9:10 AM

Jan 18 2019

v.maffione_gmail.com added a comment to D18876: netmap: fix knote() argument to match the mutex state.

Thanks a lot!

Jan 18 2019, 3:26 PM
v.maffione_gmail.com added a comment to D18876: netmap: fix knote() argument to match the mutex state.

Added @markj to possibly answer the question about calling KNOTE() in f_event.

Jan 18 2019, 1:43 PM
v.maffione_gmail.com added a reviewer for D18876: netmap: fix knote() argument to match the mutex state: markj.
Jan 18 2019, 1:43 PM
v.maffione_gmail.com added a comment to D18876: netmap: fix knote() argument to match the mutex state.

Thanks a lot for testing! Yes, a lot of comments looked really inconsistent with the code. I did some more consistent update.
It would be great if you could run your tests again, since I've done a small code change in netmap_knrw().

Jan 18 2019, 10:57 AM
v.maffione_gmail.com updated the diff for D18876: netmap: fix knote() argument to match the mutex state.

Cleanup comments related to kqueue.

Jan 18 2019, 10:52 AM

Jan 17 2019

v.maffione_gmail.com created D18876: netmap: fix knote() argument to match the mutex state.
Jan 17 2019, 5:19 PM

Dec 31 2018

v.maffione_gmail.com added a comment to D18490: netmap: add suite of unit tests.

Thank you very much for your thorough review!
I will try to convert that to a TAP test, and ask for help if I find obstacles.

Dec 31 2018, 11:19 AM

Dec 24 2018

v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

Formatted .dist file.

Dec 24 2018, 3:56 PM

Dec 23 2018

v.maffione_gmail.com added a comment to D18490: netmap: add suite of unit tests.

Any more comments? Can I go ahead and commit this?
Thanks

Dec 23 2018, 10:18 AM

Dec 21 2018

v.maffione_gmail.com added a comment to D18629: netmap: update nmreplay(8).

Thanks for the quick reply!

Dec 21 2018, 2:43 PM
v.maffione_gmail.com added a reviewer for D18629: netmap: update nmreplay(8): gnn.
Dec 21 2018, 2:14 PM
v.maffione_gmail.com created D18629: netmap: update nmreplay(8).
Dec 21 2018, 2:14 PM

Dec 19 2018

v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

Make sure av[] on-stack arrays do not overflow.

Dec 19 2018, 9:17 AM
v.maffione_gmail.com added a comment to D18490: netmap: add suite of unit tests.

Sounds good.
In case netmap is not available, you should get something similar

`
Executing command: ifconfig create tap7361 up
==> Start of Test #1 [port_info_get]
open(/dev/netmap): No such file or directory
Executing command: ifconfig destroy tap7361
`
Dec 19 2018, 9:16 AM

Dec 17 2018

v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

Improve extmem tests.

Dec 17 2018, 2:00 PM
v.maffione_gmail.com added inline comments to D18490: netmap: add suite of unit tests.
Dec 17 2018, 2:00 PM

Dec 16 2018

v.maffione_gmail.com added inline comments to D18490: netmap: add suite of unit tests.
Dec 16 2018, 5:56 PM
v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

Addressed more reviewer's comments.

Dec 16 2018, 5:39 PM
v.maffione_gmail.com added inline comments to D18490: netmap: add suite of unit tests.
Dec 16 2018, 5:38 PM
v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

Addressed more reviewer's comments.

Dec 16 2018, 4:30 PM
v.maffione_gmail.com added inline comments to D18490: netmap: add suite of unit tests.
Dec 16 2018, 4:30 PM

Dec 12 2018

v.maffione_gmail.com added a comment to D18490: netmap: add suite of unit tests.

Hi,

Many thanks for the thorough review.

Does it look good enough for commit now?

Dec 12 2018, 4:20 PM
v.maffione_gmail.com added a comment to D18518: netmap: add man page for ptnet.

Thanks a lot for the review! I should have fixed the issue you spotted.

Dec 12 2018, 4:17 PM
v.maffione_gmail.com updated the diff for D18518: netmap: add man page for ptnet.

Applied reviewer's suggestions.

Dec 12 2018, 4:16 PM

Dec 11 2018

v.maffione_gmail.com created D18518: netmap: add man page for ptnet.
Dec 11 2018, 9:51 PM

Dec 10 2018

v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

(errata)

Dec 10 2018, 2:57 PM
v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

Fixed some compilation warnings.

Dec 10 2018, 2:55 PM
v.maffione_gmail.com added a comment to D18490: netmap: add suite of unit tests.

This regression test suite is also run on Linux for continuous integration (see the travis page for more details https://travis-ci.org/netmap-unipi/netmap) and manual tests.
The compatibility with Linux is the the reason why it is a plain C program, so that I don't have two maintain two versions of the same test suite.

Dec 10 2018, 10:39 AM
v.maffione_gmail.com updated the summary of D18490: netmap: add suite of unit tests.
Dec 10 2018, 10:34 AM
v.maffione_gmail.com updated the diff for D18490: netmap: add suite of unit tests.

Addressed reviewers' comments.

Dec 10 2018, 10:31 AM
v.maffione_gmail.com added inline comments to D18490: netmap: add suite of unit tests.
Dec 10 2018, 10:31 AM

Dec 9 2018

v.maffione_gmail.com added reviewers for D18490: netmap: add suite of unit tests: asomers, ngie.
Dec 9 2018, 2:26 PM
v.maffione_gmail.com created D18490: netmap: add suite of unit tests.
Dec 9 2018, 2:22 PM

Dec 6 2018

v.maffione_gmail.com added a reviewer for D17896: netmap: netmap_transmit should honor bpf packet tap hook.: gnn.
Dec 6 2018, 9:33 AM
v.maffione_gmail.com closed D17921: stable/11: backport netmap fixes from master to prevent panic.

Changes already included in r341477

Dec 6 2018, 8:49 AM

Dec 5 2018

v.maffione_gmail.com added a comment to D18402: netmap: ixgbe: add support for jumbo frames.

You're right. I realized that just now.

Dec 5 2018, 4:31 PM
v.maffione_gmail.com created D18436: tools: netmap: pkt-gen: check packet length against interface MTU.
Dec 5 2018, 3:45 PM
v.maffione_gmail.com updated the diff for D18015: netmap: align codebase to the current upstream (sha afa26bc3bc416).

Import bug fix from upstream.

Dec 5 2018, 11:48 AM

Dec 2 2018

v.maffione_gmail.com added reviewers for D18402: netmap: ixgbe: add support for jumbo frames: imp, sbruno, gnn, hrs.
Dec 2 2018, 11:19 AM
v.maffione_gmail.com updated the diff for D18402: netmap: ixgbe: add support for jumbo frames.

Add support for nm_config

Dec 2 2018, 11:15 AM
v.maffione_gmail.com updated the diff for D18402: netmap: ixgbe: add support for jumbo frames.

Minor fix.

Dec 2 2018, 10:29 AM
v.maffione_gmail.com updated the diff for D18402: netmap: ixgbe: add support for jumbo frames.

Forgot to upload updated patch.

Dec 2 2018, 8:42 AM

Dec 1 2018

v.maffione_gmail.com updated the diff for D18402: netmap: ixgbe: add support for jumbo frames.

Minor fixes.

Dec 1 2018, 6:48 PM
v.maffione_gmail.com created D18402: netmap: ixgbe: add support for jumbo frames.
Dec 1 2018, 6:16 PM

Nov 28 2018

v.maffione_gmail.com added a comment to D18057: netmap(4): improve man page.

@gnn @hrs any objections to this simple cleanup?

Nov 28 2018, 3:42 PM
v.maffione_gmail.com added a comment to D17987: netmap: set IFCAP_NETMAP in if_capabilities.

Sounds good, that's a better approach. I'll do it as soon as @gnn or @hrs approve.

Nov 28 2018, 9:15 AM

Nov 27 2018

v.maffione_gmail.com added a comment to D17987: netmap: set IFCAP_NETMAP in if_capabilities.

The truth is that netmap not setting the IFCAP_NETMAP flag in ifp->if_capabilities after r307394 is a mistake that we did not notice so far.
It got introduced by refactoring, 3 years ago (see https://github.com/luigirizzo/netmap/commit/5d0796f93a1107eb14422c7b8ea416f7fd750a2e).
Sorry for that, it was unintended.
I just happened to notice that and fix it.

Nov 27 2018, 11:16 AM

Nov 26 2018

v.maffione_gmail.com added a reviewer for D17987: netmap: set IFCAP_NETMAP in if_capabilities: jhb.
Nov 26 2018, 10:24 AM

Nov 20 2018

v.maffione_gmail.com created D18057: netmap(4): improve man page.
Nov 20 2018, 11:19 AM

Nov 17 2018

v.maffione_gmail.com updated the diff for D18015: netmap: align codebase to the current upstream (sha afa26bc3bc416).

Add back $FreeBSD$ strings

Nov 17 2018, 1:52 PM
v.maffione_gmail.com created D18015: netmap: align codebase to the current upstream (sha afa26bc3bc416).
Nov 17 2018, 1:46 PM

Nov 16 2018

v.maffione_gmail.com updated the summary of D17988: ifnet(9): Add description of IFCAP_NETMAP.
Nov 16 2018, 10:01 AM
v.maffione_gmail.com added a comment to D17988: ifnet(9): Add description of IFCAP_NETMAP.

Short and sweet but I need to wait for the mentors :)

Nov 16 2018, 10:00 AM

Nov 14 2018

v.maffione_gmail.com added reviewers for D17988: ifnet(9): Add description of IFCAP_NETMAP: gnn, hrs.
Nov 14 2018, 4:44 PM
v.maffione_gmail.com created D17988: ifnet(9): Add description of IFCAP_NETMAP.
Nov 14 2018, 4:43 PM
v.maffione_gmail.com created D17987: netmap: set IFCAP_NETMAP in if_capabilities.
Nov 14 2018, 4:09 PM

Nov 13 2018

v.maffione_gmail.com accepted D17921: stable/11: backport netmap fixes from master to prevent panic.

LGTM
In any case I plan to import the current github into stable/11 soon, since the current stable/11, to stabilize it.

Nov 13 2018, 9:20 AM
v.maffione_gmail.com accepted D17896: netmap: netmap_transmit should honor bpf packet tap hook..
Nov 13 2018, 9:13 AM
v.maffione_gmail.com added inline comments to D17916: vtnet: fix netmap support.
Nov 13 2018, 9:07 AM

Nov 12 2018

v.maffione_gmail.com added inline comments to D17916: vtnet: fix netmap support.
Nov 12 2018, 2:36 PM
v.maffione_gmail.com added inline comments to D17896: netmap: netmap_transmit should honor bpf packet tap hook..
Nov 12 2018, 9:55 AM
v.maffione_gmail.com added a comment to D17910: netmap: automatically disable some capabilities over vlan interface.

I'm sorry, but as a design decision for netmap we never automatically change interface features/offloading automatically and restore them.
We require the application or the system administrator to do so explicitely.
In any case this must be discussed with the upstream project https://github.com/luigirizzo/netmap

Nov 12 2018, 9:48 AM
v.maffione_gmail.com added inline comments to D17916: vtnet: fix netmap support.
Nov 12 2018, 9:32 AM
v.maffione_gmail.com updated the diff for D17916: vtnet: fix netmap support.

Added assertions for sglist_append().
Fixed indentation.

Nov 12 2018, 9:31 AM

Nov 11 2018

v.maffione_gmail.com updated the diff for D17916: vtnet: fix netmap support.

Added DEV_NETMAP in if_vtnetvar.h
Provided full diff context.

Nov 11 2018, 10:30 AM