Page MenuHomeFreeBSD

sucanjan_gmail.com (Ján Sučan)
User

Projects

User does not belong to any projects.

User Details

User Since
Wed, Jul 24, 3:40 PM (3 w, 6 d)

Recent Activity

Today

sucanjan_gmail.com added inline comments to D21327: ping: fix alignment errors.
Wed, Aug 21, 7:52 AM
sucanjan_gmail.com added a comment to D21327: ping: fix alignment errors.

Use MIN() instead of a custom conditional expression.

Wed, Aug 21, 7:33 AM
sucanjan_gmail.com added inline comments to D21327: ping: fix alignment errors.
Wed, Aug 21, 7:03 AM

Yesterday

sucanjan_gmail.com added a comment to D21338: ping6: make lookup of symbolic names in the reply default.

I'm not sure if I understand you correctly.

Tue, Aug 20, 5:46 PM
sucanjan_gmail.com added inline comments to D21340: ping: add tests of the Internet checksum function.
Tue, Aug 20, 5:36 PM
sucanjan_gmail.com added a comment to D21340: ping: add tests of the Internet checksum function.

Set WARNS to 6 explicitly for tests.

Tue, Aug 20, 5:35 PM
sucanjan_gmail.com added inline comments to D21340: ping: add tests of the Internet checksum function.
Tue, Aug 20, 4:37 PM
sucanjan_gmail.com added a comment to D21340: ping: add tests of the Internet checksum function.

Correct unaligned data buffer size.

Tue, Aug 20, 4:34 PM
sucanjan_gmail.com added inline comments to D21340: ping: add tests of the Internet checksum function.
Tue, Aug 20, 4:22 PM
sucanjan_gmail.com added a comment to D21340: ping: add tests of the Internet checksum function.

Add an entry to etc/mtree/BSD.tests.dist.

Tue, Aug 20, 4:21 PM
sucanjan_gmail.com created D21345: ping6: Rename options for unifying option parsing with ping.
Tue, Aug 20, 4:11 PM
sucanjan_gmail.com added a comment to D21338: ping6: make lookup of symbolic names in the reply default.

Remove 'H' from the getopt() option string.

Tue, Aug 20, 3:42 PM
sucanjan_gmail.com created D21340: ping: add tests of the Internet checksum function.
Tue, Aug 20, 1:20 PM
sucanjan_gmail.com created D21338: ping6: make lookup of symbolic names in the reply default.
Tue, Aug 20, 12:26 PM
sucanjan_gmail.com added inline comments to D21289: ping: add a basic test of ping's functionality.
Tue, Aug 20, 7:21 AM
sucanjan_gmail.com added inline comments to D21289: ping: add a basic test of ping's functionality.
Tue, Aug 20, 7:18 AM
sucanjan_gmail.com added a comment to D21327: ping: fix alignment errors.

Fix the warning about signed and unsigned type in conditional
expression.

Tue, Aug 20, 6:23 AM

Mon, Aug 19

sucanjan_gmail.com added a comment to D21327: ping: fix alignment errors.

If the line 1144 is this line

Mon, Aug 19, 7:26 PM
sucanjan_gmail.com created D21327: ping: fix alignment errors.
Mon, Aug 19, 6:45 PM
sucanjan_gmail.com created D21325: ping: increase buffer size for the string representation of n_time.
Mon, Aug 19, 4:59 PM
sucanjan_gmail.com created D21322: ping: fix uninitialized variable warnings when MK_CASPER=no.
Mon, Aug 19, 4:15 PM
sucanjan_gmail.com added a comment to D21289: ping: add a basic test of ping's functionality.

Well, I'm not sure. It's not completely useless. It helped me to discover few bugs during development. Maybe we could keep it just for now when there is no better testing employed. Filtering those information out itself could be considered a check because if a string doesn't match the regular expression, it's not filtered out and it's detected. Please, decide. If you close this review (and the one for ping6), I will understand and I will continue without the ATF sh tests.

Mon, Aug 19, 3:54 PM
sucanjan_gmail.com added a comment to D21289: ping: add a basic test of ping's functionality.

Use a single tab width in the ATF test script.

Mon, Aug 19, 8:05 AM
sucanjan_gmail.com added a comment to D21292: ping6: add a basic test of ping6's functionality.

Use a single tab width in the ATF test script.

Mon, Aug 19, 7:45 AM
sucanjan_gmail.com added a comment to D21319: ping6: Fix insufficient privileges bug introduced by r350857.

Yes.

Mon, Aug 19, 5:26 AM

Sun, Aug 18

sucanjan_gmail.com created D21319: ping6: Fix insufficient privileges bug introduced by r350857.
Sun, Aug 18, 7:21 PM
sucanjan_gmail.com added a comment to D21289: ping: add a basic test of ping's functionality.

It seems that that are far more variable parts in the output than I thought. I think the exact ttl value and ordering of responses cannot be relied on either. Is it OK having a test like this with all of that numeric information filetered out?

Sun, Aug 18, 10:00 AM

Sat, Aug 17

sucanjan_gmail.com added a comment to D21292: ping6: add a basic test of ping6's functionality.

Could I use getaddrinfo command for that? Like this:

Sat, Aug 17, 3:34 PM
sucanjan_gmail.com added a comment to D21288: ping: move in_cksum() to a separate source file.

Use copyright information and ID from ping.c in utils.c.

Sat, Aug 17, 3:16 PM
sucanjan_gmail.com retitled D21288: ping: move in_cksum() to a separate source file from ping6: move in_cksum() to a separate source file to ping: move in_cksum() to a separate source file.
Sat, Aug 17, 3:14 PM
sucanjan_gmail.com added inline comments to D21260: ping6: Raise WARNS level to 6.
Sat, Aug 17, 3:13 PM
sucanjan_gmail.com added a comment to D21260: ping6: Raise WARNS level to 6.

Remove WARNS. 6 is the default level.

Sat, Aug 17, 3:08 PM

Fri, Aug 16

sucanjan_gmail.com created D21292: ping6: add a basic test of ping6's functionality.
Fri, Aug 16, 4:20 PM
sucanjan_gmail.com added a comment to D21289: ping: add a basic test of ping's functionality.

Should I put any copyright information to tests/ping_test.sh?

Fri, Aug 16, 7:57 AM
sucanjan_gmail.com created D21289: ping: add a basic test of ping's functionality.
Fri, Aug 16, 7:56 AM
sucanjan_gmail.com added a comment to D21288: ping: move in_cksum() to a separate source file.

I didn't put any copyright notice in utils.c because I didn't know what part of the copyright information to take from ping.c. Could you please help me with this?

Fri, Aug 16, 7:49 AM
sucanjan_gmail.com created D21288: ping: move in_cksum() to a separate source file.
Fri, Aug 16, 7:20 AM
sucanjan_gmail.com added inline comments to D21266: ping6: Fix dnsdecode() bug introduced by r350859.
Fri, Aug 16, 6:49 AM
sucanjan_gmail.com added a comment to D21266: ping6: Fix dnsdecode() bug introduced by r350859.

Document dnsdecode's arguments and return value.

Fri, Aug 16, 6:45 AM

Thu, Aug 15

sucanjan_gmail.com added a comment to D21217: ping6: Fix alignment errors.

All of the warnings should be fixed (D21269, D21270, D21271, D21273, D21275).

Thu, Aug 15, 3:03 PM
sucanjan_gmail.com created D21275: ping6: Fix data type of the buffer for ancillary data of a received message.
Thu, Aug 15, 2:59 PM
sucanjan_gmail.com created D21273: ping6: Compile calls of Casper limit functions conditionally.
Thu, Aug 15, 2:44 PM
sucanjan_gmail.com created D21271: ping6: Rearrange code for initialization of 'intvl' variable.
Thu, Aug 15, 1:20 PM
sucanjan_gmail.com created D21270: ping6: Disable definition of the old copyright variable.
Thu, Aug 15, 1:02 PM
sucanjan_gmail.com created D21269: ping6: Initialize ttl variable.
Thu, Aug 15, 12:48 PM
sucanjan_gmail.com created D21266: ping6: Fix dnsdecode() bug introduced by r350859.
Thu, Aug 15, 7:20 AM

Wed, Aug 14

sucanjan_gmail.com created D21261: ping: Make in_cksum() operate on u_char buffer.
Wed, Aug 14, 7:41 AM
sucanjan_gmail.com added a comment to D21260: ping6: Raise WARNS level to 6.

This depends on D21217.

Wed, Aug 14, 7:11 AM
sucanjan_gmail.com created D21260: ping6: Raise WARNS level to 6.
Wed, Aug 14, 7:09 AM
sucanjan_gmail.com added a comment to D21217: ping6: Fix alignment errors.

Rebase to the master branch.

Wed, Aug 14, 7:01 AM
D21258: ping: fix triptime calculation after r350998 is now accepted and ready to land.

Thanks for the fix.

Wed, Aug 14, 5:02 AM

Tue, Aug 13

sucanjan_gmail.com added inline comments to D21245: ping: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC).
Tue, Aug 13, 5:28 PM
sucanjan_gmail.com added a comment to D21245: ping: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC).

Use timespecadd(), and timespecsub().

Tue, Aug 13, 5:28 PM
sucanjan_gmail.com added inline comments to D21226: ping6: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC).
Tue, Aug 13, 5:25 PM
sucanjan_gmail.com added a comment to D21226: ping6: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC).

Use timespecadd(), timespecsub(), and timespecclear().

Tue, Aug 13, 5:24 PM
sucanjan_gmail.com created D21245: ping: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC).
Tue, Aug 13, 8:49 AM
sucanjan_gmail.com created D21244: ping: Fix data type of a variable for a packet sequence number.
Tue, Aug 13, 8:27 AM
sucanjan_gmail.com retitled D21219: ping6: Consistently use the byteorder functions in the correct direction from ping6: Fix endianness of a sequence number in a packet to send to ping6: Consistently use the byteorder functions in the correct direction.
Tue, Aug 13, 7:23 AM
sucanjan_gmail.com added a comment to D21220: ping6: Annotate truncating of time values saved in a packet.

The revision has been combined.

Tue, Aug 13, 7:16 AM
sucanjan_gmail.com added a comment to D21226: ping6: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC).

Annotate truncating of time values saved in a packet.

Tue, Aug 13, 7:13 AM
sucanjan_gmail.com added inline comments to D21226: ping6: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC).
Tue, Aug 13, 7:06 AM
sucanjan_gmail.com added a comment to D21226: ping6: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC).

Use timespecsub(3) instead of a private function.

Tue, Aug 13, 7:05 AM
sucanjan_gmail.com added inline comments to D21220: ping6: Annotate truncating of time values saved in a packet.
Tue, Aug 13, 4:13 AM
sucanjan_gmail.com added a comment to D21219: ping6: Consistently use the byteorder functions in the correct direction.

What should be the correct description?

Tue, Aug 13, 4:12 AM

Mon, Aug 12

sucanjan_gmail.com added inline comments to D21217: ping6: Fix alignment errors.
Mon, Aug 12, 11:56 AM
sucanjan_gmail.com created D21226: ping6: Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC).
Mon, Aug 12, 11:53 AM
sucanjan_gmail.com added inline comments to D21217: ping6: Fix alignment errors.
Mon, Aug 12, 11:03 AM
sucanjan_gmail.com created D21220: ping6: Annotate truncating of time values saved in a packet.
Mon, Aug 12, 7:30 AM
sucanjan_gmail.com created D21219: ping6: Consistently use the byteorder functions in the correct direction.
Mon, Aug 12, 7:03 AM
sucanjan_gmail.com created D21218: ping6: Fix data type of a variable for a packet sequence number.
Mon, Aug 12, 6:52 AM
sucanjan_gmail.com added inline comments to D21217: ping6: Fix alignment errors.
Mon, Aug 12, 5:34 AM

Sun, Aug 11

sucanjan_gmail.com added inline comments to D21217: ping6: Fix alignment errors.
Sun, Aug 11, 6:53 PM
sucanjan_gmail.com added inline comments to D21217: ping6: Fix alignment errors.
Sun, Aug 11, 6:36 PM
sucanjan_gmail.com created D21217: ping6: Fix alignment errors.
Sun, Aug 11, 2:52 PM
sucanjan_gmail.com created D21215: ping6: Remove unnecessary level of indirection from dnsdecode() parameter.
Sun, Aug 11, 7:37 AM
sucanjan_gmail.com created D21214: ping6: Add missing static keyword for a global variable.
Sun, Aug 11, 7:12 AM
sucanjan_gmail.com created D21213: ping6: Revoke root privilege earlier.
Sun, Aug 11, 6:40 AM

Tue, Jul 30

sucanjan_gmail.com added a comment to D21050: Capsicumize ping6.

Try to Use arc diff so that all the changes are included in the diff.

Tue, Jul 30, 11:41 AM
sucanjan_gmail.com added a comment to D21050: Capsicumize ping6.

Limit stdio rights.

Tue, Jul 30, 11:32 AM
sucanjan_gmail.com added inline comments to D21050: Capsicumize ping6.
Tue, Jul 30, 6:56 AM

Mon, Jul 29

sucanjan_gmail.com added inline comments to D21050: Capsicumize ping6.
Mon, Jul 29, 2:57 PM
D21050: Capsicumize ping6 now requires review to proceed.

Use nitems() for getting size of an array.

Mon, Jul 29, 2:57 PM

Sat, Jul 27

sucanjan_gmail.com added inline comments to D21050: Capsicumize ping6.
Sat, Jul 27, 7:33 PM
sucanjan_gmail.com added a comment to D21050: Capsicumize ping6.

Define two separate cap_rights_t sets, one for each socket, and use cap_rights_clear() to remove CAP_SETSOCKOPT before further limiting rights on those sockets.

Sat, Jul 27, 7:26 PM
sucanjan_gmail.com added a comment to D21050: Capsicumize ping6.

There are some seemingly unrelated changes: we drop privileges earlier, we set SO_DEBUG on both sockets, some whitespace changes. I would suggest having those be separate commits.

Sat, Jul 27, 6:37 AM