Page MenuHomeFreeBSD

smahadevan_freebsdfoundation.org (Siva Mahadevan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2017, 7:24 PM (273 w, 3 d)

Recent Activity

Aug 29 2017

smahadevan_freebsdfoundation.org updated the diff for D12099: Add minimal kernel runtime for UBSAN.

Wrong commit order, accidentally deleted license.

Aug 29 2017, 3:17 PM
smahadevan_freebsdfoundation.org updated the diff for D12099: Add minimal kernel runtime for UBSAN.

Fixed style(9) issues.

Aug 29 2017, 2:40 PM

Aug 28 2017

smahadevan_freebsdfoundation.org added a comment to D12124: msdosfs: verify that the BPB media descriptor and FAT ID match.

That makes sense, I will continue working on an actual solution to the panic. Thanks for the clarification.

Aug 28 2017, 8:50 PM
smahadevan_freebsdfoundation.org updated the diff for D12124: msdosfs: verify that the BPB media descriptor and FAT ID match.

Fix style and semantics issues

Aug 28 2017, 8:23 PM
smahadevan_freebsdfoundation.org updated the diff for D12124: msdosfs: verify that the BPB media descriptor and FAT ID match.

Thanks for the feedback Kostik! Updated to reflect the changes.

Aug 28 2017, 6:51 PM

Aug 25 2017

smahadevan_freebsdfoundation.org updated the diff for D12124: msdosfs: verify that the BPB media descriptor and FAT ID match.

Accidentally had extra whitespace in previous diff

Aug 25 2017, 5:02 PM
smahadevan_freebsdfoundation.org created D12124: msdosfs: verify that the BPB media descriptor and FAT ID match.
Aug 25 2017, 5:00 PM

Aug 22 2017

smahadevan_freebsdfoundation.org updated the diff for D12099: Add minimal kernel runtime for UBSAN.
  • Moved around kernel options to correct locations and added additional comments
  • Added assert for checking bounds of array access
Aug 22 2017, 3:47 PM
smahadevan_freebsdfoundation.org updated the diff for D12099: Add minimal kernel runtime for UBSAN.

Add license after consulting with Ed

Aug 22 2017, 2:05 PM

Aug 21 2017

smahadevan_freebsdfoundation.org created D12099: Add minimal kernel runtime for UBSAN.
Aug 21 2017, 4:05 PM

Aug 15 2017

smahadevan_freebsdfoundation.org updated the diff for D11814: Implement "vidcontrol -h <history_size>" for vt(4).
  • Add a check for the maximum history size. This maximum is set to the same value as the maximum in syscons(4).
  • Fix the error string on a negative number argument
Aug 15 2017, 4:25 PM
smahadevan_freebsdfoundation.org updated the diff for D11918: Fix vt(4)'s response to Device Status Report escape sequences.

Accidentally updated wrong review, reverting back to previous diff

Aug 15 2017, 4:23 PM
smahadevan_freebsdfoundation.org updated the diff for D11918: Fix vt(4)'s response to Device Status Report escape sequences.
  • Add a check for the maximum history size. This maximum is set to the same value as the maximum in syscons(4).
  • Fix the error string on a negative number argument
Aug 15 2017, 4:17 PM
smahadevan_freebsdfoundation.org added inline comments to D11814: Implement "vidcontrol -h <history_size>" for vt(4).
Aug 15 2017, 1:41 PM

Aug 14 2017

smahadevan_freebsdfoundation.org added inline comments to D11814: Implement "vidcontrol -h <history_size>" for vt(4).
Aug 14 2017, 9:38 PM

Aug 7 2017

smahadevan_freebsdfoundation.org updated the summary of D11918: Fix vt(4)'s response to Device Status Report escape sequences.
Aug 7 2017, 8:45 PM
smahadevan_freebsdfoundation.org created D11918: Fix vt(4)'s response to Device Status Report escape sequences.
Aug 7 2017, 8:38 PM

Aug 4 2017

smahadevan_freebsdfoundation.org added a comment to D11866: Allow vt_timer() callout to run during mountroot input loop in vt(4).

cngets() already calls cngrab() in sys/kern/kern_cons.c here:

Aug 4 2017, 9:54 PM
smahadevan_freebsdfoundation.org created D11866: Allow vt_timer() callout to run during mountroot input loop in vt(4).
Aug 4 2017, 3:59 PM

Aug 1 2017

smahadevan_freebsdfoundation.org added a reviewer for D11814: Implement "vidcontrol -h <history_size>" for vt(4): ray.
Aug 1 2017, 10:23 PM
smahadevan_freebsdfoundation.org updated subscribers of D11814: Implement "vidcontrol -h <history_size>" for vt(4).
Aug 1 2017, 10:22 PM
smahadevan_freebsdfoundation.org created D11814: Implement "vidcontrol -h <history_size>" for vt(4).
Aug 1 2017, 10:10 PM

Jul 28 2017

smahadevan_freebsdfoundation.org updated the diff for D11753: Implement "vidcontrol -c <normal|blink|destructive>" for vt(4).

Fixed style issues.

Jul 28 2017, 10:20 PM

Jul 27 2017

smahadevan_freebsdfoundation.org added a reviewer for D11753: Implement "vidcontrol -c <normal|blink|destructive>" for vt(4): emaste.
Jul 27 2017, 7:44 PM
smahadevan_freebsdfoundation.org created D11753: Implement "vidcontrol -c <normal|blink|destructive>" for vt(4).
Jul 27 2017, 7:36 PM

Jul 13 2017

smahadevan_freebsdfoundation.org updated the diff for D11576: Preserve syscall flags for dynamically loaded syscalls.
  • Added comment to sys/kern/capabilities.conf for more information on where the sysents are being initialized
  • Added flags to SYSCALL32 initializers
Jul 13 2017, 7:57 PM
smahadevan_freebsdfoundation.org updated the diff for D11576: Preserve syscall flags for dynamically loaded syscalls.

Changed module syscall init helpers to initialize flags

Jul 13 2017, 2:36 PM
smahadevan_freebsdfoundation.org created D11576: Preserve syscall flags for dynamically loaded syscalls.
Jul 13 2017, 12:38 AM

Jun 22 2017

smahadevan_freebsdfoundation.org created D11301: EFI boot: made 32 bit pad more explicit on EFI_MEMORY_DESCRIPTOR.
Jun 22 2017, 1:29 PM
smahadevan_freebsdfoundation.org added inline comments to D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.
Jun 22 2017, 1:22 PM

Jun 15 2017

smahadevan_freebsdfoundation.org abandoned D11218: makefs: add MSDOS-specific functionality from NetBSD.
Jun 15 2017, 8:12 PM
smahadevan_freebsdfoundation.org updated the diff for D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.

Shouldn't expose locking macros to makefs

Jun 15 2017, 8:04 PM
smahadevan_freebsdfoundation.org updated the diff for D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.
Jun 15 2017, 7:41 PM
smahadevan_freebsdfoundation.org added inline comments to D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.
Jun 15 2017, 7:24 PM
smahadevan_freebsdfoundation.org abandoned D11217: Properly zero out high cluster data on non-FAT32 msdos filesystems.

Abandoning because this change doesn't functionally change anything, it isn't actually fixing any bugs.

Jun 15 2017, 5:32 PM
smahadevan_freebsdfoundation.org added inline comments to D11217: Properly zero out high cluster data on non-FAT32 msdos filesystems.
Jun 15 2017, 5:09 PM
smahadevan_freebsdfoundation.org created D11218: makefs: add MSDOS-specific functionality from NetBSD.
Jun 15 2017, 3:54 PM
smahadevan_freebsdfoundation.org updated the diff for D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.

Reverted DEEXTERNALIZE changes, refer to D11217 for bugfix

Jun 15 2017, 3:44 PM
smahadevan_freebsdfoundation.org created D11217: Properly zero out high cluster data on non-FAT32 msdos filesystems.
Jun 15 2017, 3:31 PM
smahadevan_freebsdfoundation.org added inline comments to D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.
Jun 15 2017, 2:41 PM
smahadevan_freebsdfoundation.org updated the diff for D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.

Removed style change, added comment for #ifdef

Jun 15 2017, 2:30 PM

Jun 14 2017

smahadevan_freebsdfoundation.org updated the diff for D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.

Changed #ifndef MAKEFS to #ifdef _KERNEL.

Jun 14 2017, 10:00 PM
smahadevan_freebsdfoundation.org added inline comments to D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.
Jun 14 2017, 9:56 PM
smahadevan_freebsdfoundation.org added a reviewer for D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support: emaste.
Jun 14 2017, 9:20 PM
smahadevan_freebsdfoundation.org updated the diff for D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.
Jun 14 2017, 9:19 PM
smahadevan_freebsdfoundation.org created D11197: msdosfs: expose and hide definitions/functions for makefs FAT fs support.
Jun 14 2017, 9:17 PM

May 31 2017

smahadevan_freebsdfoundation.org created D11011: Free buf in case of error.
May 31 2017, 4:09 PM

May 26 2017

smahadevan_freebsdfoundation.org updated the diff for D10780: makefs: add -O (offset) option.

Rebased with master

May 26 2017, 3:11 PM
smahadevan_freebsdfoundation.org added a comment to D10780: makefs: add -O (offset) option.

How did you produce this bug? I am not able to reproduce it on my end.

May 26 2017, 3:05 PM

May 25 2017

smahadevan_freebsdfoundation.org updated the diff for D10803: makefs: make buf generic.
May 25 2017, 8:17 PM
smahadevan_freebsdfoundation.org added a comment to D10803: makefs: make buf generic.

Ah you're right, I think I must have included a few extra commits in the diff, I'll fix this diff and make it relative to master.

May 25 2017, 3:01 PM
smahadevan_freebsdfoundation.org updated the diff for D10803: makefs: make buf generic.

Renamed buf and vnode fields to match NetBSD

May 25 2017, 1:34 PM

May 19 2017

smahadevan_freebsdfoundation.org added a comment to D10802: makefs: style fixes and whitespace changes.

What is the best course of action then? Are these whitespace changes ok or should we ignore this and continue with D10803?

May 19 2017, 7:34 PM
smahadevan_freebsdfoundation.org updated the diff for D10821: Use C99 types in MSDOSFS system code in anticipation of makefs msdos support.
  • Removed whitespace and style changes on lines other than the ones affected in this diff
  • Kept u_long, u_char, etc. as is
May 19 2017, 5:33 PM
smahadevan_freebsdfoundation.org added inline comments to D10821: Use C99 types in MSDOSFS system code in anticipation of makefs msdos support.
May 19 2017, 5:09 PM
smahadevan_freebsdfoundation.org added inline comments to D10821: Use C99 types in MSDOSFS system code in anticipation of makefs msdos support.
May 19 2017, 4:11 PM
smahadevan_freebsdfoundation.org created D10821: Use C99 types in MSDOSFS system code in anticipation of makefs msdos support.
May 19 2017, 3:51 PM

May 18 2017

smahadevan_freebsdfoundation.org updated the diff for D10803: makefs: make buf generic.

Changed i_vnode to i_devvp to maintain consistency with NetBSD

May 18 2017, 9:54 PM
smahadevan_freebsdfoundation.org added a comment to D10803: makefs: make buf generic.

You are referring to https://svnweb.freebsd.org/base?view=revision&revision=317967 right? Was the breaking error something like: "makefs: bread: lseek 48 (-4393751551952): Invalid argument"? My bug fixes in this diff should fix the previously breaking revision. Specifically, the problem had to do with incorrectly casting a void * field in the vnode struct as fsinfo_t. Instead, this diff adds the v_fsinfo field to the struct vnode.

May 18 2017, 6:08 PM
smahadevan_freebsdfoundation.org updated the diff for D10780: makefs: add -O (offset) option.
May 18 2017, 5:48 PM
smahadevan_freebsdfoundation.org created D10803: makefs: make buf generic.
May 18 2017, 5:38 PM
smahadevan_freebsdfoundation.org created D10802: makefs: style fixes and whitespace changes.
May 18 2017, 4:08 PM
smahadevan_freebsdfoundation.org abandoned D10777: makefs: clean up warnings, fix style, bring changes over from NetBSD.

Review is outdated, will be uploading independent reviews for whitespace changes and the bread bug fix. See https://reviews.freebsd.org/D10650.

May 18 2017, 2:36 PM

May 17 2017

smahadevan_freebsdfoundation.org added reviewers for D10780: makefs: add -O (offset) option: emaste, ngie.
May 17 2017, 9:50 PM
smahadevan_freebsdfoundation.org created D10780: makefs: add -O (offset) option.
May 17 2017, 9:48 PM
smahadevan_freebsdfoundation.org abandoned D10760: (emaste/freebsd:makefs-wip) fix bug with bread getting wrong offset and sectorsize.
May 17 2017, 8:02 PM
smahadevan_freebsdfoundation.org created D10777: makefs: clean up warnings, fix style, bring changes over from NetBSD.
May 17 2017, 7:49 PM
smahadevan_freebsdfoundation.org added a comment to D10760: (emaste/freebsd:makefs-wip) fix bug with bread getting wrong offset and sectorsize.

Ed and I were discussing how to proceed with these changes. Instead of this review, I will post reviews for each individual feature change in makefs so it will be easier to manage. I haven't run the other tests that depend on makefs yet, I will do that before posting the other reviews. Can I abandon this revision? I will post the other reviews soon.

May 17 2017, 1:27 PM

May 16 2017

smahadevan_freebsdfoundation.org added a reviewer for D10760: (emaste/freebsd:makefs-wip) fix bug with bread getting wrong offset and sectorsize: ngie.
May 16 2017, 8:14 PM
smahadevan_freebsdfoundation.org updated the diff for D10760: (emaste/freebsd:makefs-wip) fix bug with bread getting wrong offset and sectorsize.
May 16 2017, 8:13 PM
smahadevan_freebsdfoundation.org created D10760: (emaste/freebsd:makefs-wip) fix bug with bread getting wrong offset and sectorsize.
May 16 2017, 8:09 PM