Page MenuHomeFreeBSD

scott.d.phillips_intel.com (D Scott Phillips)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2018, 5:54 PM (38 w, 5 d)

Recent Activity

Tue, Jan 29

scott.d.phillips_intel.com updated the diff for D18439: nvdimm: only enumerate present nvdimm devices.
  • fix one more style(9) problem
Tue, Jan 29, 9:17 PM
scott.d.phillips_intel.com added inline comments to D18439: nvdimm: only enumerate present nvdimm devices.
Tue, Jan 29, 8:00 PM
scott.d.phillips_intel.com updated the diff for D18439: nvdimm: only enumerate present nvdimm devices.
  • rebase patch
  • add commit message tags
  • Don't use i for non-int loop variables
  • Fix some style(9) issues with braces
  • Don't use variable names prefixed with underscore
  • Handle unaligned accesses in find_matches()
  • Fix an off-by-one error in the allocation of ivars
Tue, Jan 29, 7:57 PM
scott.d.phillips_intel.com updated the diff for D18734: nvdimm: enumerate NVDIMM SPA ranges from the root device.
  • rebase patch
  • add commit message tags
Tue, Jan 29, 7:56 PM

Jan 17 2019

scott.d.phillips_intel.com updated the diff for D18733: nvdimm: initialize SPA uuids statically.

Add Intel copyright, add commit message tags.

Jan 17 2019, 6:27 PM
scott.d.phillips_intel.com updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.

Add copyright for Intel, add commit message tags, allocate flush addrs with mallocarray .

Jan 17 2019, 6:23 PM

Jan 3 2019

scott.d.phillips_intel.com added a parent revision for D17619: nvdimm: Simple namespace support: D18736: nvdimm: split spa dev into a separate entity.
Jan 3 2019, 8:16 PM
scott.d.phillips_intel.com added a child revision for D18736: nvdimm: split spa dev into a separate entity: D17619: nvdimm: Simple namespace support.
Jan 3 2019, 8:16 PM
scott.d.phillips_intel.com added a parent revision for D18736: nvdimm: split spa dev into a separate entity: D18735: nvdimm: Read NVDIMM namespace labels.
Jan 3 2019, 8:16 PM
scott.d.phillips_intel.com added a child revision for D18735: nvdimm: Read NVDIMM namespace labels: D18736: nvdimm: split spa dev into a separate entity.
Jan 3 2019, 8:16 PM
scott.d.phillips_intel.com added a parent revision for D18735: nvdimm: Read NVDIMM namespace labels: D18439: nvdimm: only enumerate present nvdimm devices.
Jan 3 2019, 8:16 PM
scott.d.phillips_intel.com added a child revision for D18439: nvdimm: only enumerate present nvdimm devices: D18735: nvdimm: Read NVDIMM namespace labels.
Jan 3 2019, 8:16 PM
scott.d.phillips_intel.com added a parent revision for D18439: nvdimm: only enumerate present nvdimm devices: D18734: nvdimm: enumerate NVDIMM SPA ranges from the root device.
Jan 3 2019, 8:15 PM
scott.d.phillips_intel.com added a child revision for D18734: nvdimm: enumerate NVDIMM SPA ranges from the root device: D18439: nvdimm: only enumerate present nvdimm devices.
Jan 3 2019, 8:15 PM
scott.d.phillips_intel.com added a parent revision for D18734: nvdimm: enumerate NVDIMM SPA ranges from the root device: D18733: nvdimm: initialize SPA uuids statically.
Jan 3 2019, 8:15 PM
scott.d.phillips_intel.com added a child revision for D18733: nvdimm: initialize SPA uuids statically: D18734: nvdimm: enumerate NVDIMM SPA ranges from the root device.
Jan 3 2019, 8:15 PM
scott.d.phillips_intel.com added a parent revision for D18733: nvdimm: initialize SPA uuids statically: D18346: nvdimm: add a driver for the NVDIMM root device.
Jan 3 2019, 8:15 PM
scott.d.phillips_intel.com added a child revision for D18346: nvdimm: add a driver for the NVDIMM root device: D18733: nvdimm: initialize SPA uuids statically.
Jan 3 2019, 8:15 PM
scott.d.phillips_intel.com updated the diff for D17619: nvdimm: Simple namespace support.
Jan 3 2019, 8:13 PM
scott.d.phillips_intel.com created D18736: nvdimm: split spa dev into a separate entity.
Jan 3 2019, 8:12 PM
scott.d.phillips_intel.com created D18735: nvdimm: Read NVDIMM namespace labels.
Jan 3 2019, 8:11 PM
scott.d.phillips_intel.com updated the diff for D18439: nvdimm: only enumerate present nvdimm devices.
Jan 3 2019, 8:10 PM
scott.d.phillips_intel.com created D18734: nvdimm: enumerate NVDIMM SPA ranges from the root device.
Jan 3 2019, 8:09 PM
scott.d.phillips_intel.com created D18733: nvdimm: initialize SPA uuids statically.
Jan 3 2019, 8:08 PM
scott.d.phillips_intel.com updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.
Jan 3 2019, 8:07 PM

Dec 12 2018

scott.d.phillips_intel.com added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#394764, @kib wrote:

Ok. I think we could do some cross of what you want and what I do not want.

Right now how I wrote nvdimm.c, it directly digs into subordinate devices of the root NVDIMM device and instantiate device_t for each found device in the namespace in probe. What if we add a top-level newbus driver (in nvdimm.c) which attaches to the root ACPI device. This driver duties would be:

  • create children for each subordinate device, where the current nvdimm.c driver attaches. Basically, this moves the nvdimm_probe() into the root device driver;
  • iterate over the NFIT and create SPAs, basically identical to what you do in the current patch.

    The difference with the patch is that root driver is not a hack but a place where we put all the enumeration logic.
Dec 12 2018, 2:35 AM
scott.d.phillips_intel.com added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#394755, @kib wrote:

I do not understand your fixation on the newbus attachment for SPA. Now you are trying to hide it under the root NVDIMM device, but again, I do not see any connection between the root and activation of SPA support. To get SPA used, we only need SPA entries from the NFIT table.

Dec 12 2018, 1:11 AM

Dec 11 2018

scott.d.phillips_intel.com added inline comments to D18439: nvdimm: only enumerate present nvdimm devices.
Dec 11 2018, 11:31 PM

Dec 10 2018

scott.d.phillips_intel.com updated the diff for D18439: nvdimm: only enumerate present nvdimm devices.

rebase diff so that it is no longer against D18346

Dec 10 2018, 10:11 PM
scott.d.phillips_intel.com updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.
Dec 10 2018, 10:08 PM

Dec 6 2018

scott.d.phillips_intel.com added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.

ah, the other thing was that having SPAs as devices gave me a convenient fix to the ordering problem where the nvdimm devices are not yet attached at SPA initialization time. perhaps a better fix would be to have a device on the acpi bus for the NVDIMM root device (ACPI0012), which control the SPA initialization, outside of anything related to geom.

Dec 6 2018, 1:11 AM

Dec 5 2018

scott.d.phillips_intel.com added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#392753, @kib wrote:

But namespaces have no relevance for newbus at all, e.g. we do not create device_t for partitions for the same reason.

Dec 5 2018, 7:57 PM
scott.d.phillips_intel.com added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#392735, @kib wrote:

What do we need ? I see that we need a unique unit number (currently punned by reusing the SPA index) and a way to list all SPAs at the unload time, to destruct them. Would be a global list of all SPAs enough for the later ?

Dec 5 2018, 7:28 PM
scott.d.phillips_intel.com added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#392701, @kib wrote:

Why do we need newbus attachment for SPAs ?

For ACPI-enumerated NVDIMMs, creating the devices is more or less natural since they represent physical objects that exist in the chassis. But SPAs are purely software constructs, which newbus devices seems to only tunnel the calls to init_ine()/fini_one().

Dec 5 2018, 7:01 PM
scott.d.phillips_intel.com added a comment to D18439: nvdimm: only enumerate present nvdimm devices.

FYI, this diff is on top of D18346

Dec 5 2018, 5:37 PM
scott.d.phillips_intel.com created D18439: nvdimm: only enumerate present nvdimm devices.
Dec 5 2018, 5:33 PM
scott.d.phillips_intel.com updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.
  • check for the existence of an spa device before adding a new one to the acpi bus.
Dec 5 2018, 5:29 PM

Nov 29 2018

scott.d.phillips_intel.com updated the diff for D18346: nvdimm: add a driver for the NVDIMM root device.

@kib Here's an approach to splitting the geom and spa device by making nvdimm_spa devices on the acpi bus. Let me know if this looks like the right direction here.

Nov 29 2018, 10:19 PM

Nov 28 2018

scott.d.phillips_intel.com added a comment to D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.
In D18009#390469, @0mp wrote:

@mat, I believe that this revision is ready to be committed.

The whole Doxygen and Pandoc thing could be dropped all together. We may add them later if @scott.d.phillips_intel.com decides it is useful.

Nov 28 2018, 4:28 PM

Nov 27 2018

scott.d.phillips_intel.com updated the diff for D18345: Fix assert condition in pmap_large_unmap().

Fix assert to use va loop variable.

Nov 27 2018, 8:02 PM
scott.d.phillips_intel.com updated the diff for D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.
  • revert to pmdk 1.5
  • address @mat's comments on Diff 50890
Nov 27 2018, 7:30 PM
scott.d.phillips_intel.com added a comment to D18346: nvdimm: add a driver for the NVDIMM root device.
In D18346#390124, @kib wrote:

So there are really two changes, and the addition of the spa_g_destroy() is rather small comparing to the other part. You stopped allocating spa_mappings[] array at all. Can you extract it into separate change ?

BTW, I am not sure if it is possible to destroy geom forcibly by a user command. If yes, then the tight bind between spa lifetime and geom lifetime is undesirable, I think, because besides geom spa provides usermode access device.

Nov 27 2018, 7:23 PM

Nov 26 2018

scott.d.phillips_intel.com created D18346: nvdimm: add a driver for the NVDIMM root device.
Nov 26 2018, 9:21 PM
scott.d.phillips_intel.com created D18345: Fix assert condition in pmap_large_unmap().
Nov 26 2018, 9:18 PM
scott.d.phillips_intel.com added inline comments to D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.
Nov 26 2018, 6:00 PM

Nov 16 2018

scott.d.phillips_intel.com added a comment to D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.

@0mp: sorry for all the errors still in portlint, I was running it without any options and thinking I would see everything important. I've fixed the man pages path. There were warnings about the other documentation files too in the older patch, but those got moved out of pmdk in the 1.5 version. The 1.5 version also added a strangely packaged python module which I've left out of the port altogether for the time being.

Nov 16 2018, 11:38 PM
scott.d.phillips_intel.com updated the diff for D18009: New port: devel/pmdk: a collection of libraries and tools for System Administrators and Application Developers.

Update DISTVERSION to 1.5, update man path, add USE_LDCONFIG

Nov 16 2018, 11:36 PM

Oct 19 2018

scott.d.phillips_intel.com created D17619: nvdimm: Simple namespace support.
Oct 19 2018, 7:59 PM

Jul 11 2018

scott.d.phillips_intel.com added a comment to D16211: run(4): Add a new USB device ID..

... the numbers just happened to coincide here.

I'm not sure what you mean by that.

I guess what I'm asking is:

  1. The RT5372 radio is already supported by run(4), modulo having to add the look-up table entries?
Jul 11 2018, 2:19 AM
scott.d.phillips_intel.com added a comment to D16211: run(4): Add a new USB device ID..

(I'm assuming its been tested by at least one person)

Jul 11 2018, 1:39 AM

Jul 10 2018

scott.d.phillips_intel.com created D16211: run(4): Add a new USB device ID..
Jul 10 2018, 11:06 PM