Page MenuHomeFreeBSD

s3erios_gmail.com (Andriy Voskoboinyk)
User

Projects

User does not belong to any projects.

User Details

User Since
May 26 2015, 5:01 PM (220 w, 4 d)

Recent Activity

Mar 31 2019

s3erios_gmail.com abandoned D4279: run(4): do not remove IEEE80211_FC1_PROTECTED bit from undecrypted frames (untested).

Committed in rS345753.

Mar 31 2019, 1:41 PM

Feb 22 2019

s3erios_gmail.com created D19289: Allow to build ifconfig(8) without wireless support.
Feb 22 2019, 12:42 AM

Feb 10 2019

s3erios_gmail.com abandoned D18905: Document __FreeBSD_version 1300009.

Looks like it's already committed by kib@

Feb 10 2019, 9:46 PM

Jan 26 2019

s3erios_gmail.com created D18983: mpr / mps: drop post-panic(9) actions.
Jan 26 2019, 5:37 PM
s3erios_gmail.com updated the diff for D18905: Document __FreeBSD_version 1300009.
Jan 26 2019, 1:09 PM

Jan 20 2019

s3erios_gmail.com created D18905: Document __FreeBSD_version 1300009.
Jan 20 2019, 1:53 PM

Jan 7 2019

s3erios_gmail.com added a comment to D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages.

Actually, the code tries to find a 'next' (fallback) rate, which will be used if transmission on the current rate fails; the code will be incorrect, when HT support will be added to the driver (but currently it should 'just work').

Jan 7 2019, 5:54 AM
s3erios_gmail.com added a reviewer for D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages: s3erios_gmail.com.
Jan 7 2019, 5:43 AM

Jan 6 2019

s3erios_gmail.com added a comment to D18742: (PR 125707): powerd(8): allow to force a method of battery state query.
In D18742#399973, @imp wrote:

I doubt there's any FreeBSD machines running FreeBSD 6 or newer using APM today. This stopped being relevant around Pentium MMX 200MHz time frame, and was relevant only for laptops. You can safely completely and totally ignore the APM method. We should GC all that code.

Jan 6 2019, 2:46 AM

Jan 4 2019

s3erios_gmail.com added a comment to D18742: (PR 125707): powerd(8): allow to force a method of battery state query.

igor usr.sbin/powerd/powerd.8
powerd.8:27:date not today, January 4, 2019:.Dd [January 3, 2019]

Jan 4 2019, 12:35 PM
s3erios_gmail.com added a comment to D18727: rtwn(4): RTL8188EE fixed power on code.

Both are fine for me - the typical (and the most trivial) test - compile the driver, 'kldunload' the previous one, load newly compiled and commit changes over it.
Right now the new power on sequence is used.

Jan 4 2019, 12:22 PM
s3erios_gmail.com accepted D18727: rtwn(4): RTL8188EE fixed power on code.

The current version is fine too - I'm using it right now :) But I will take this one to sync with OpenBSD.

Jan 4 2019, 4:22 AM
s3erios_gmail.com created D18742: (PR 125707): powerd(8): allow to force a method of battery state query.
Jan 4 2019, 3:44 AM

Jan 2 2019

s3erios_gmail.com added a comment to D15694: Ignoring rtwn(4) debug interrupts.

Not needed anymore; event handling was implemented in rS342677.

Jan 2 2019, 7:03 AM

Jul 3 2018

s3erios_gmail.com added a comment to D15694: Ignoring rtwn(4) debug interrupts.

the register is empty for 88e, so you will not see events from it

Jul 3 2018, 3:52 PM
s3erios_gmail.com added a comment to D15694: Ignoring rtwn(4) debug interrupts.

last time I've seen this code the path for classification was similar to rtwn_pci_intr() -> rtwn_classify() and then (in theory, this does not exist in HEAD yet) should be redirected to r88e_ratectl_tx_completed() when the event arrives

Jul 3 2018, 3:51 PM

Jun 12 2018

s3erios_gmail.com added a comment to D15692: Adding rtl8188ee driver to rtwn(4).

Can you attach next patches with context (like it is described in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview )

Jun 12 2018, 10:33 AM · Src Committers
s3erios_gmail.com added a comment to D15694: Ignoring rtwn(4) debug interrupts.

does it really need this loop? (AFAIR, you need to check for arrived event in rtwn_pci_intr() - and then classify it and pass to r88e_ratectl_tx_complete()

Jun 12 2018, 10:30 AM

Mar 19 2018

s3erios_gmail.com created D14731: net80211: represent rates via 'struct ieee80211_rate_t' / global rate indices (where possible).
Mar 19 2018, 2:18 AM

Mar 9 2018

s3erios_gmail.com created D14628: Wrap protection frame allocation into ieee80211_alloc_prot().
Mar 9 2018, 1:01 AM

Feb 25 2018

s3erios_gmail.com abandoned D12552: net80211: export interface unit number via SIOCG80211 ioctl (IEEE80211_IOC_UNIT request type).

Seems to be not needed anymore.

Feb 25 2018, 1:25 AM
s3erios_gmail.com abandoned D12553: wlandebug(8): use new IEEE80211_IOC_UNIT ioctl request.

Version which uses libifconfig was accepted / committed instead.

Feb 25 2018, 1:25 AM

Dec 29 2017

s3erios_gmail.com added a comment to D9806: net80211: handle VHT nodes in ieee80211_node_setuptxparms().

ping? (this part will be needed for Tx parameters - I'm going to store rate indices instead of raw rates in "new" struct ieee80211_txparam)

Dec 29 2017, 11:53 PM
s3erios_gmail.com added inline comments to D13161: net80211: sanitize input for ieee80211_output().
Dec 29 2017, 11:42 PM
s3erios_gmail.com updated the diff for D13161: net80211: sanitize input for ieee80211_output().

Drop KASSERT.

Dec 29 2017, 11:36 PM

Nov 19 2017

s3erios_gmail.com created D13161: net80211: sanitize input for ieee80211_output().
Nov 19 2017, 6:16 PM

Oct 16 2017

s3erios_gmail.com added a comment to D12555: wlandebug(8): obtain original interface name via ifconfig_get_orig_name().

Committed in r324657.

Oct 16 2017, 7:02 AM
s3erios_gmail.com abandoned D12555: wlandebug(8): obtain original interface name via ifconfig_get_orig_name().
Oct 16 2017, 7:02 AM

Oct 3 2017

s3erios_gmail.com added a comment to D12551: ifnet(9): split ifc_alloc_unit() (should make code a bit cleaner)..

Yes (but without reassigning *unit - it will not change after alloc_unr_specific() anyway).

Oct 3 2017, 7:10 AM

Oct 1 2017

s3erios_gmail.com added a comment to D12553: wlandebug(8): use new IEEE80211_IOC_UNIT ioctl request.

nope; however, libifconfig seems to be more appropriate for such things (so there are alternative versions in D12554 (libifconfig) and D12555 (wlandebug)).

Oct 1 2017, 1:31 PM
s3erios_gmail.com created D12555: wlandebug(8): obtain original interface name via ifconfig_get_orig_name().
Oct 1 2017, 1:26 PM
s3erios_gmail.com created D12554: libifconfig: allow to get original interface name via ifconfig_get_orig_name().
Oct 1 2017, 1:11 PM
s3erios_gmail.com added inline comments to D12553: wlandebug(8): use new IEEE80211_IOC_UNIT ioctl request.
Oct 1 2017, 12:10 AM

Sep 30 2017

s3erios_gmail.com created D12553: wlandebug(8): use new IEEE80211_IOC_UNIT ioctl request.
Sep 30 2017, 11:11 PM
s3erios_gmail.com created D12552: net80211: export interface unit number via SIOCG80211 ioctl (IEEE80211_IOC_UNIT request type).
Sep 30 2017, 10:46 PM
s3erios_gmail.com created D12551: ifnet(9): split ifc_alloc_unit() (should make code a bit cleaner)..
Sep 30 2017, 9:27 PM

Aug 30 2017

s3erios_gmail.com added inline comments to D12157: [net80211] add A-MSDU hardware decap sequence number range checking This is part one of a multi-part series aimed at supporting hardware decap'ed A-MSDU frames. Hardware decap'ed A-MSDU frames have a variety of unfun behaviours: * for now, they....
Aug 30 2017, 12:06 AM

Aug 22 2017

s3erios_gmail.com updated the diff for D11785: upgt: add some overflow checks.

Add some checks against actlen.

Aug 22 2017, 9:47 PM

Aug 21 2017

s3erios_gmail.com updated the diff for D11785: upgt: add some overflow checks.

Add memory wrap check.

Aug 21 2017, 8:11 AM
s3erios_gmail.com updated the diff for D11785: upgt: add some overflow checks.

Turn some KASSERT's into checks + add more size checks.

Aug 21 2017, 2:43 AM

Aug 20 2017

s3erios_gmail.com added inline comments to D11786: uath: fix varible types, add checks for descriptor / command header structure fields..
Aug 20 2017, 10:43 AM
s3erios_gmail.com updated the diff for D11786: uath: fix varible types, add checks for descriptor / command header structure fields..
Aug 20 2017, 10:38 AM

Aug 13 2017

s3erios_gmail.com added inline comments to D11785: upgt: add some overflow checks.
Aug 13 2017, 8:22 PM
s3erios_gmail.com updated the diff for D11786: uath: fix varible types, add checks for descriptor / command header structure fields..
  • Add more 'framelen' variable checks.
  • Check hdr->len before using it to calculate dlen.
Aug 13 2017, 7:51 PM
s3erios_gmail.com added inline comments to D11786: uath: fix varible types, add checks for descriptor / command header structure fields..
Aug 13 2017, 7:16 PM

Aug 7 2017

s3erios_gmail.com updated the diff for D11786: uath: fix varible types, add checks for descriptor / command header structure fields..

Address some possible buffer over-reads.

Aug 7 2017, 12:04 AM

Jul 30 2017

s3erios_gmail.com created D11786: uath: fix varible types, add checks for descriptor / command header structure fields..
Jul 30 2017, 10:49 PM
s3erios_gmail.com created D11785: upgt: add some overflow checks.
Jul 30 2017, 10:37 PM

Jul 23 2017

s3erios_gmail.com created D11705: rtwn_usb: add support for fragmented Rx.
Jul 23 2017, 5:44 PM

May 21 2017

s3erios_gmail.com added a comment to D10728: iwn: (partially) rewrite A-MPDU Tx path.

I can't test iwn(4) with 4965AGN - firmware throws FH_ERROR's during testing with and/or without this patch when HT rates are in use (A-MPDU / HT40 / SGI status does not matter).
Scanning is not reliable too - sometimes AP is shown on (almost) all 5GHz channels, while it is present on 44th channel only -> this results in NMI_INTERRUPT_WDG error during next scan.

May 21 2017, 5:32 PM

May 16 2017

s3erios_gmail.com added inline comments to D10728: iwn: (partially) rewrite A-MPDU Tx path.
May 16 2017, 7:16 AM
s3erios_gmail.com created D10753: net80211: clear i_seq for A-MPDU frames.
May 16 2017, 6:34 AM

May 15 2017

s3erios_gmail.com added a comment to D10728: iwn: (partially) rewrite A-MPDU Tx path.

node / mbuf NULL checks now are omitted

not really omitted - just considered as 'correct' - and ignored (see SCD_QUERY status comment + workarounds cannot cover all possible cases).

May 15 2017, 12:34 AM
s3erios_gmail.com created D10728: iwn: (partially) rewrite A-MPDU Tx path.
May 15 2017, 12:29 AM

Apr 9 2017

s3erios_gmail.com accepted D10328: [net80211] refactor out "add slot" and "purge slot" for A-MPDU This is in preparation for A-MSDU decap in A-MPDU support. * refactor out the code to purge a single reorder slot into ampdu_rx_purge_slot(). * refactor out the code to add a frame....
Apr 9 2017, 8:27 AM

Apr 3 2017

s3erios_gmail.com accepted D10240: [net80211] refactor out code into ampdu_dispatch_slot(). This is again in preparation for A-MSDU in A-MPDU offload support, where A-MSDUs are decapped into standalone 802.11/802.3 MPDUs but with the same seqno/crypto IV...
Apr 3 2017, 6:39 AM

Apr 1 2017

s3erios_gmail.com accepted D10208: [net80211] refactor the AMPDU RX window stuff!.
Apr 1 2017, 5:57 PM

Mar 26 2017

s3erios_gmail.com created D10146: iwm: fix build without IWM_DEBUG.
Mar 26 2017, 5:50 PM

Mar 22 2017

s3erios_gmail.com created D10106: iwn: deduplicate some parts of iwn_tx_data() and iwn_tx_data_raw().
Mar 22 2017, 10:02 PM

Mar 19 2017

s3erios_gmail.com added a comment to D9984: net80211: add a timer to flush fast-frames queues.

Yeah, this creates unneeded overhead for permanent data flow (and not so noticeable at the end, since it called only once); I will remove it.
BTW, there is another problem: with default ieee80211_ffagemax there is almost no chances to get an aggregate; typically, the queue is flushed earlier.

I was seeing two-frame AMSDUs during UDP TX tests. I'll update my test devices and re-test all of this and get back to you.

Mar 19 2017, 10:29 PM
s3erios_gmail.com added a comment to D9984: net80211: add a timer to flush fast-frames queues.

Yeah, this creates unneeded overhead for permanent data flow (and not so noticeable at the end, since it called only once); I will remove it.
BTW, there is another problem: with default ieee80211_ffagemax there is almost no chances to get an aggregate; typically, the queue is flushed earlier.

Mar 19 2017, 9:50 PM

Mar 13 2017

s3erios_gmail.com added a comment to D9984: net80211: add a timer to flush fast-frames queues.

The whole M_AGE thing is a bit "special". For fast frames I bet yeah, it's just the right age for the first frame. For the say power save queue, it's supposed to be the age of the frame as a delta from the previous one. If it isn't doing that then it's a bug.

Mar 13 2017, 8:11 AM
s3erios_gmail.com added a comment to D9984: net80211: add a timer to flush fast-frames queues.

Hm, do you think it'd be worth to do something like "ieee80211_tx_end() / ieee80211_rx_end()" as a kind of driver-driven "I've finished TX/RX loop, please do any deferred/interesting work now" in drivers?
I would rather there be something that was generic versus the special cased SUPERG stuff. (And that way we don't need to ifdef it for superg.)

Mar 13 2017, 8:00 AM
s3erios_gmail.com accepted D9986: [net80211] begin migrating WME parameters to be per-vap..

Probably wme_state[4] (in struct ieee80211_wme_state, ieee80211_proto.h) should be removed too?

Mar 13 2017, 7:41 AM
s3erios_gmail.com added a comment to D9984: net80211: add a timer to flush fast-frames queues.

IMHO, M_AGE_*() is useless for both powersave & stage queues - the first frame always has AGE set to some default value + it is always 0 for subsequent frames; how is it supposed to work?

Mar 13 2017, 12:25 AM
s3erios_gmail.com created D9984: net80211: add a timer to flush fast-frames queues.
Mar 13 2017, 12:17 AM

Mar 3 2017

s3erios_gmail.com updated the diff for D9871: net80211: fix ieee80211_htrateset setup, return EINVAL for an unsupported ucast/mcast/mgmt HT rate.

Init htrateset a bit later

Mar 3 2017, 12:25 AM
s3erios_gmail.com retitled D9871: net80211: fix ieee80211_htrateset setup, return EINVAL for an unsupported ucast/mcast/mgmt HT rate from net80211: fix ieee80211_rateset setup, return EINVAL for an unsupported ucast/mcast/mgmt HT rate to net80211: fix ieee80211_htrateset setup, return EINVAL for an unsupported ucast/mcast/mgmt HT rate.
Mar 3 2017, 12:23 AM
s3erios_gmail.com retitled D9871: net80211: fix ieee80211_htrateset setup, return EINVAL for an unsupported ucast/mcast/mgmt HT rate from to net80211: fix ieee80211_rateset setup, return EINVAL for an unsupported ucast/mcast/mgmt HT rate.
Mar 3 2017, 12:22 AM

Feb 26 2017

s3erios_gmail.com abandoned D5055: iwn: remove internal taskqueue.

It was additionaly reused for 'rftoggle_task' (and may be reused few more times in future).

Feb 26 2017, 7:52 PM
s3erios_gmail.com retitled D9811: net80211 drivers: fix rate setup for EAPOL frames, obtain Tx parameters directly from the node from to net80211 drivers: fix rate setup for EAPOL frames, obtain Tx parameters directly from the node.
Feb 26 2017, 7:48 PM
s3erios_gmail.com retitled D9806: net80211: handle VHT nodes in ieee80211_node_setuptxparms() from to net80211: handle VHT nodes in ieee80211_node_setuptxparms().
Feb 26 2017, 3:51 PM

Feb 25 2017

s3erios_gmail.com retitled D9797: iwn: some initialization / RF switch state change fixes from to iwn: some initialization / RF switch state change fixes.
Feb 25 2017, 12:27 AM

Feb 12 2017

s3erios_gmail.com updated the diff for D9559: snd_hda(4): reserve one more sequence number (14) for headphones redirection.

s/has/have (twice)

Feb 12 2017, 7:36 PM
s3erios_gmail.com retitled D9559: snd_hda(4): reserve one more sequence number (14) for headphones redirection from to snd_hda(4): reserve one more sequence number (14) for headphones redirection.
Feb 12 2017, 7:14 PM

Jan 30 2017

s3erios_gmail.com added a comment to D9369: net80211: cleanup ic_flags / iv_flags.

Hmm, so what to do with IEEE80211_F_COMP / IEEE80211_F_TXPOW_FIXED (AUTO/OFF) ?

Jan 30 2017, 10:22 PM

Jan 29 2017

s3erios_gmail.com accepted D9357: [net80211] address seqno allocation for group addressed frames.
Jan 29 2017, 10:27 AM

Jan 28 2017

s3erios_gmail.com retitled D9369: net80211: cleanup ic_flags / iv_flags from to net80211: cleanup ic_flags / iv_flags.
Jan 28 2017, 8:22 PM
s3erios_gmail.com added inline comments to D9357: [net80211] address seqno allocation for group addressed frames.
Jan 28 2017, 3:32 PM
s3erios_gmail.com added a comment to D9195: [net80211] initial "driver does sequence number handling" This implements: * optionally deferring sequence number allocation into the driver * don't grab/release the net80211 TX lock if the driver does sequence number allocation * write a....

Other parts look fine.

Jan 28 2017, 3:11 PM

Jan 27 2017

s3erios_gmail.com added inline comments to D9357: [net80211] address seqno allocation for group addressed frames.
Jan 27 2017, 8:30 PM

Jan 23 2017

s3erios_gmail.com retitled D9308: Garbage collect IFT_IEEE80211 from to Garbage collect IFT_IEEE80211.
Jan 23 2017, 10:30 PM

Jan 21 2017

s3erios_gmail.com retitled D9277: ath: adapt LDPC support checks from to ath: adapt LDPC support checks.
Jan 21 2017, 4:25 PM
s3erios_gmail.com added a comment to D9268: net80211: allow to configure LDPC support.

Ideally nodes without NODE_HT / NODE_VHT set won't even do HT/VHT bits. If we have that happening we should fix it. :-)

Jan 21 2017, 1:02 PM
s3erios_gmail.com updated the diff for D9268: net80211: allow to configure LDPC support.

Fix few typos

Jan 21 2017, 11:02 AM
s3erios_gmail.com added a comment to D9268: net80211: allow to configure LDPC support.

I'm unsure about IEEE80211_NODE_* flags setup in ieee80211_ht.c - if user will play enough with ifconfig(8) parameters some nodes may be created without the flag but with ni->ni_htcap and vap->iv_flags_ht bits set.

Jan 21 2017, 12:06 AM
s3erios_gmail.com retitled D9268: net80211: allow to configure LDPC support from to net80211: allow to configure LDPC support.
Jan 21 2017, 12:00 AM

Jan 18 2017

s3erios_gmail.com added inline comments to D9195: [net80211] initial "driver does sequence number handling" This implements: * optionally deferring sequence number allocation into the driver * don't grab/release the net80211 TX lock if the driver does sequence number allocation * write a....
Jan 18 2017, 11:25 PM

Jan 12 2017

s3erios_gmail.com updated the diff for D9021: rtwn: export more stats to net80211.
  • Remove IEEE80211_RX_F_DECRYPTED flag setup.
  • Call ieee80211_add_rx_params() in rtwn_rx_common() (and drop __DECONST); ieee80211_input_mimo() will check mbuf tag presence anyway.
  • Fix possible NULL pointer dereference (after ieee80211_find_rxnode() call).
  • Do not try to define R92C_RX_DRVINFO_SZ_DEF in if_rtwnvar.h; it is always included before r92c_reg.h.
  • Fix rate mask in r12a_rx_radiotap_flags().
Jan 12 2017, 12:17 AM

Jan 2 2017

s3erios_gmail.com retitled D9021: rtwn: export more stats to net80211 from to rtwn: export more stats to net80211..
Jan 2 2017, 2:35 PM

Dec 25 2016

s3erios_gmail.com added a comment to D8903: rtwn: add radar detection support for RTL8821AU (disabled by default).

Yes, this is USB NIC.

Dec 25 2016, 10:16 PM
s3erios_gmail.com retitled D8903: rtwn: add radar detection support for RTL8821AU (disabled by default) from to rtwn: add radar detection support for RTL8821AU (disabled by default).
Dec 25 2016, 6:53 PM

Dec 21 2016

s3erios_gmail.com accepted D8804: iwn: DMA fixes, and race condition fix.
Dec 21 2016, 9:22 PM

Dec 15 2016

s3erios_gmail.com added inline comments to D8804: iwn: DMA fixes, and race condition fix.
Dec 15 2016, 9:29 PM
s3erios_gmail.com added inline comments to D8804: iwn: DMA fixes, and race condition fix.
Dec 15 2016, 7:12 AM

Dec 10 2016

s3erios_gmail.com accepted D8717: Fix iwn(4) on ARM: perform BUS_DMASYNC_PREREAD when initializing RX buffer.
Dec 10 2016, 8:47 AM

Dec 4 2016

s3erios_gmail.com retitled D8706: rsu: add hardware crypto support (WEP, TKIP and CCMP) from to rsu: add hardware crypto support (WEP, TKIP and CCMP).
Dec 4 2016, 1:30 AM
s3erios_gmail.com accepted D8704: Switch run(4) to use a bitmap for debug printf()s.
Dec 4 2016, 12:17 AM

Nov 27 2016

s3erios_gmail.com abandoned D5151: rsu: cancel scan (via ieee80211_cancel_scan()) when it fails.

Committed as a part of rS309210

Nov 27 2016, 1:16 PM

Nov 21 2016

s3erios_gmail.com added inline comments to D8365: [net80211] add initial support for HT upgrade of IBSS nodes. * add ability for IBSS nodes to be upgraded when it sees HT IEs * add HT IEs to probe requests/responses and beacons * send a probe request after bringing up a node so we can....
Nov 21 2016, 8:47 PM