- User Since
- May 26 2015, 5:01 PM (190 w, 5 d)
Mon, Jan 7
Actually, the code tries to find a 'next' (fallback) rate, which will be used if transmission on the current rate fails; the code will be incorrect, when HT support will be added to the driver (but currently it should 'just work').
Sun, Jan 6
Fri, Jan 4
powerd.8:27:date not today, January 4, 2019:.Dd [January 3, 2019]
Both are fine for me - the typical (and the most trivial) test - compile the driver, 'kldunload' the previous one, load newly compiled and commit changes over it.
Right now the new power on sequence is used.
The current version is fine too - I'm using it right now :) But I will take this one to sync with OpenBSD.
Wed, Jan 2
Not needed anymore; event handling was implemented in rS342677.
Jul 3 2018
the register is empty for 88e, so you will not see events from it
last time I've seen this code the path for classification was similar to rtwn_pci_intr() -> rtwn_classify() and then (in theory, this does not exist in HEAD yet) should be redirected to r88e_ratectl_tx_completed() when the event arrives
Jun 12 2018
Can you attach next patches with context (like it is described in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview )
does it really need this loop? (AFAIR, you need to check for arrived event in rtwn_pci_intr() - and then classify it and pass to r88e_ratectl_tx_complete()
Mar 19 2018
Mar 9 2018
Feb 25 2018
Seems to be not needed anymore.
Version which uses libifconfig was accepted / committed instead.
Dec 29 2017
ping? (this part will be needed for Tx parameters - I'm going to store rate indices instead of raw rates in "new" struct ieee80211_txparam)
Nov 19 2017
Oct 16 2017
Committed in r324657.
Oct 3 2017
Yes (but without reassigning *unit - it will not change after alloc_unr_specific() anyway).
Oct 1 2017
Sep 30 2017
Aug 30 2017
Aug 22 2017
Add some checks against actlen.
Aug 21 2017
Add memory wrap check.
Turn some KASSERT's into checks + add more size checks.
Aug 20 2017
Aug 13 2017
- Add more 'framelen' variable checks.
- Check hdr->len before using it to calculate dlen.
Aug 7 2017
Address some possible buffer over-reads.
Jul 30 2017
Jul 23 2017
May 21 2017
I can't test iwn(4) with 4965AGN - firmware throws FH_ERROR's during testing with and/or without this patch when HT rates are in use (A-MPDU / HT40 / SGI status does not matter).
Scanning is not reliable too - sometimes AP is shown on (almost) all 5GHz channels, while it is present on 44th channel only -> this results in NMI_INTERRUPT_WDG error during next scan.
May 16 2017
May 15 2017
node / mbuf NULL checks now are omitted
not really omitted - just considered as 'correct' - and ignored (see SCD_QUERY status comment + workarounds cannot cover all possible cases).
Apr 9 2017
Apr 3 2017
Apr 1 2017
Mar 26 2017
Mar 22 2017
Mar 19 2017
Yeah, this creates unneeded overhead for permanent data flow (and not so noticeable at the end, since it called only once); I will remove it.
BTW, there is another problem: with default ieee80211_ffagemax there is almost no chances to get an aggregate; typically, the queue is flushed earlier.
Mar 13 2017
Probably wme_state (in struct ieee80211_wme_state, ieee80211_proto.h) should be removed too?
IMHO, M_AGE_*() is useless for both powersave & stage queues - the first frame always has AGE set to some default value + it is always 0 for subsequent frames; how is it supposed to work?
Mar 3 2017
Init htrateset a bit later
Feb 26 2017
It was additionaly reused for 'rftoggle_task' (and may be reused few more times in future).
Feb 25 2017
Feb 12 2017
Jan 30 2017
Hmm, so what to do with IEEE80211_F_COMP / IEEE80211_F_TXPOW_FIXED (AUTO/OFF) ?
Jan 29 2017
Jan 28 2017
Other parts look fine.
Jan 27 2017
Jan 23 2017
Jan 21 2017
Fix few typos
I'm unsure about IEEE80211_NODE_* flags setup in ieee80211_ht.c - if user will play enough with ifconfig(8) parameters some nodes may be created without the flag but with ni->ni_htcap and vap->iv_flags_ht bits set.
Jan 18 2017
Jan 12 2017
- Remove IEEE80211_RX_F_DECRYPTED flag setup.
- Call ieee80211_add_rx_params() in rtwn_rx_common() (and drop __DECONST); ieee80211_input_mimo() will check mbuf tag presence anyway.
- Fix possible NULL pointer dereference (after ieee80211_find_rxnode() call).
- Do not try to define R92C_RX_DRVINFO_SZ_DEF in if_rtwnvar.h; it is always included before r92c_reg.h.
- Fix rate mask in r12a_rx_radiotap_flags().
Jan 2 2017
Dec 25 2016
Yes, this is USB NIC.
Dec 21 2016
Dec 15 2016
Dec 10 2016
Dec 4 2016
Nov 27 2016
Committed as a part of rS309210