Page MenuHomeFreeBSD

ryan_freqlabs.com (Ryan Moeller)
OS Engineer @ iXsystems, Inc.

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 2:56 AM (192 w, 2 d)

Recent Activity

Thu, Mar 26

ryan_freqlabs.com added a comment to D21733: loader: Fully reset terminal settings, not just colors.

@tsoome is efi console / teken in shape for this now?

Thu, Mar 26, 8:13 PM

Wed, Mar 18

ryan_freqlabs.com created D24115: loader: Add a "kernel.loaded" hook.
Wed, Mar 18, 3:00 PM

Mon, Mar 16

ryan_freqlabs.com created D24086: Update OpenZFS ports.
Mon, Mar 16, 6:28 AM

Feb 27 2020

ryan_freqlabs.com added a reviewer for D23854: Unbreak openzfs ports: wg.
Feb 27 2020, 7:46 PM
ryan_freqlabs.com created D23854: Unbreak openzfs ports.
Feb 27 2020, 5:55 PM

Feb 26 2020

ryan_freqlabs.com accepted D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 26 2020, 9:08 AM

Feb 25 2020

ryan_freqlabs.com requested changes to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..

This is getting really close to the finish line.

Feb 25 2020, 3:26 PM

Feb 23 2020

ryan_freqlabs.com added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 23 2020, 3:15 AM

Feb 14 2020

ryan_freqlabs.com added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 14 2020, 3:02 PM
ryan_freqlabs.com added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 14 2020, 2:59 PM

Feb 6 2020

ryan_freqlabs.com added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Feb 6 2020, 1:54 AM

Jan 26 2020

ryan_freqlabs.com added a comment to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..

I'll be taking a closer look when I get a chance but at a glance at the diff this looks like a much cleaner change now. Thank you for taking the time to work on it!

Jan 26 2020, 11:58 PM

Jan 23 2020

ryan_freqlabs.com added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Jan 23 2020, 2:44 PM
ryan_freqlabs.com added inline comments to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Jan 23 2020, 2:32 PM

Jan 18 2020

ryan_freqlabs.com requested changes to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..

I have not inspected the code in depth, but there are a number of style violations that jump out at a glance. Fixing these various nits will make the changes easier to read for reviewers. Rather than clutter up the diff I'll just mention the key points:

  • Several files appear to have been edited with 4-space indentation settings rather than hard tabs, in contrast with the surrounding code. The different whitespace is confusing/frustrating.
  • A bunch of added functions in block_if.c should have a newline after the function return type, rather than a bunch of horizontal space.

See style(9) as a more detailed guide, but in general matching the style of surrounding code is most desirable.

Jan 18 2020, 7:46 PM

Jan 17 2020

ryan_freqlabs.com accepted D23232: Fix regression in bsdinstall post r356740 - partedit errno(2) 21 EISDIR.

Sorry about that!

Jan 17 2020, 1:28 PM

Jan 16 2020

ryan_freqlabs.com added a comment to D23211: setextattr: Increase stdin buffer size to 4096.

@asomers Will you commit this for me? I don't have the bit. Thanks!

Jan 16 2020, 9:03 PM
ryan_freqlabs.com created D23211: setextattr: Increase stdin buffer size to 4096.
Jan 16 2020, 7:33 PM
ryan_freqlabs.com added a comment to D23199: random(6): Fix off-by-one error.

@cem Will you commit this for me? I don't have the bit. Thanks!

Jan 16 2020, 6:20 PM
ryan_freqlabs.com updated the test plan for D23199: random(6): Fix off-by-one error.
Jan 16 2020, 9:33 AM
ryan_freqlabs.com updated the summary of D23199: random(6): Fix off-by-one error.
Jan 16 2020, 9:33 AM
ryan_freqlabs.com created D23199: random(6): Fix off-by-one error.
Jan 16 2020, 9:32 AM

Jan 15 2020

ryan_freqlabs.com added a comment to D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

@mckusick I would like to MFC your EINTEGRITY change to stable/12 along with this change. Does this seem reasonable? At a glance the only merge conflict is that stable/12 doesn't have contrib/libc++, so that part of the patch would be dropped. Anything else to look out for?
Thanks in advance!

Jan 15 2020, 4:06 PM

Jan 14 2020

ryan_freqlabs.com accepted D23132: libzfs: add zfs_mount_at, switch libbe to it.

Looks reasonable. This will make its way into ZoF next time we rebase, since there aren't any platform-specific files changed. The port should be updated shortly thereafter.

Jan 14 2020, 5:17 PM
ryan_freqlabs.com added a comment to D22979: bsdinstall: Use TMPDIR if set.

Sure! I'll try and get it committed today.

Jan 14 2020, 4:20 PM

Jan 11 2020

ryan_freqlabs.com updated the diff for D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

Add a comment explaining the motivation for the mapping.

Jan 11 2020, 9:36 AM

Jan 7 2020

ryan_freqlabs.com updated the diff for D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.

Incorporate feedback. Map the constants to existing errnos instead of adding messages for old numbers.

Jan 7 2020, 8:50 PM
ryan_freqlabs.com retitled D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos from Add error strings for ECKSUM and EFRAGS from ZFS to Map ECKSUM and EFRAGS from ZFS onto real errnos.
Jan 7 2020, 8:48 PM

Jan 2 2020

ryan_freqlabs.com added a comment to D22979: bsdinstall: Use TMPDIR if set.

@bcran Thanks! Would you mind committing this for me? I don't have the bit.

Jan 2 2020, 5:00 PM
ryan_freqlabs.com abandoned D22937: bsdinstall: Clean up bsdinstall-esps file.

Incorporated in the TMPDIR revision: D22979

Jan 2 2020, 4:44 PM

Dec 31 2019

ryan_freqlabs.com updated the diff for D22979: bsdinstall: Use TMPDIR if set.

Use $BSDINSTALL_CHROOT in place of /mnt for umount.

Dec 31 2019, 12:07 AM

Dec 30 2019

ryan_freqlabs.com created D22979: bsdinstall: Use TMPDIR if set.
Dec 30 2019, 11:57 PM
ryan_freqlabs.com created D22973: Map ECKSUM and EFRAGS from ZFS onto real errnos.
Dec 30 2019, 9:13 PM
ryan_freqlabs.com added inline comments to D22937: bsdinstall: Clean up bsdinstall-esps file.
Dec 30 2019, 5:51 PM

Dec 27 2019

ryan_freqlabs.com updated the diff for D22937: bsdinstall: Clean up bsdinstall-esps file.

Add context to diff.

Dec 27 2019, 8:18 PM
ryan_freqlabs.com updated the summary of D22937: bsdinstall: Clean up bsdinstall-esps file.
Dec 27 2019, 8:17 PM
ryan_freqlabs.com created D22937: bsdinstall: Clean up bsdinstall-esps file.
Dec 27 2019, 8:16 PM

Nov 12 2019

ryan_freqlabs.com added inline comments to D22328: Clean commercial ISP.
Nov 12 2019, 4:54 PM

Oct 31 2019

ryan_freqlabs.com added inline comments to D22194: Colored output for err(3).
Oct 31 2019, 4:05 PM

Oct 21 2019

ryan_freqlabs.com added a comment to D22077: Speed up "zpool import" in the presence of many zvols.

I have recently looked at this function to port adapt it for ZoF. I like the overall idea here, but as a nit please do try matching the surrounding style. I would also find it easier to follow without the extra negations. Calling the bool skip_zvols would read more naturally to me.

Oct 21 2019, 7:41 PM

Oct 13 2019

ryan_freqlabs.com added inline comments to D21989: Use enumeration to indicate swap almost full and full, instead of 2 variables..
Oct 13 2019, 3:49 PM

Oct 8 2019

ryan_freqlabs.com added a comment to D21385: Use makefs -t msdos in make_esp_file.

makefs become part of the bootstrap tools

Oct 8 2019, 8:37 PM
ryan_freqlabs.com added a comment to D21385: Use makefs -t msdos in make_esp_file.

How to fix it?

Oct 8 2019, 8:29 PM

Sep 26 2019

ryan_freqlabs.com updated the diff for D21733: loader: Fully reset terminal settings, not just colors.

Use the correct escape sequence for reset in forth.

Sep 26 2019, 2:55 PM
ryan_freqlabs.com added a comment to D21733: loader: Fully reset terminal settings, not just colors.

while we've transitioned to teken, it looks like it eats the ESC c

Sep 26 2019, 2:19 AM

Sep 25 2019

ryan_freqlabs.com added a comment to D21733: loader: Fully reset terminal settings, not just colors.

This aims to reset more of the state to defaults, not just colors. Things like the scroll region for example, so we don't have all the output stuck on one line. There are a multitude of software/firmware/hardware issues that can cause the state to be unfavorable at boot. Loose serial connections, buggy firmware, etc. tsoome's work complements this change rather than invalidating it.

Sep 25 2019, 10:20 PM

Sep 24 2019

ryan_freqlabs.com added a comment to D21733: loader: Fully reset terminal settings, not just colors.

I was a bit slow taking the screenshot and caught the menu mid-scroll but here it is in a black on white terminal:

Sep 24 2019, 8:01 PM

Sep 23 2019

ryan_freqlabs.com updated the diff for D21733: loader: Fully reset terminal settings, not just colors.

Eliminate menu local per review.

Sep 23 2019, 8:27 PM
ryan_freqlabs.com updated the diff for D21733: loader: Fully reset terminal settings, not just colors.

I moved the UEFI console resize to before the screen reset in loader.lua to be consistent with the order of this sequence in the forth loader.rc version. In doing so I noticed a few if blocks for the menu could be combined, so I combined them.

Sep 23 2019, 7:40 PM

Sep 20 2019

ryan_freqlabs.com planned changes to D21733: loader: Fully reset terminal settings, not just colors.

Sorry, I do need to take a second look at this one. My terminal doesn't seem to be resetting the font brightness correctly when loader_color=YES in a bhyve VM looking at the serial console. Everything looks bolded until I reset the terminal again in the shell using `printf '\033c' and then it goes back to normal.

Sep 20 2019, 8:23 PM
ryan_freqlabs.com created D21733: loader: Fully reset terminal settings, not just colors.
Sep 20 2019, 7:42 PM
ryan_freqlabs.com added a comment to D21732: loader: Respect loader_color=YES for serial consoles.

Thanks! Can I ask someone with a commit bit to please put this in for me?

Sep 20 2019, 7:32 PM
ryan_freqlabs.com updated the diff for D21732: loader: Respect loader_color=YES for serial consoles.

Fixed up nearby code as requested

Sep 20 2019, 7:29 PM
ryan_freqlabs.com created D21732: loader: Respect loader_color=YES for serial consoles.
Sep 20 2019, 7:06 PM

Sep 19 2019

ryan_freqlabs.com abandoned D17169: Add quirk to disable NCQ TRIM for Samsung 860 SSDs.
Sep 19 2019, 2:44 AM

Sep 16 2019

ryan_freqlabs.com updated the diff for D21441: Add iflag=fullblock to dd.

Delete redundant setting of in.dbsz in error case.

Sep 16 2019, 1:20 PM
ryan_freqlabs.com updated the diff for D21441: Add iflag=fullblock to dd.

Fixed man page additions. Thanks, @bcr!

Sep 16 2019, 1:10 PM

Sep 10 2019

ryan_freqlabs.com updated the diff for D21441: Add iflag=fullblock to dd.

Make conv=sync and iflag=fullblock mutually exclusive rather than silently ignoring the iflag.

Sep 10 2019, 4:24 PM

Sep 3 2019

ryan_freqlabs.com closed D21370: Add conv=fsync flag to dd.

Committed as rS351770

Sep 3 2019, 6:40 PM
ryan_freqlabs.com added reviewers for D21441: Add iflag=fullblock to dd: jilles, imp.
Sep 3 2019, 5:46 PM
ryan_freqlabs.com added reviewers for D21422: Add oflag=fsync and oflag=sync capability to dd: jilles, imp.
Sep 3 2019, 5:46 PM
ryan_freqlabs.com added reviewers for D21376: dd: Check result of close(2) for errors: mmacy, imp.
Sep 3 2019, 5:45 PM
ryan_freqlabs.com added reviewers for D21373: Add conv=fdatasync flag to dd: mmacy, imp.
Sep 3 2019, 5:45 PM

Aug 28 2019

ryan_freqlabs.com added inline comments to D21370: Add conv=fsync flag to dd.
Aug 28 2019, 7:48 PM
ryan_freqlabs.com retitled D20118: Fix erroneous assert in libzfs diff from Fix erronious assert in libzfs diff to Fix erroneous assert in libzfs diff.
Aug 28 2019, 1:35 PM

Aug 27 2019

ryan_freqlabs.com created D21441: Add iflag=fullblock to dd.
Aug 27 2019, 6:25 PM

Aug 26 2019

ryan_freqlabs.com added a comment to D21422: Add oflag=fsync and oflag=sync capability to dd.

I also plan to add support for iflag=fullblock in a follow-up revision.

Aug 26 2019, 8:55 PM
ryan_freqlabs.com created D21422: Add oflag=fsync and oflag=sync capability to dd.
Aug 26 2019, 8:53 PM

Aug 23 2019

ryan_freqlabs.com created D21385: Use makefs -t msdos in make_esp_file.
Aug 23 2019, 8:25 PM
ryan_freqlabs.com updated the summary of D21376: dd: Check result of close(2) for errors.
Aug 23 2019, 5:41 PM
ryan_freqlabs.com created D21376: dd: Check result of close(2) for errors.
Aug 23 2019, 1:45 PM

Aug 22 2019

ryan_freqlabs.com added a comment to D21373: Add conv=fdatasync flag to dd.

I will check the result of close(2) in a follow-up patch as suggested in PR229616

Aug 22 2019, 11:39 PM
ryan_freqlabs.com created D21373: Add conv=fdatasync flag to dd.
Aug 22 2019, 8:44 PM
ryan_freqlabs.com updated the summary of D21370: Add conv=fsync flag to dd.
Aug 22 2019, 7:09 PM
ryan_freqlabs.com added a comment to D21370: Add conv=fsync flag to dd.

I am planning a followup to add the fdatasync flag, as well.

Aug 22 2019, 7:08 PM
ryan_freqlabs.com created D21370: Add conv=fsync flag to dd.
Aug 22 2019, 7:07 PM

Aug 20 2019

ryan_freqlabs.com added a comment to D20685: Relax compat.linux.osrelease checks.

What is the motivation for being able to set 'compat.linux.osrelease=3.10.0-957.12.1.el7.x86_64'?

Aug 20 2019, 2:39 AM

Aug 19 2019

ryan_freqlabs.com updated ryan_freqlabs.com.
Aug 19 2019, 10:36 PM

Aug 18 2019

ryan_freqlabs.com created D21316: Expand description of image-size in makefs(8).
Aug 18 2019, 3:25 PM

Aug 16 2019

ryan_freqlabs.com added a comment to D21288: ping: move in_cksum() to a separate source file.
In D21288#462858, @sucanjan_gmail.com wrote:

I didn't put any copyright notice in utils.c because I didn't know what part of the copyright information to take from ping.c. Could you please help me with this?

Aug 16 2019, 9:47 PM
ryan_freqlabs.com added a comment to D21263: tap: add support for virtio-net offloads.

Thank you for making this happen! I'm glad that you managed to reuse some code from ptnet. Is taking advantage of these pieces in vtnet on your radar as well?

Aug 16 2019, 1:58 AM

Jul 18 2019

D17103: Add runtime option for all second-stage boot blocks to reset terminal is now accepted and ready to land.
Jul 18 2019, 2:48 AM

Jul 17 2019

ryan_freqlabs.com added inline comments to D17102: Add build-time option to boot0sio to reset terminal.
Jul 17 2019, 7:32 PM
D17102: Add build-time option to boot0sio to reset terminal is now accepted and ready to land.

Thank you!

Jul 17 2019, 7:31 PM
ryan_freqlabs.com added a comment to D17103: Add runtime option for all second-stage boot blocks to reset terminal.

Whoops, spotted a few more spelling errors.

Jul 17 2019, 7:25 PM

Jul 16 2019

ryan_freqlabs.com added inline comments to D17102: Add build-time option to boot0sio to reset terminal.
Jul 16 2019, 1:19 PM
ryan_freqlabs.com added inline comments to D17103: Add runtime option for all second-stage boot blocks to reset terminal.
Jul 16 2019, 1:04 PM

Jun 13 2019

ryan_freqlabs.com added a comment to D20498: Add test cases for epair.

By the way, I don't have commit access, so someone else will have to volunteer to commit this, please. Thanks!

Jun 13 2019, 3:18 AM

Jun 2 2019

ryan_freqlabs.com updated the diff for D20498: Add test cases for epair.

Mention PR for panic in ipv6 skip message.

Jun 2 2019, 1:23 AM

Jun 1 2019

ryan_freqlabs.com abandoned D20168: Start testing cloned interfaces.

I have created a new revision for just the epair tests here: https://reviews.freebsd.org/D20498

Jun 1 2019, 11:52 PM · network
ryan_freqlabs.com created D20498: Add test cases for epair.
Jun 1 2019, 11:48 PM

May 20 2019

ryan_freqlabs.com added a comment to D20118: Fix erroneous assert in libzfs diff.

ZoL commit: https://github.com/zfsonlinux/zfs/commit/9dc41a769df164875d974c2431b2453e70e16c41

May 20 2019, 6:08 PM

May 6 2019

ryan_freqlabs.com added a comment to D20168: Start testing cloned interfaces.

I should also note that there are panics in the lagg tests, described in bugzilla here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234135

May 6 2019, 7:04 AM · network
ryan_freqlabs.com added a comment to D20168: Start testing cloned interfaces.

Perhaps the panics currently requiring tests to be skipped should be fixed before the skipped tests are enabled. Multicast cleanup is pending in the following revisions that I am aware of:
https://reviews.freebsd.org/D19886
https://reviews.freebsd.org/D20070

May 6 2019, 6:59 AM · network
ryan_freqlabs.com created D20168: Start testing cloned interfaces.
May 6 2019, 6:49 AM · network

May 1 2019

ryan_freqlabs.com created D20118: Fix erroneous assert in libzfs diff.
May 1 2019, 1:06 AM

Apr 30 2019

ryan_freqlabs.com added a comment to D19886: Fix numerous refcount bugs in multicast ....

before running tests:

ether_multi    17     2K       -       17  16,32,64,128
   in_multi     2     1K       -        2  256
  in6_multi    15     2K       -       15  32,256
Apr 30 2019, 8:39 PM
ryan_freqlabs.com added a comment to D19886: Fix numerous refcount bugs in multicast ....

I have been running the tests in tests/sys/net with Matt's patch. Many of the test cases in if_clone_test are currently skipped due to panics, and with this patch I am now able to complete a run with those tests enabled. Doing so with mdnsresponder running exposes a different issue in an lo(4) test case, which will be something else to look into. I have also added test cases for epair(4), which pass as well. I will be putting my changes to enable these tests and add the epair test cases up for review shortly.

Apr 30 2019, 4:33 PM

Mar 22 2019

ryan_freqlabs.com updated the diff for D19640: oce: Simplify probe method.

Use existing struct pci_device_table and related macros as suggested by @imp

Mar 22 2019, 12:04 AM

Mar 19 2019

ryan_freqlabs.com created D19640: oce: Simplify probe method.
Mar 19 2019, 9:14 AM