Page MenuHomeFreeBSD

ryan_freqlabs.com (Ryan Moeller)
Resources

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2016, 2:56 AM (151 w, 2 d)

Recent Activity

Thu, Jun 13

ryan_freqlabs.com added a comment to D20498: Add test cases for epair.

By the way, I don't have commit access, so someone else will have to volunteer to commit this, please. Thanks!

Thu, Jun 13, 3:18 AM

Sun, Jun 2

ryan_freqlabs.com updated the diff for D20498: Add test cases for epair.

Mention PR for panic in ipv6 skip message.

Sun, Jun 2, 1:23 AM

Sat, Jun 1

ryan_freqlabs.com abandoned D20168: Start testing cloned interfaces.

I have created a new revision for just the epair tests here: https://reviews.freebsd.org/D20498

Sat, Jun 1, 11:52 PM · network
ryan_freqlabs.com created D20498: Add test cases for epair.
Sat, Jun 1, 11:48 PM

Mon, May 20

ryan_freqlabs.com added a comment to D20118: Fix erronious assert in libzfs diff.

ZoL commit: https://github.com/zfsonlinux/zfs/commit/9dc41a769df164875d974c2431b2453e70e16c41

Mon, May 20, 6:08 PM

May 6 2019

ryan_freqlabs.com added a comment to D20168: Start testing cloned interfaces.

I should also note that there are panics in the lagg tests, described in bugzilla here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234135

May 6 2019, 7:04 AM · network
ryan_freqlabs.com added a comment to D20168: Start testing cloned interfaces.

Perhaps the panics currently requiring tests to be skipped should be fixed before the skipped tests are enabled. Multicast cleanup is pending in the following revisions that I am aware of:
https://reviews.freebsd.org/D19886
https://reviews.freebsd.org/D20070

May 6 2019, 6:59 AM · network
ryan_freqlabs.com created D20168: Start testing cloned interfaces.
May 6 2019, 6:49 AM · network

May 1 2019

ryan_freqlabs.com created D20118: Fix erronious assert in libzfs diff.
May 1 2019, 1:06 AM

Apr 30 2019

ryan_freqlabs.com added a comment to D19886: Fix numerous refcount bugs in multicast ....

before running tests:

ether_multi    17     2K       -       17  16,32,64,128
   in_multi     2     1K       -        2  256
  in6_multi    15     2K       -       15  32,256
Apr 30 2019, 8:39 PM
ryan_freqlabs.com added a comment to D19886: Fix numerous refcount bugs in multicast ....

I have been running the tests in tests/sys/net with Matt's patch. Many of the test cases in if_clone_test are currently skipped due to panics, and with this patch I am now able to complete a run with those tests enabled. Doing so with mdnsresponder running exposes a different issue in an lo(4) test case, which will be something else to look into. I have also added test cases for epair(4), which pass as well. I will be putting my changes to enable these tests and add the epair test cases up for review shortly.

Apr 30 2019, 4:33 PM

Mar 22 2019

ryan_freqlabs.com updated the diff for D19640: oce: Simplify probe method.

Use existing struct pci_device_table and related macros as suggested by @imp

Mar 22 2019, 12:04 AM

Mar 19 2019

ryan_freqlabs.com created D19640: oce: Simplify probe method.
Mar 19 2019, 9:14 AM
ryan_freqlabs.com created D19638: oce: Give names to promisc bits.
Mar 19 2019, 8:56 AM
ryan_freqlabs.com created D19637: oce: Fix name collision in unhygenic macros.
Mar 19 2019, 8:49 AM

Feb 1 2019

ryan_freqlabs.com added reviewers for D18924: bridge: Fix spurious warnings about capabilities: kristof, mav, mmacy.
Feb 1 2019, 8:54 PM
ryan_freqlabs.com created D19052: usr.sbin/sesutil: Check element type before setting LEDs.
Feb 1 2019, 2:59 AM
ryan_freqlabs.com created D19051: cam/scsi: Use switch instead of chained if/else.
Feb 1 2019, 2:49 AM

Jan 22 2019

ryan_freqlabs.com updated the test plan for D18924: bridge: Fix spurious warnings about capabilities.
Jan 22 2019, 7:38 PM
ryan_freqlabs.com created D18924: bridge: Fix spurious warnings about capabilities.
Jan 22 2019, 7:28 PM

Oct 27 2018

ryan_freqlabs.com added a comment to D17697: Fix jail examples in jib, jng, README.

I do not. Please take it from here. Thanks!

Oct 27 2018, 5:25 PM
ryan_freqlabs.com updated the diff for D17697: Fix jail examples in jib, jng, README.

Reworded text to point out that netgraph modules are only needed for jng.

Oct 27 2018, 2:51 AM
ryan_freqlabs.com added a comment to D17697: Fix jail examples in jib, jng, README.

The rest of the examples in the README describe the steps for a persistent configuration and how to immediately bring the system to that state, without calling out the latter part as optional. However this does make me realize that it should be mentioned these steps are only for the jng examples and are not necessary for use of jib.

Oct 27 2018, 2:40 AM
ryan_freqlabs.com updated the diff for D17697: Fix jail examples in jib, jng, README.

Addressed feedback that only ng_ether must be manually loaded.

Oct 27 2018, 12:54 AM
ryan_freqlabs.com added a comment to D17697: Fix jail examples in jib, jng, README.

I missed the part about bridge and eiface autoloading, whoops!

Oct 27 2018, 12:47 AM
ryan_freqlabs.com updated the diff for D17697: Fix jail examples in jib, jng, README.

Addressed feedback by adding instructions for persistent loading of netgraph modules at boot.
(It's documented in rc.conf(5) that kld_list in rc.conf is preferable to loading with *_load in loader.conf because the kernel can load modules faster than loader.)

Oct 27 2018, 12:31 AM

Oct 25 2018

ryan_freqlabs.com created D17697: Fix jail examples in jib, jng, README.
Oct 25 2018, 4:58 AM

Oct 24 2018

ryan_freqlabs.com updated the diff for D17576: Allow changing lagg(4) MTU.

Addressed feedback by adding handling of new ports, so creating a lagg or adding new ports to an existing lagg sets all the port interfaces to the correct MTU automatically, too.

Oct 24 2018, 3:41 AM · network

Oct 16 2018

ryan_freqlabs.com updated the diff for D17576: Allow changing lagg(4) MTU.

Addressed feedback I received here and elsewhere on the previous patch. Please consider this alternative approach.

Oct 16 2018, 7:27 PM · network
ryan_freqlabs.com added a comment to D17576: Allow changing lagg(4) MTU.

For additional context, here is the code from if_bridge.c this is based on:

case SIOCSIFMTU:
        if (ifr->ifr_mtu < 576) {
                error = EINVAL;
                break;
        }
        if (LIST_EMPTY(&sc->sc_iflist)) {
                sc->sc_ifp->if_mtu = ifr->ifr_mtu;
                break;
        }
        BRIDGE_LOCK(sc);
        LIST_FOREACH(bif, &sc->sc_iflist, bif_next) {
                if (bif->bif_ifp->if_mtu != ifr->ifr_mtu) {
                        log(LOG_NOTICE, "%s: invalid MTU: %u(%s)"
                            " != %d\n", sc->sc_ifp->if_xname,
                            bif->bif_ifp->if_mtu,
                            bif->bif_ifp->if_xname, ifr->ifr_mtu);
                        error = EINVAL;
                        break;
                }
        }
        if (!error)
                sc->sc_ifp->if_mtu = ifr->ifr_mtu;
        BRIDGE_UNLOCK(sc);
        break;

It was not obvious to me why the minimum MTU should be limited by IPv4 but I included it here erring on the side of caution.

Oct 16 2018, 3:36 PM · network
ryan_freqlabs.com updated the diff for D17576: Allow changing lagg(4) MTU.

Bumped the date in the man page.

Oct 16 2018, 7:44 AM · network

Oct 15 2018

ryan_freqlabs.com created D17576: Allow changing lagg(4) MTU.
Oct 15 2018, 10:34 PM · network

Sep 24 2018

ryan_freqlabs.com updated the diff for D17169: Add quirk to disable NCQ TRIM for Samsung 860 SSDs.

Removed TRIM quirk. Added 4k quirk for SCSI da in addition to ATA da.

Sep 24 2018, 6:50 PM

Sep 15 2018

ryan_freqlabs.com added a comment to D17169: Add quirk to disable NCQ TRIM for Samsung 860 SSDs.
In D17169#366159, @imp wrote:

How were you able to determine this?
The latest version of Linux doesn't have this quirk.

Sep 15 2018, 4:26 AM

Sep 14 2018

ryan_freqlabs.com created D17169: Add quirk to disable NCQ TRIM for Samsung 860 SSDs.
Sep 14 2018, 9:04 AM

Jul 31 2018

ryan_freqlabs.com created D16534: e1000: Don't use 9k jumbo clusters.
Jul 31 2018, 8:00 PM

Aug 30 2016

ryan_freqlabs.com updated the diff for D7369: Eliminate unnecessary loop in _cap_check().

The variable i is not necessary, either.

Aug 30 2016, 1:48 AM

Aug 3 2016

ryan_freqlabs.com added a comment to D7369: Eliminate unnecessary loop in _cap_check().
In D7369#153325, @ed wrote:

Interesting. I suspect an older version of this code hand-rolled cap_rights_contains() and was incorrectly refactored?

Aug 3 2016, 10:02 AM
ryan_freqlabs.com created P105 random blocking dhclient for several seconds.
Aug 3 2016, 5:49 AM

Jul 30 2016

ryan_freqlabs.com updated D7369: Eliminate unnecessary loop in _cap_check().
Jul 30 2016, 8:05 AM
ryan_freqlabs.com updated D7369: Eliminate unnecessary loop in _cap_check().
Jul 30 2016, 8:00 AM
ryan_freqlabs.com retitled D7369: Eliminate unnecessary loop in _cap_check() from to Eliminate unnecessary loop in _cap_check().
Jul 30 2016, 7:49 AM