- User Since
- Jul 22 2016, 2:56 AM (192 w, 2 d)
Thu, Mar 26
@tsoome is efi console / teken in shape for this now?
Wed, Mar 18
Mon, Mar 16
Feb 27 2020
Feb 26 2020
Feb 25 2020
This is getting really close to the finish line.
Feb 23 2020
Feb 14 2020
Feb 6 2020
Jan 26 2020
I'll be taking a closer look when I get a chance but at a glance at the diff this looks like a much cleaner change now. Thank you for taking the time to work on it!
Jan 23 2020
Jan 18 2020
I have not inspected the code in depth, but there are a number of style violations that jump out at a glance. Fixing these various nits will make the changes easier to read for reviewers. Rather than clutter up the diff I'll just mention the key points:
- Several files appear to have been edited with 4-space indentation settings rather than hard tabs, in contrast with the surrounding code. The different whitespace is confusing/frustrating.
- A bunch of added functions in block_if.c should have a newline after the function return type, rather than a bunch of horizontal space.
See style(9) as a more detailed guide, but in general matching the style of surrounding code is most desirable.
Jan 17 2020
Sorry about that!
Jan 16 2020
@asomers Will you commit this for me? I don't have the bit. Thanks!
@cem Will you commit this for me? I don't have the bit. Thanks!
Jan 15 2020
@mckusick I would like to MFC your EINTEGRITY change to stable/12 along with this change. Does this seem reasonable? At a glance the only merge conflict is that stable/12 doesn't have contrib/libc++, so that part of the patch would be dropped. Anything else to look out for?
Thanks in advance!
Jan 14 2020
Looks reasonable. This will make its way into ZoF next time we rebase, since there aren't any platform-specific files changed. The port should be updated shortly thereafter.
Jan 11 2020
Add a comment explaining the motivation for the mapping.
Jan 7 2020
Incorporate feedback. Map the constants to existing errnos instead of adding messages for old numbers.
Jan 2 2020
@bcran Thanks! Would you mind committing this for me? I don't have the bit.
Incorporated in the TMPDIR revision: D22979
Dec 31 2019
Use $BSDINSTALL_CHROOT in place of /mnt for umount.
Dec 30 2019
Dec 27 2019
Add context to diff.
Nov 12 2019
Oct 31 2019
Oct 21 2019
I have recently looked at this function to port adapt it for ZoF. I like the overall idea here, but as a nit please do try matching the surrounding style. I would also find it easier to follow without the extra negations. Calling the bool skip_zvols would read more naturally to me.
Oct 13 2019
Oct 8 2019
Sep 26 2019
Use the correct escape sequence for reset in forth.
while we've transitioned to teken, it looks like it eats the ESC c
Sep 25 2019
This aims to reset more of the state to defaults, not just colors. Things like the scroll region for example, so we don't have all the output stuck on one line. There are a multitude of software/firmware/hardware issues that can cause the state to be unfavorable at boot. Loose serial connections, buggy firmware, etc. tsoome's work complements this change rather than invalidating it.
Sep 24 2019
I was a bit slow taking the screenshot and caught the menu mid-scroll but here it is in a black on white terminal:
Sep 23 2019
Eliminate menu local per review.
I moved the UEFI console resize to before the screen reset in loader.lua to be consistent with the order of this sequence in the forth loader.rc version. In doing so I noticed a few if blocks for the menu could be combined, so I combined them.
Sep 20 2019
Sorry, I do need to take a second look at this one. My terminal doesn't seem to be resetting the font brightness correctly when loader_color=YES in a bhyve VM looking at the serial console. Everything looks bolded until I reset the terminal again in the shell using `printf '\033c' and then it goes back to normal.
Thanks! Can I ask someone with a commit bit to please put this in for me?
Fixed up nearby code as requested
Sep 19 2019
Sep 16 2019
Delete redundant setting of in.dbsz in error case.
Fixed man page additions. Thanks, @bcr!
Sep 10 2019
Make conv=sync and iflag=fullblock mutually exclusive rather than silently ignoring the iflag.
Sep 3 2019
Aug 28 2019
Aug 27 2019
Aug 26 2019
I also plan to add support for iflag=fullblock in a follow-up revision.
Aug 23 2019
Aug 22 2019
I will check the result of close(2) in a follow-up patch as suggested in PR229616
I am planning a followup to add the fdatasync flag, as well.
Aug 20 2019
What is the motivation for being able to set 'compat.linux.osrelease=3.10.0-957.12.1.el7.x86_64'?
Aug 19 2019
Aug 18 2019
Aug 16 2019
Thank you for making this happen! I'm glad that you managed to reuse some code from ptnet. Is taking advantage of these pieces in vtnet on your radar as well?
Jul 18 2019
Jul 17 2019
Whoops, spotted a few more spelling errors.
Jul 16 2019
Jun 13 2019
By the way, I don't have commit access, so someone else will have to volunteer to commit this, please. Thanks!
Jun 2 2019
Mention PR for panic in ipv6 skip message.
Jun 1 2019
I have created a new revision for just the epair tests here: https://reviews.freebsd.org/D20498
May 20 2019
May 6 2019
I should also note that there are panics in the lagg tests, described in bugzilla here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234135
Perhaps the panics currently requiring tests to be skipped should be fixed before the skipped tests are enabled. Multicast cleanup is pending in the following revisions that I am aware of:
May 1 2019
Apr 30 2019
before running tests:
ether_multi 17 2K - 17 16,32,64,128 in_multi 2 1K - 2 256 in6_multi 15 2K - 15 32,256
I have been running the tests in tests/sys/net with Matt's patch. Many of the test cases in if_clone_test are currently skipped due to panics, and with this patch I am now able to complete a run with those tests enabled. Doing so with mdnsresponder running exposes a different issue in an lo(4) test case, which will be something else to look into. I have also added test cases for epair(4), which pass as well. I will be putting my changes to enable these tests and add the epair test cases up for review shortly.
Mar 22 2019
Use existing struct pci_device_table and related macros as suggested by @imp